Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

radare2: 2.8.0 -> 2.9.0, radare2-cutter: 1.7 -> 1.7.1 #46070

Merged
merged 3 commits into from Sep 5, 2018
Merged

radare2: 2.8.0 -> 2.9.0, radare2-cutter: 1.7 -> 1.7.1 #46070

merged 3 commits into from Sep 5, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 4, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 requested a review from dtzWill September 4, 2018 22:07
@Mic92
Copy link
Member Author

Mic92 commented Sep 4, 2018

@GrahamcOfBorg build radare2 radare2-cutter

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: radare2, radare2-cutter

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: radare2, radare2-cutter

Partial log (click to expand)

shrinking /nix/store/8rj1dmwa90b6wsk4rgjswlp3aqpkskwc-radare2-cutter-1.7.1/bin/Cutter
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8rj1dmwa90b6wsk4rgjswlp3aqpkskwc-radare2-cutter-1.7.1/bin
patching script interpreter paths in /nix/store/8rj1dmwa90b6wsk4rgjswlp3aqpkskwc-radare2-cutter-1.7.1
checking for references to /build in /nix/store/8rj1dmwa90b6wsk4rgjswlp3aqpkskwc-radare2-cutter-1.7.1...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/c0b5gg5r14gkdjcclf1p7dbrik4whbaa-radare2-2.9.0
/nix/store/8rj1dmwa90b6wsk4rgjswlp3aqpkskwc-radare2-cutter-1.7.1

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: radare2, radare2-cutter

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: radare2, radare2-cutter

Partial log (click to expand)

shrinking /nix/store/w5dax598lshddybg0h5636gl2vfqh6cz-radare2-cutter-1.7.1/bin/Cutter
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/w5dax598lshddybg0h5636gl2vfqh6cz-radare2-cutter-1.7.1/bin
patching script interpreter paths in /nix/store/w5dax598lshddybg0h5636gl2vfqh6cz-radare2-cutter-1.7.1
checking for references to /build in /nix/store/w5dax598lshddybg0h5636gl2vfqh6cz-radare2-cutter-1.7.1...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/mzbd90qpjsygbsb080w41zc7j5q7792a-radare2-2.9.0
/nix/store/w5dax598lshddybg0h5636gl2vfqh6cz-radare2-cutter-1.7.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: radare2, radare2-cutter

Partial log (click to expand)

/nix/store/mzbd90qpjsygbsb080w41zc7j5q7792a-radare2-2.9.0
/nix/store/w5dax598lshddybg0h5636gl2vfqh6cz-radare2-cutter-1.7.1

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: radare2, radare2-cutter

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: radare2, radare2-cutter

Partial log (click to expand)

shrinking /nix/store/8rj1dmwa90b6wsk4rgjswlp3aqpkskwc-radare2-cutter-1.7.1/bin/Cutter
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/8rj1dmwa90b6wsk4rgjswlp3aqpkskwc-radare2-cutter-1.7.1/bin
patching script interpreter paths in /nix/store/8rj1dmwa90b6wsk4rgjswlp3aqpkskwc-radare2-cutter-1.7.1
checking for references to /build in /nix/store/8rj1dmwa90b6wsk4rgjswlp3aqpkskwc-radare2-cutter-1.7.1...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/c0b5gg5r14gkdjcclf1p7dbrik4whbaa-radare2-2.9.0
/nix/store/8rj1dmwa90b6wsk4rgjswlp3aqpkskwc-radare2-cutter-1.7.1

@dtzWill
Copy link
Member

dtzWill commented Sep 5, 2018

LGTM, thanks!

@dtzWill dtzWill merged commit e9d4bab into NixOS:master Sep 5, 2018
@Mic92 Mic92 deleted the radare2 branch September 5, 2018 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @GrahamcOfBorg @dtzWill