Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texinfo: fix for the new perl #46075

Merged
merged 2 commits into from
Sep 6, 2018
Merged

texinfo: fix for the new perl #46075

merged 2 commits into from
Sep 6, 2018
+49 −7

Conversation

oxij
Copy link
Member

@oxij oxij commented Sep 5, 2018 •
edited
Loading

Motivation for this change

Two perl versions are a bit too much.

Things done
  • It builds and passes its own tests.
  • Saves a bunch of space.

I think this should be stable enough for staging-next. Added a hack to prevent mass-rebuild, rebased onto master.

/cc @vcunat

Sorry, something went wrong.

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on aarch64-linux (full log)

Attempted: texinfo

Partial log (click to expand)

cannot build derivation '/nix/store/zlfqhvv06my0xpn3wxwmd7f9vxhg202n-diffutils-3.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/4qx3kzdff6r38lkvrm7a3ns14cf9rnyf-findutils-4.6.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/xj0dwg3mwg5np6s87lvdlg903v029pi7-libtool-2.4.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/609q7nc4hyc9vrd8ax17xabplq0z45ra-gcc-wrapper-7.3.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/dilyz9aswf0pa293hwd8bmqngjc4c4v4-hook.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/5m5qmd7987ksgnm06iq9asxb40p08499-patch-2.7.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/ajfcjr7ciiw53zbwy56bphv42ci42c4a-stdenv-linux.drv': 25 dependencies couldn't be built
cannot build derivation '/nix/store/xdh6pvq95dldk6wy64l2593rhs45kc3w-perl-5.28.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/8dhb3alamarg0dbarka9n9m3i538192n-texinfo-6.5.drv': 5 dependencies couldn't be built
error: build of '/nix/store/8dhb3alamarg0dbarka9n9m3i538192n-texinfo-6.5.drv' failed

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: texinfo

Partial log (click to expand)

cannot build derivation '/nix/store/bvnwvp0rgq7dby74pqrhky3fgxz9pg8q-diffutils-3.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/nbaa55nqjx3mav74lh40xzp05h4884fx-findutils-4.6.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/1009mrd2k0p3bpr3bbdd9ix04cax75sr-libtool-2.4.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/hbwmg01lhfa2prna7nd3226bkwwc4hy0-gcc-wrapper-7.3.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/sx2bl40fwy5rz5bnzjlsb8750imcwdxr-hook.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/gckak2f7d45nw79j44y8fmfcx54lnq3s-patch-2.7.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/hxa2rslywikmaskzn98pih2qjxs47z1l-stdenv-linux.drv': 23 dependencies couldn't be built
cannot build derivation '/nix/store/1sgbij6fx5yknj1lh3mwkwzvciczf1ph-perl-5.28.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/f35dx6q0xr5v15bkc8na7z0zxpdzbb7m-texinfo-6.5.drv': 5 dependencies couldn't be built
error: build of '/nix/store/f35dx6q0xr5v15bkc8na7z0zxpdzbb7m-texinfo-6.5.drv' failed

@oxij oxij force-pushed the pkgs/fix-texinfo-perl branch from 2a350a8 to 2cdb94b Compare September 5, 2018 16:33
@oxij oxij requested a review from FRidh as a code owner September 5, 2018 16:33
@oxij oxij changed the base branch from staging-next to master September 5, 2018 16:34
@FRidh FRidh removed their request for review September 5, 2018 16:35
@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` and removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 5, 2018
oxij added 2 commits September 5, 2018 16:39
@oxij
texinfo: fix perl issues by applying patches from upstream

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
2ad99bc
@oxij
Revert "texinfoInteractive: fixup build by using older perl"

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
0b89ece 
This reverts commit 7a22083.
@oxij oxij force-pushed the pkgs/fix-texinfo-perl branch from 2cdb94b to 0b89ece Compare September 5, 2018 16:40
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: texinfo

Partial log (click to expand)

/nix/store/1yzj6v7nbs2c2xjnd49jmm7my0bfjqwv-texinfo-6.5

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: texinfo

Partial log (click to expand)

these paths will be fetched (1.06 MiB download, 9.18 MiB unpacked):
  /nix/store/4i17crc8xvqr94vl0z1c2pd7kfxv11vf-texinfo-6.5
copying path '/nix/store/4i17crc8xvqr94vl0z1c2pd7kfxv11vf-texinfo-6.5' from 'https://cache.nixos.org'...
/nix/store/4i17crc8xvqr94vl0z1c2pd7kfxv11vf-texinfo-6.5

@oxij
Copy link
Member Author

oxij commented Sep 5, 2018

Added a hack to prevent mass-rebuild, rebased onto master.

Why OfBorg thinks I added a new package I have no idea.

@xeji
Copy link
Contributor

xeji commented Sep 5, 2018

Cool hack 👍 Let's try the darwin build as well:
@GrahamcOfBorg build texinfo texinfoInteractive

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: texinfo, texinfoInteractive

Partial log (click to expand)

shrinking /nix/store/lp3ihw90j5d29blwxp9cf3y80s07flky-texinfo-interactive-6.5/lib/texinfo/XSParagraph.so
gzipping man pages under /nix/store/lp3ihw90j5d29blwxp9cf3y80s07flky-texinfo-interactive-6.5/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/lp3ihw90j5d29blwxp9cf3y80s07flky-texinfo-interactive-6.5/lib  /nix/store/lp3ihw90j5d29blwxp9cf3y80s07flky-texinfo-interactive-6.5/bin
patching script interpreter paths in /nix/store/lp3ihw90j5d29blwxp9cf3y80s07flky-texinfo-interactive-6.5
/nix/store/lp3ihw90j5d29blwxp9cf3y80s07flky-texinfo-interactive-6.5/bin/texi2pdf: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/lp3ihw90j5d29blwxp9cf3y80s07flky-texinfo-interactive-6.5/bin/texindex: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/lp3ihw90j5d29blwxp9cf3y80s07flky-texinfo-interactive-6.5/bin/pdftexi2dvi: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/lp3ihw90j5d29blwxp9cf3y80s07flky-texinfo-interactive-6.5/bin/texi2dvi: interpreter directive changed from " /bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/lp3ihw90j5d29blwxp9cf3y80s07flky-texinfo-interactive-6.5...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: texinfo, texinfoInteractive

Partial log (click to expand)

strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/92901x6a118nasi1rrnaqg839x3bvyrr-texinfo-interactive-6.5/lib  /nix/store/92901x6a118nasi1rrnaqg839x3bvyrr-texinfo-interactive-6.5/bin
patching script interpreter paths in /nix/store/92901x6a118nasi1rrnaqg839x3bvyrr-texinfo-interactive-6.5
/nix/store/92901x6a118nasi1rrnaqg839x3bvyrr-texinfo-interactive-6.5/bin/pdftexi2dvi: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/92901x6a118nasi1rrnaqg839x3bvyrr-texinfo-interactive-6.5/bin/texi2pdf: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/92901x6a118nasi1rrnaqg839x3bvyrr-texinfo-interactive-6.5/bin/texi2dvi: interpreter directive changed from " /bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/92901x6a118nasi1rrnaqg839x3bvyrr-texinfo-interactive-6.5/bin/texindex: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/92901x6a118nasi1rrnaqg839x3bvyrr-texinfo-interactive-6.5...
/nix/store/1yzj6v7nbs2c2xjnd49jmm7my0bfjqwv-texinfo-6.5
/nix/store/92901x6a118nasi1rrnaqg839x3bvyrr-texinfo-interactive-6.5

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: texinfo, texinfoInteractive

Partial log (click to expand)

gzipping man pages under /nix/store/2pxgbkcr847b57b3c9w3z3iff7nby5hr-texinfo-interactive-6.5/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/2pxgbkcr847b57b3c9w3z3iff7nby5hr-texinfo-interactive-6.5/lib  /nix/store/2pxgbkcr847b57b3c9w3z3iff7nby5hr-texinfo-interactive-6.5/bin
patching script interpreter paths in /nix/store/2pxgbkcr847b57b3c9w3z3iff7nby5hr-texinfo-interactive-6.5
/nix/store/2pxgbkcr847b57b3c9w3z3iff7nby5hr-texinfo-interactive-6.5/bin/pdftexi2dvi: interpreter directive changed from "/bin/sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
/nix/store/2pxgbkcr847b57b3c9w3z3iff7nby5hr-texinfo-interactive-6.5/bin/texi2dvi: interpreter directive changed from " /bin/sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
/nix/store/2pxgbkcr847b57b3c9w3z3iff7nby5hr-texinfo-interactive-6.5/bin/texi2pdf: interpreter directive changed from "/bin/sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
/nix/store/2pxgbkcr847b57b3c9w3z3iff7nby5hr-texinfo-interactive-6.5/bin/texindex: interpreter directive changed from "/bin/sh" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/sh"
/nix/store/gj1fmxhln1jlwhbi4ivldrp3zpndlmr9-texinfo-6.5
/nix/store/2pxgbkcr847b57b3c9w3z3iff7nby5hr-texinfo-interactive-6.5

@vcunat vcunat added the 6.topic: closure size The final size of a derivation, including its dependencies label Sep 6, 2018
vcunat
vcunat approved these changes Sep 6, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patches taken from upstream, low impact if this package breaks for some reason.

vcunat added a commit that referenced this pull request Sep 6, 2018
@vcunat
Merge #46075: texinfoInteractive: fix for new perl

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
f03d105 
(cherry picked from commit b5bd566)
@vcunat vcunat merged commit 0b89ece into NixOS:master Sep 6, 2018
vcunat added a commit that referenced this pull request Sep 6, 2018
@vcunat
Merge #46075: texinfoInteractive: fix for new perl
b5bd566
@vcunat
Copy link
Member

vcunat commented Sep 6, 2018

I didn't know this hack. Usually I use null attribute values (instead of null attribute names).

@oxij oxij deleted the pkgs/fix-texinfo-perl branch November 18, 2018 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat

Assignees
No one assigned
Labels
6.topic: closure size The final size of a derivation, including its dependencies 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oxij @GrahamcOfBorg @xeji @vcunat