Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statsd: mark broken, disable nixos test #46097

Merged
merged 1 commit into from Sep 5, 2018
Merged

statsd: mark broken, disable nixos test #46097

merged 1 commit into from Sep 5, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 5, 2018 •
edited

Motivation for this change

It's broken with node v8 and the upstream project is dead (last commit Nov. 2016), see #45946 and statsd/statsd#646, so mark it broken and disable the NixOS test.

Alternatives considered (but decided against):

  • revert to node v6 ? Not worth the work and overhead for a dead project.
  • drop it completely: Not yet, because some other nixos modules seem to reference the term statsd, and we need time to figure out whether they actually depend on our statsd package/module.

Needs backporting ZHF #45960

closes #45946

cc @Ma27

@xeji
statsd: mark broken, disable nixos test
545c37c 
It's broken with node v8 and the upstream project is dead
(last commit Nov. 2016), see NixOS#45946 and
statsd/statsd#646
@srhb srhb self-requested a review September 5, 2018 12:58
srhb
srhb approved these changes Sep 5, 2018
View reviewed changes
Copy link
Contributor

@srhb srhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right approach. We can keep the infrastructure in place but commented out until we can try and shoehorn eg. https://github.com/bitly/statsdaemon in. I don't think it should be hard.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: statsd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: statsd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: statsd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Ma27
Ma27 reviewed Sep 5, 2018
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is IMHO the best approach for now. I guess that we can drop it entirely for 19.03 right?

@xeji
Copy link
Contributor Author

xeji commented Sep 5, 2018

I guess that we can drop it entirely for 19.03 right?

Yes, and replace it with something similar (but working) as @srhb suggested.

@xeji xeji merged commit ba52f4c into NixOS:master Sep 5, 2018
@xeji xeji deleted the p/statsd-broken branch September 5, 2018 14:48
xeji added a commit that referenced this pull request Sep 5, 2018
@xeji
statsd: mark broken, disable nixos test (#46097)
3f70d89 
It's broken with node v8 and the upstream project is dead
(last commit Nov. 2016), see #45946 and
statsd/statsd#646

(cherry picked from commit ba52f4c)
@xeji
Copy link
Contributor Author

xeji commented Sep 5, 2018

backport: 3f70d89

@Mic92
Copy link
Member

Mic92 commented Sep 5, 2018

I think we have also other competitive graphing/timeseries services that user can use instead. I would not add a statsd replacement unless someone wants to maintain/use it.

@Mic92
Copy link
Member

Mic92 commented Sep 5, 2018

This one looks also not good maintained: https://github.com/bitly/statsdaemon/releases

@Mic92
Copy link
Member

Mic92 commented Sep 5, 2018

Removal for 19.03 sounds good to me.

@xeji xeji mentioned this pull request Sep 5, 2018
Closed
@xeji
Copy link
Contributor Author

xeji commented Sep 5, 2018

Opened #46118 as a reminder

@Mic92 Mic92 mentioned this pull request Nov 9, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 left review comments

@srhb srhb srhb approved these changes

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

statsd 0.8.0: fails to start up (runtime error)
6 participants
@xeji @GrahamcOfBorg @Mic92 @srhb @vcunat @Ma27