trivial: treewide: random noop cleanups #46076
Conversation
This was introduced when it was unclear which suffix was better, but now it's clear that the "For" convention won.
GrahamcOfBorg
added
6.topic: stdenv
|
Success on aarch64-linux (full log) Attempted: stdenv Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: stdenv Partial log (click to expand)
|
|
@Ericson2314 So, do you want me to change something here? |
|
Yes actually. See 54282b9 my TODO exists because it should go back to being just a simple |
|
Actually no the nix parameter cannot be removed, but the environment variable can. Anyways, just drop those TODO removes from this, and I'll clean up GHC separately. |
|
Success on x86_64-linux (full log) Attempted: stdenv Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: stdenv Partial log (click to expand)
|
| @@ -16022,7 +16022,7 @@ with pkgs; | |||
| ImageCaptureCore GSS ImageIO; | |||
| }; | |||
|
|
|||
| emacsPackagesGen = emacs: self: let callPackage = newScope self; in rec { | |||
| emacsPackagesFor = emacs: self: let callPackage = newScope self; in rec { | |||
There was a problem hiding this comment.
Does this need an alias.nix entry? Not sure whether this was intended to be user-exposed.
|
Done.
I have a bunch more cleanups (that need a mass rebuild, so they'll come later) and when doing those I had a problem with your TODO in `openssl` expression. Please look at that one too.
|
|
Does this need an alias.nix entry? Not sure whether this was intended to be user-exposed.
Yes it was, you'd have to use it if you want to override `emacs` in your config. Like, say, enable gtk3.
|
|
OK all makes sense. Looks good. |
Motivation for this change
OCD.
Things done