Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ffmpeg: add support for libssh and speex #46078

Merged
merged 1 commit into from Sep 5, 2018
Merged

ffmpeg: add support for libssh and speex #46078

merged 1 commit into from Sep 5, 2018

Conversation

oxij
Copy link
Member

@oxij oxij commented Sep 5, 2018

Motivation for this change

Pretty useful.

Things done
  • Worked before rebase.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ffmpeg

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/2887rms3666syjnp5czaa8k0yy5zm04z-ffmpeg-3.4.4-man
gzipping man pages under /nix/store/2887rms3666syjnp5czaa8k0yy5zm04z-ffmpeg-3.4.4-man/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/2887rms3666syjnp5czaa8k0yy5zm04z-ffmpeg-3.4.4-man
checking for references to /build in /nix/store/2887rms3666syjnp5czaa8k0yy5zm04z-ffmpeg-3.4.4-man...
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
Moving /nix/store/3krsfky80xlm94x4lww7vjsdy3ny9hnd-ffmpeg-3.4.4/bin to /nix/store/b0bk70ndy3k7f12jiya1rhs1kmi7v9cs-ffmpeg-3.4.4-bin/bin
rmdir: failed to remove '/nix/store/3krsfky80xlm94x4lww7vjsdy3ny9hnd-ffmpeg-3.4.4': Directory not empty
Moving /nix/store/3krsfky80xlm94x4lww7vjsdy3ny9hnd-ffmpeg-3.4.4/share/ffmpeg/examples to /nix/store/5wkzjf3vjlh54qrh15fmj01i65g1xw4q-ffmpeg-3.4.4-doc/share/ffmpeg/examples
rmdir: failed to remove '/nix/store/3krsfky80xlm94x4lww7vjsdy3ny9hnd-ffmpeg-3.4.4/share/ffmpeg': Directory not empty

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on aarch64-linux (full log)

Attempted: ffmpeg

Partial log (click to expand)

warning: unable to download 'https://cache.nixos.org/nar/19zq0q2ba8953491fhsmyxpi41xy3dbnzfms84318fwm92xh0azc.nar.xz': Stream error in the HTTP/2 framing layer (92); retrying in 1024 ms
warning: unable to download 'https://cache.nixos.org/nar/1369fhfykrfqjnmlbz41n7ahk0hi7yy5alq1209r5wkazf95pl9f.nar.xz': Error in the HTTP2 framing layer (16); retrying in 2606 ms
error 9 while decompressing xz file
cannot build derivation '/nix/store/p33ab2i86ha4qjz9hhgkbwfhgapd53l4-graphviz-2.40.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/djagm9nq4canrfqlpkqkjnrsns3c5i0f-vala-0.40.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/fh3gwip2illdqmhhhxckp0wmh01la34g-dconf-0.28.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/wgavkfrb7zj0n39bdpbhksb1fg7bi4sr-libpulseaudio-12.2.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/d9w6159hsvfbbqs6f9295qjr833g5wkx-SDL2-2.0.8.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/f8pbkxb29fhg2g85cyps0xscnr4ixq47-ffmpeg-3.4.4.drv': 16 dependencies couldn't be built
error: build of '/nix/store/f8pbkxb29fhg2g85cyps0xscnr4ixq47-ffmpeg-3.4.4.drv' failed

@xeji
Copy link
Contributor

xeji commented Sep 5, 2018

That aarch64 error looks transient, lets try again.
@GrahamcOfBorg build ffmpeg

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on x86_64-darwin (full log)

Attempted: ffmpeg

Partial log (click to expand)

copying path '/nix/store/r1ng1gnif0fshhgbnf7ynkwgq7pa65xf-x265-2.7' from 'https://cache.nixos.org'...
copying path '/nix/store/pkdnin7xsqvzc86009x4kwz6p53jm6l3-gnutls-3.5.10-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/69mgl6yxr6hdindfpaj0ak7z6ndclzlx-xproto-7.0.31' from 'https://cache.nixos.org'...
copying path '/nix/store/m6k3afjligiw2my4gg7f9iifyzzxb4q4-xvidcore-1.3.5' from 'https://cache.nixos.org'...
copying path '/nix/store/yj25298libkh2ljylswiy9zvdi3s01z5-libX11-1.6.6-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/rkyz9giaxxl7bg74a9f45539ih09cbka-yasm-1.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/1z4vn9p9m4znixm2ig3as308mah9zszd-SDL2-2.0.8-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/b02wqj15pri4i6mz14abwlsr9zfpxm8g-libvdpau-1.1.1-dev' from 'https://cache.nixos.org'...
cannot build derivation '/nix/store/gdvl58lv8wx3adgywbr4glyb1sn4by9z-ffmpeg-3.4.4.drv': 1 dependencies couldn't be built
error: build of '/nix/store/gdvl58lv8wx3adgywbr4glyb1sn4by9z-ffmpeg-3.4.4.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ffmpeg

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/2887rms3666syjnp5czaa8k0yy5zm04z-ffmpeg-3.4.4-man
gzipping man pages under /nix/store/2887rms3666syjnp5czaa8k0yy5zm04z-ffmpeg-3.4.4-man/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/2887rms3666syjnp5czaa8k0yy5zm04z-ffmpeg-3.4.4-man
checking for references to /build in /nix/store/2887rms3666syjnp5czaa8k0yy5zm04z-ffmpeg-3.4.4-man...
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
Moving /nix/store/3krsfky80xlm94x4lww7vjsdy3ny9hnd-ffmpeg-3.4.4/bin to /nix/store/b0bk70ndy3k7f12jiya1rhs1kmi7v9cs-ffmpeg-3.4.4-bin/bin
rmdir: failed to remove '/nix/store/3krsfky80xlm94x4lww7vjsdy3ny9hnd-ffmpeg-3.4.4': Directory not empty
Moving /nix/store/3krsfky80xlm94x4lww7vjsdy3ny9hnd-ffmpeg-3.4.4/share/ffmpeg/examples to /nix/store/5wkzjf3vjlh54qrh15fmj01i65g1xw4q-ffmpeg-3.4.4-doc/share/ffmpeg/examples
rmdir: failed to remove '/nix/store/3krsfky80xlm94x4lww7vjsdy3ny9hnd-ffmpeg-3.4.4/share/ffmpeg': Directory not empty

@xeji
Copy link
Contributor

xeji commented Sep 5, 2018

Darwin error is a 504 (Gateway Timeout) accessing the cache, looks unrelated:

unable to download 'https://cache.nixos.org/nar/0qcjkw8n1ll86mp785gmkbq2l93z1vy3749mgv2bzcb9a3rcz7rk.nar.xz': HTTP error 504 (curl error: No error)

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ffmpeg

Partial log (click to expand)

gzipping man pages under /nix/store/08fpq3b1d5qbcml8cbjinyhw8jq50g4v-ffmpeg-3.4.4-man/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/08fpq3b1d5qbcml8cbjinyhw8jq50g4v-ffmpeg-3.4.4-man
checking for references to /build in /nix/store/08fpq3b1d5qbcml8cbjinyhw8jq50g4v-ffmpeg-3.4.4-man...
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
Moving /nix/store/y1ada7r1g6xv35y1k5485il4qlfvjn6j-ffmpeg-3.4.4/bin to /nix/store/0i5nlz58q5gkm0hl99ybx2w9dwcvgn57-ffmpeg-3.4.4-bin/bin
rmdir: failed to remove '/nix/store/y1ada7r1g6xv35y1k5485il4qlfvjn6j-ffmpeg-3.4.4': Directory not empty
Moving /nix/store/y1ada7r1g6xv35y1k5485il4qlfvjn6j-ffmpeg-3.4.4/share/ffmpeg/examples to /nix/store/15aah9cm9lb763r7j3qymbfdrb6kh4ms-ffmpeg-3.4.4-doc/share/ffmpeg/examples
rmdir: failed to remove '/nix/store/y1ada7r1g6xv35y1k5485il4qlfvjn6j-ffmpeg-3.4.4/share/ffmpeg': Directory not empty
/nix/store/0i5nlz58q5gkm0hl99ybx2w9dwcvgn57-ffmpeg-3.4.4-bin

@xeji xeji merged commit 6abd750 into NixOS:staging Sep 5, 2018
@oxij
Copy link
Member Author

oxij commented Sep 5, 2018

Thanks!

@edolstra
Copy link
Member

edolstra commented Sep 5, 2018

Please make this optional and disabled by default. ffmpeg is already bloated enough.

@xeji
Copy link
Contributor

xeji commented Sep 5, 2018

ffmpeg closure before this change: 128838k, after: 129560k.
The difference is 585k for libssh and 116k for speex. Not a big deal IMO.

vcunat added a commit that referenced this pull request Oct 2, 2018
@vcunat
ffmpeg: unbreak build of older versions after #46078
56621c0 
As in the other cases, I didn't care about passing the dependency
if unused...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oxij @GrahamcOfBorg @xeji @edolstra