Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.{tyxml,lwt}: always enable camlp4 support #46089

Merged
merged 1 commit into from Sep 5, 2018
Merged

ocamlPackages.{tyxml,lwt}: always enable camlp4 support #46089

merged 1 commit into from Sep 5, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 5, 2018

Motivation for this change

camlp4 is now available for OCaml 4.07

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Sep 5, 2018

@GrahamcOfBorg build ocamlPackages_latest.lwt ocamlPackages_latest.tyxml

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ocamlPackages_latest.tyxml

The following builds were skipped because they don't evaluate on x86_64-darwin: ocamlPackages_latest.lwt

Partial log (click to expand)

Installed /nix/store/0cmhc62lv9mjvm985d5d49yxz48yxgwa-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/svg_f.cmx
Installed /nix/store/0cmhc62lv9mjvm985d5d49yxz48yxgwa-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/xml_print.cmx
Installed /nix/store/0cmhc62lv9mjvm985d5d49yxz48yxgwa-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/xml_wrap.cmx
Installed /nix/store/0cmhc62lv9mjvm985d5d49yxz48yxgwa-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/xml_iter.cmx
Installed /nix/store/0cmhc62lv9mjvm985d5d49yxz48yxgwa-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/META
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/0cmhc62lv9mjvm985d5d49yxz48yxgwa-ocaml4.07.0-tyxml-4.2.0/lib  /nix/store/0cmhc62lv9mjvm985d5d49yxz48yxgwa-ocaml4.07.0-tyxml-4.2.0/bin
patching script interpreter paths in /nix/store/0cmhc62lv9mjvm985d5d49yxz48yxgwa-ocaml4.07.0-tyxml-4.2.0
/nix/store/0cmhc62lv9mjvm985d5d49yxz48yxgwa-ocaml4.07.0-tyxml-4.2.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ocamlPackages_latest.tyxml

The following builds were skipped because they don't evaluate on x86_64-linux: ocamlPackages_latest.lwt

Partial log (click to expand)

shrinking /nix/store/7mz520k2axrkppdn7np65ap4gr4fn2x3-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/tyxml_top.cmxs
shrinking /nix/store/7mz520k2axrkppdn7np65ap4gr4fn2x3-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/ppx_tyxml.cmxs
shrinking /nix/store/7mz520k2axrkppdn7np65ap4gr4fn2x3-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/pa_tyxml.cmxs
shrinking /nix/store/7mz520k2axrkppdn7np65ap4gr4fn2x3-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/tyxml_tools.cmxs
shrinking /nix/store/7mz520k2axrkppdn7np65ap4gr4fn2x3-ocaml4.07.0-tyxml-4.2.0/bin/ppx_tyxml_standalone
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7mz520k2axrkppdn7np65ap4gr4fn2x3-ocaml4.07.0-tyxml-4.2.0/lib  /nix/store/7mz520k2axrkppdn7np65ap4gr4fn2x3-ocaml4.07.0-tyxml-4.2.0/bin
patching script interpreter paths in /nix/store/7mz520k2axrkppdn7np65ap4gr4fn2x3-ocaml4.07.0-tyxml-4.2.0
checking for references to /build in /nix/store/7mz520k2axrkppdn7np65ap4gr4fn2x3-ocaml4.07.0-tyxml-4.2.0...
/nix/store/7mz520k2axrkppdn7np65ap4gr4fn2x3-ocaml4.07.0-tyxml-4.2.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ocamlPackages_latest.tyxml

The following builds were skipped because they don't evaluate on aarch64-linux: ocamlPackages_latest.lwt

Partial log (click to expand)

shrinking /nix/store/fwb7kcq77r3b5kadx2ws3nxfdq92ww5x-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/ppx_tyxml.cmxs
shrinking /nix/store/fwb7kcq77r3b5kadx2ws3nxfdq92ww5x-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/pa_tyxml.cmxs
shrinking /nix/store/fwb7kcq77r3b5kadx2ws3nxfdq92ww5x-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/tyxml_tools.cmxs
shrinking /nix/store/fwb7kcq77r3b5kadx2ws3nxfdq92ww5x-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/tyxml_top.cmxs
shrinking /nix/store/fwb7kcq77r3b5kadx2ws3nxfdq92ww5x-ocaml4.07.0-tyxml-4.2.0/lib/ocaml/4.07.0/site-lib/tyxml/tyxml.cmxs
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/fwb7kcq77r3b5kadx2ws3nxfdq92ww5x-ocaml4.07.0-tyxml-4.2.0/lib  /nix/store/fwb7kcq77r3b5kadx2ws3nxfdq92ww5x-ocaml4.07.0-tyxml-4.2.0/bin
patching script interpreter paths in /nix/store/fwb7kcq77r3b5kadx2ws3nxfdq92ww5x-ocaml4.07.0-tyxml-4.2.0
checking for references to /build in /nix/store/fwb7kcq77r3b5kadx2ws3nxfdq92ww5x-ocaml4.07.0-tyxml-4.2.0...
/nix/store/fwb7kcq77r3b5kadx2ws3nxfdq92ww5x-ocaml4.07.0-tyxml-4.2.0

@Mic92 Mic92 merged commit f9e7de9 into NixOS:master Sep 5, 2018
@vbgl vbgl deleted the ocaml-4.07-enableP4 branch September 5, 2018 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @Mic92 @GrahamcOfBorg