Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdenv: implement enableParallelChecking option #46079

Merged
merged 3 commits into from Sep 5, 2018
Merged

stdenv: implement enableParallelChecking option #46079

merged 3 commits into from Sep 5, 2018

Conversation

oxij
Copy link
Member

@oxij oxij commented Sep 5, 2018

Motivation for this change

Building and running tests with lots of cores, but fixing upstream Makefiles is hard.

#33599 ("Run check phase by default"). This is yet another^5 followup to #39464 ("stdenv: implement most of #33599").

Things done
  • Worked before rebase.

@oxij
stdenv: implement enableParallelChecking option
c63ca0a 
Works similarly to `enableParallelBuilding`, but is set by default when
`enableParallelBuilding` is set. In my experience most packages that build
fine in parallel also check fine in parallel.
@oxij
gettext: disable parallel checking
20106e1
@oxij
tor: disable parallel checking
e48f2d0
@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: gettext, stdenv, tor

Partial log (click to expand)

cannot build derivation '/nix/store/12wgxvhg417y0i9zwxwzcx1018zjbmwf-python3.6-lxml-4.2.4.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/a20sfincf5mwi5l130i9rxmbxdk4k5a3-torsocks-2.2.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/imsmjcc80wwdk46hdywqsh1wqgfwp34k-gnome-doc-utils-0.20.10.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/0381ch27zgrdr1y53506pcnmaw4q64sp-python3-3.6.6-env.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/gbhwcki1c0d8av5gg7qg3kpr4r8zvski-shadow-4.6.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/g48bgbfj07cwgxqfph0pnqsza6n9c2fj-util-linux-2.32.1.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/39d87vy3qdvz135fpvxh3rvmpxznnwh2-glib-2.56.0.drv': 11 dependencies couldn't be built
cannot build derivation '/nix/store/jhh86cpapcd6vm2vi5mzc4dm343ysxpz-systemd-239.drv': 42 dependencies couldn't be built
cannot build derivation '/nix/store/rlhwl47dypmbp3l8hr4i4pnmzr6amvf1-tor-0.3.3.9.drv': 9 dependencies couldn't be built
error: build of '/nix/store/ndaakyzvr7ra8k0f49vlh6b64hma3yb2-stdenv-linux.drv', '/nix/store/p15lxp19cr53x2w8fbry06ys6r5z3zl4-gettext-0.19.8.1.drv', '/nix/store/rlhwl47dypmbp3l8hr4i4pnmzr6amvf1-tor-0.3.3.9.drv' failed

@GrahamcOfBorg
Copy link

Unexpected error: command failed with exit code 1 on aarch64-linux (full log)

Attempted: gettext, stdenv, tor

Partial log (click to expand)

checking for references to /build in /nix/store/hljn7srinmriwz1jlgidw6c8ay9sak83-util-linux-2.32.1...
shrinking RPATHs of ELF executables and libraries in /nix/store/lijzpjivqbqqsw0bpbyl9kx2kalvmrc6-util-linux-2.32.1-man
gzipping man pages under /nix/store/lijzpjivqbqqsw0bpbyl9kx2kalvmrc6-util-linux-2.32.1-man/share/man/
strip is /nix/store/b27fx9fb7dngr563b0dy9krhgk2ap01w-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/lijzpjivqbqqsw0bpbyl9kx2kalvmrc6-util-linux-2.32.1-man
checking for references to /build in /nix/store/lijzpjivqbqqsw0bpbyl9kx2kalvmrc6-util-linux-2.32.1-man...
cannot build derivation '/nix/store/nglpryb2sdfv7b0jma57504z4h351ywn-glib-2.56.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/1igiijfg9lymhcwribfn31iwbls6mf9y-systemd-239.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/vdni40p2ra3xj7i06wiv6nn7mva73slg-tor-0.3.3.9.drv': 4 dependencies couldn't be built
error: build of '/nix/store/vdni40p2ra3xj7i06wiv6nn7mva73slg-tor-0.3.3.9.drv' failed

@Ericson2314
Copy link
Member

Very excited about all the effort you've put in that direction!

@Ericson2314
Copy link
Member

Oh right, @oxij can't merge.

@Ericson2314 Ericson2314 merged commit 2dda26c into NixOS:staging Sep 5, 2018
@oxij
Copy link
Member Author

oxij commented Sep 5, 2018

Thanks!

@oxij oxij deleted the docheck/in-parallel branch November 18, 2018 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

Assignees
No one assigned
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxij @GrahamcOfBorg @Ericson2314