Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/opensmtpd: prevent non-deterministic failure #46071

Merged
merged 1 commit into from Sep 5, 2018
Merged

nixos/tests/opensmtpd: prevent non-deterministic failure #46071

merged 1 commit into from Sep 5, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 4, 2018

Motivation for this change

A sporadic test failure occured on Hydra because a request was sent to smtpd after the systemd unit was started, but before the daemon was actually listening. Fix by checking for open ports first.

cc ZHF #45960

Things done
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

@xeji
nixos/tests/opensmtpd: prevent non-deterministic failure
1493265 
A sporadic failure occured on Hydra because a request was sent
to smtpd after the systemd unit was started, but before the daemon
was actually listening. Fix by checking for open ports first.
@xeji
Copy link
Contributor Author

xeji commented Sep 5, 2018

@GrahamcOfBorg test opensmtpd

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.opensmtpd

Partial log (click to expand)

smtp2: running command: sync
smtp2: exit status 0
test script finished in 26.26s
cleaning up
killing smtp1 (pid 597)
killing client (pid 609)
killing smtp2 (pid 621)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/7w9cpx44v0lnw26f1vqbpyyzq6pdyax9-vm-test-run-opensmtpd

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.opensmtpd

Partial log (click to expand)

smtp1: running command: sync
smtp1: exit status 0
test script finished in 24.99s
cleaning up
killing client (pid 631)
killing smtp2 (pid 643)
killing smtp1 (pid 656)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/mvl7mksprwi16nmn319vhgqxdz2v84h6-vm-test-run-opensmtpd

@xeji xeji merged commit f70dc57 into NixOS:master Sep 5, 2018
xeji added a commit that referenced this pull request Sep 5, 2018
@xeji
nixos/tests/opensmtpd: prevent non-deterministic failure (#46071)
a6e2a55 
A sporadic failure occured on Hydra because a request was sent
to smtpd after the systemd unit was started, but before the daemon
was actually listening. Fix by checking for open ports first.

(cherry picked from commit f70dc57)
@xeji
Copy link
Contributor Author

xeji commented Sep 5, 2018

backported: a6e2a55

@xeji xeji deleted the p/opensmtpd-test branch September 5, 2018 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xeji @GrahamcOfBorg