Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restic: Fix autocomplete for zsh #46080

Merged
merged 1 commit into from Sep 5, 2018
Merged

restic: Fix autocomplete for zsh #46080

merged 1 commit into from Sep 5, 2018

Conversation

uskudnik
Copy link
Contributor

@uskudnik uskudnik commented Sep 5, 2018 •
edited

Motivation for this change

zsh requires for files to be prepended with underscore to be
recognized as widgets, see for more details.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

(Note: I was testing this with nixos-rebuild build-vm)

@uskudnik
restic: Fix autocomplete for zsh
e9fe3a3 
zsh requires for files to be prepended with underscore to be
recognized as widgets, see [1] for more details.

[1] NixOS#46001 (comment)
@Mic92 Mic92 merged commit 3074027 into NixOS:master Sep 5, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 5, 2018

backport

[detached HEAD 96ae9a3] restic: Fix autocomplete for zsh
Author: Urban Skudnik urban.skudnik@gmail.com
Date: Wed Sep 5 03:36:56 2018 +0200
1 file changed, 1 insertion(+), 1 deletion(-)

@uskudnik uskudnik deleted the restic-fix-zsh-autocompletion branch September 5, 2018 13:11
@uskudnik uskudnik mentioned this pull request Sep 9, 2018
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@uskudnik @Mic92 @GrahamcOfBorg