pythonPackages.pyopenssl: Disable some tests, for libressl support. #46072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase this on the |
Mic92
reviewed
Sep 5, 2018
| sed -i 's/test_set_session_id_fail/noop/' tests/test_ssl.py | ||
| sed -i 's/test_verify_with_revoked/noop/' tests/test_crypto.py | ||
| sed -i 's/test_set_notAfter/noop/' tests/test_crypto.py | ||
| sed -i 's/test_set_notBefore/noop/' tests/test_crypto.py |
There was a problem hiding this comment.
Is it possible to disable tests with pytest instead?
https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/tools/database/pgcli/default.nix#L17
There was a problem hiding this comment.
As an alternative with so many test failures, it might be also possible to set doCheck = openssl != libressl until it is fixed upstream?
There was a problem hiding this comment.
Ah, interesting. What would you recommend: should I make the derivation accept libressl as well, and do a literal != comparison between the openssl and libressl attributes?
|
Please don't unconditionally disable any tests that work with openssl.
|
|
Ah, interesting. What would you recommend: should I make the derivation accept `libressl` as well, and do a literal `!=` comparison between the `openssl` and `libressl` attributes?
I would do `lib.hasPrefix "libressl" openssl.meta.name` (`meta.name` is a clean version of `.name` that stays constant under cross compilation).
|
Mic92
changed the title
|
Thanks, @Mic92! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
pyopensslfails its test phase if built againstlibressl(2.7 and 2.8). Disabling these 12 tests (as already done for 2 existing tests) fixes that. The remaining 483 tests pass as expected.I filed an upstream ticket with the pyopenssl project, so we can reverse this if and when they fix it.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)