Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gildas: fix build failures #46095

Merged
merged 2 commits into from Sep 5, 2018
Merged

gildas: fix build failures #46095

merged 2 commits into from Sep 5, 2018

Conversation

smaret
Copy link
Member

@smaret smaret commented Sep 5, 2018 •
edited

Motivation for this change

Fix build failures on Hydra (#45960).

Please backport to 18.09 when merging.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 5, 2018

@GrahamcOfBorg build gildas

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gildas

Partial log (click to expand)

shrinking /nix/store/mbpxj7kpl52k3syg2xcc1j6bh1fjsa7l-gildas-20180801_a/libexec/lib/libginc.so
shrinking /nix/store/mbpxj7kpl52k3syg2xcc1j6bh1fjsa7l-gildas-20180801_a/libexec/lib/libclassfit.so
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/mbpxj7kpl52k3syg2xcc1j6bh1fjsa7l-gildas-20180801_a/libexec  /nix/store/mbpxj7kpl52k3syg2xcc1j6bh1fjsa7l-gildas-20180801_a/bin
patching script interpreter paths in /nix/store/mbpxj7kpl52k3syg2xcc1j6bh1fjsa7l-gildas-20180801_a
/nix/store/mbpxj7kpl52k3syg2xcc1j6bh1fjsa7l-gildas-20180801_a/libexec/bin/gag-get-interfaces.pl: interpreter directive changed from "/usr/bin/perl -w" to "/nix/store/q9ajsngf2w3r10dg7b1148wzq1avp4gj-perl-5.28.0/bin/perl -w"
/nix/store/mbpxj7kpl52k3syg2xcc1j6bh1fjsa7l-gildas-20180801_a/libexec/bin/gag-parse-messages.pl: interpreter directive changed from "/usr/bin/perl -w" to "/nix/store/q9ajsngf2w3r10dg7b1148wzq1avp4gj-perl-5.28.0/bin/perl -w"
/nix/store/mbpxj7kpl52k3syg2xcc1j6bh1fjsa7l-gildas-20180801_a/libexec/bin/gag-format-f90.pl: interpreter directive changed from "/usr/bin/perl -w" to "/nix/store/q9ajsngf2w3r10dg7b1148wzq1avp4gj-perl-5.28.0/bin/perl -w"
/nix/store/mbpxj7kpl52k3syg2xcc1j6bh1fjsa7l-gildas-20180801_a/bin/gildas-wrapper.sh: interpreter directive changed from "/bin/sh -e" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh -e"
checking for references to /build in /nix/store/mbpxj7kpl52k3syg2xcc1j6bh1fjsa7l-gildas-20180801_a...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gildas

Partial log (click to expand)

shrinking /nix/store/49bcdnkv34fsm7kriyns3lmr6ga98raz-gildas-20180801_a/libexec/lib/libimbfits.so
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/49bcdnkv34fsm7kriyns3lmr6ga98raz-gildas-20180801_a/libexec  /nix/store/49bcdnkv34fsm7kriyns3lmr6ga98raz-gildas-20180801_a/bin
patching script interpreter paths in /nix/store/49bcdnkv34fsm7kriyns3lmr6ga98raz-gildas-20180801_a
/nix/store/49bcdnkv34fsm7kriyns3lmr6ga98raz-gildas-20180801_a/libexec/bin/gag-parse-messages.pl: interpreter directive changed from "/usr/bin/perl -w" to "/nix/store/p3cg3qswdvq6vdjigs83did8km5dlqk7-perl-5.28.0/bin/perl -w"
/nix/store/49bcdnkv34fsm7kriyns3lmr6ga98raz-gildas-20180801_a/libexec/bin/gag-get-interfaces.pl: interpreter directive changed from "/usr/bin/perl -w" to "/nix/store/p3cg3qswdvq6vdjigs83did8km5dlqk7-perl-5.28.0/bin/perl -w"
/nix/store/49bcdnkv34fsm7kriyns3lmr6ga98raz-gildas-20180801_a/libexec/bin/gag-format-f90.pl: interpreter directive changed from "/usr/bin/perl -w" to "/nix/store/p3cg3qswdvq6vdjigs83did8km5dlqk7-perl-5.28.0/bin/perl -w"
/nix/store/49bcdnkv34fsm7kriyns3lmr6ga98raz-gildas-20180801_a/bin/gildas-wrapper.sh: interpreter directive changed from "/bin/sh -e" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh -e"
checking for references to /build in /nix/store/49bcdnkv34fsm7kriyns3lmr6ga98raz-gildas-20180801_a...
/nix/store/49bcdnkv34fsm7kriyns3lmr6ga98raz-gildas-20180801_a

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: gildas

Partial log (click to expand)

gfortran -c   -fimplicit-none -Wuninitialized -Wunused-variable -Wunused-label   -I./ -I./built/x86_64-darwin-gfortran-openmp -I/private/tmp/nix-build-gildas-20180801_a.drv-0/gildas-src-aug18a/integ/x86_64-darwin-gfortran-openmp/include -Wrealloc-lhs-all -J./built/x86_64-darwin-gfortran-openmp -pipe -fno-backslash -fno-range-check -fno-second-underscore -fPIC -fopenmp -O built/x86_64-darwin-gfortran-openmp/calib-tracked-wsw.f90 -o built/x86_64-darwin-gfortran-openmp/calib-tracked-wsw.o
f951: Warning: command line option '-Wformat=1' is valid for C/C++/ObjC/ObjC++ but not for Fortran
f951: Warning: command line option '-Wformat-security' is valid for C/C++/ObjC/ObjC++ but not for Fortran
f951: Warning: unrecognized command line option '-Wno-unused-command-line-argument'
cpp  -P -traditional -C  -DIEEE="ieee" -DBITS64="bits64" -DDARWIN="darwin" -DFORTRAN2003_PP -ffreestanding -DGFORTRAN="gfortran" -DGFORTRAN_VERSION="730" -DCFITSIO="yes" -DATM2009="atm2009" -DPNG="yes" -DGAG_USE_GTK -DGAG_USE_OPENMP -DGAG_USE_POSIX -DGAG_USE_PYTHON -DGAG_USE_UNDERSCORE    chunk-filler.f90 | grep -v \#pragma > built/x86_64-darwin-gfortran-openmp/chunk-filler.f90
gfortran -c   -fimplicit-none -Wuninitialized -Wunused-variable -Wunused-label   -I./ -I./built/x86_64-darwin-gfortran-openmp -I/private/tmp/nix-build-gildas-20180801_a.drv-0/gildas-src-aug18a/integ/x86_64-darwin-gfortran-openmp/include -Wrealloc-lhs-all -J./built/x86_64-darwin-gfortran-openmp -pipe -fno-backslash -fno-range-check -fno-second-underscore -fPIC -fopenmp -O built/x86_64-darwin-gfortran-openmp/chunk-filler.f90 -o built/x86_64-darwin-gfortran-openmp/chunk-filler.o
f951: Warning: command line option '-Wformat=1' is valid for C/C++/ObjC/ObjC++ but not for Fortran
f951: Warning: command line option '-Wformat-security' is valid for C/C++/ObjC/ObjC++ but not for Fortran
building of '/nix/store/yq3bsg6dsla6w313cj7wiig684xc52z0-gildas-20180801_a.drv' timed out after 3600 seconds
error: build of '/nix/store/yq3bsg6dsla6w313cj7wiig684xc52z0-gildas-20180801_a.drv' failed

@xeji
Copy link
Contributor

xeji commented Sep 5, 2018

timeout .. but should be ok since you built it locally on Darwin.

@xeji xeji merged commit 67d796d into NixOS:master Sep 5, 2018
@smaret smaret deleted the gildas-build-fixes branch September 6, 2018 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@smaret @xeji @GrahamcOfBorg