Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.sbv: fix location of z3 executable #46956

Merged
merged 1 commit into from Sep 20, 2018
Merged

haskellPackages.sbv: fix location of z3 executable #46956

merged 1 commit into from Sep 20, 2018

Conversation

Taneb
Copy link
Contributor

@Taneb Taneb commented Sep 20, 2018

Motivation for this change

A lot of the functionality of the z3 library depends on it being able to
find the z3 executable on $PATH. Hard-coding it here means it will never
be unable to find it and z3 doesn't need to pollute $PATH.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

haskellPackages.sbv: fix location of z3 executable
c8598da 
A lot of the functionality of the z3 library depends on it being able to
find the z3 executable on $PATH. Hard-coding it here means it will never
be unable to find it and z3 doesn't need to pollute $PATH.
@basvandijk
Copy link
Member

@GrahamcOfBorg build haskellPackages.sbv

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskellPackages.sbv

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: haskellPackages.sbv

Partial log (click to expand)

Installing library in /nix/store/7v0xg9snsn15pyr9sljp89a8gy5cw4rn-sbv-7.10/lib/ghc-8.4.3/x86_64-osx-ghc-8.4.3/sbv-7.10-6mxzPj6Ed7b9CGtfCh531I
post-installation fixup
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/7v0xg9snsn15pyr9sljp89a8gy5cw4rn-sbv-7.10/lib
patching script interpreter paths in /nix/store/7v0xg9snsn15pyr9sljp89a8gy5cw4rn-sbv-7.10
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/daxpnjsy0ybim5nc5rkqlznlcdlcw2a0-sbv-7.10-data
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/sn17c3h7fjy3k98yqzrrckg6cbg3s5hv-sbv-7.10-doc
/nix/store/7v0xg9snsn15pyr9sljp89a8gy5cw4rn-sbv-7.10

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: haskellPackages.sbv

Partial log (click to expand)

wrong ELF type
shrinking RPATHs of ELF executables and libraries in /nix/store/3yyjrgzpaaphxvdi4jckknplxc3s06bf-sbv-7.10-data
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/3yyjrgzpaaphxvdi4jckknplxc3s06bf-sbv-7.10-data
checking for references to /build in /nix/store/3yyjrgzpaaphxvdi4jckknplxc3s06bf-sbv-7.10-data...
shrinking RPATHs of ELF executables and libraries in /nix/store/2b9wlhg53v5ccjzghd8b42anjqylj5rv-sbv-7.10-doc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/2b9wlhg53v5ccjzghd8b42anjqylj5rv-sbv-7.10-doc
checking for references to /build in /nix/store/2b9wlhg53v5ccjzghd8b42anjqylj5rv-sbv-7.10-doc...
/nix/store/vyci69b0h8pfq89nmh4fzy6ysh23pknl-sbv-7.10

@basvandijk basvandijk merged commit b204298 into NixOS:master Sep 20, 2018
@basvandijk
Copy link
Member

Thanks this seems like the right thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

@ryantm ryantm Awaiting requested review from ryantm

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Taneb @basvandijk @GrahamcOfBorg