Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slimserver: Relax audio scan dependency #47029

Merged
merged 1 commit into from Oct 1, 2018
Merged

slimserver: Relax audio scan dependency #47029

merged 1 commit into from Oct 1, 2018

Conversation

phile314
Copy link
Contributor

Motivation for this change

Fix broken dependency constraint #46813 , fixes slimserver service.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@phile314
Copy link
Contributor Author

ping

@xeji
Copy link
Contributor

xeji commented Oct 1, 2018

@GrahamcOfBorg build slimserver

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: slimserver

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: slimserver

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: slimserver

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@xeji
Copy link
Contributor

xeji commented Oct 1, 2018

unfree package, build checked locally on x86_64-linux.

@xeji xeji merged commit 09df5da into NixOS:master Oct 1, 2018
nyanloutre pushed a commit to nyanloutre/nixpkgs that referenced this pull request Oct 22, 2018
@phile314 @nyanloutre
slimserver: Relax audio scan dependency (NixOS#47029)
4ec9509
nyanloutre pushed a commit to nyanloutre/nixpkgs that referenced this pull request Oct 22, 2018
@phile314 @nyanloutre
slimserver: Relax audio scan dependency (NixOS#47029)
e15b5ba 
(cherry picked from commit 09df5da)
Mic92 added a commit that referenced this pull request Oct 22, 2018
@Mic92
Merge pull request #48831 from nyanloutre/18-09-slimserver-fix
09bc130 
[18.09] slimserver: Relax audio scan dependency (#47029)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@phile314 @xeji @GrahamcOfBorg