Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/networking.virtual: prevent non-deterministic failure #46949

Merged
merged 1 commit into from Sep 20, 2018
Merged

nixos/tests/networking.virtual: prevent non-deterministic failure #46949

merged 1 commit into from Sep 20, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 20, 2018

Motivation for this change

The test failed non-deterministically on Hydra because interfaces sometimes weren't yet fully cleaned up when the result was checked, probably due to high load. Should be fixed by waiting a little.

Please backport to 18.09 #45960.

Things done
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

@xeji
nixos/tests/networking.virtual: prevent non-deterministic failure
73c4ec6 
The test failed non-deterministically on Hydra because interfaces
sometimes weren't yet fully cleaned up when the result was checked.
@xeji
Copy link
Contributor Author

xeji commented Sep 20, 2018

@GrahamcOfBorg test networking.scripted.virtual

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.networking.scripted.virtual

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 41.25s
cleaning up
killing machine (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/vdc0rajgs5lsv1vg5lpfwhri9qaimvr5-vm-test-run-Virtual-Networking-Scripted

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.networking.scripted.virtual

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 28.02s
cleaning up
killing machine (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/digs1pc8lnny9qd76hnsk73s52mr8fqj-vm-test-run-Virtual-Networking-Scripted

@xeji
Copy link
Contributor Author

xeji commented Sep 20, 2018

@GrahamcOfBorg test networking.networkd.virtual

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.networking.networkd.virtual

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 41.75s
cleaning up
killing machine (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/i2pf619k31y3w5kim39v5h1g01yi01xd-vm-test-run-Virtual-Networking-Networkd

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.networking.networkd.virtual

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 42.55s
cleaning up
killing machine (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/36p6b1dl9gg36cdbk36qan2s0nvnha57-vm-test-run-Virtual-Networking-Networkd

@xeji xeji merged commit 0565996 into NixOS:master Sep 20, 2018
@xeji xeji deleted the p/networking-virtual-test branch September 20, 2018 11:20
xeji added a commit that referenced this pull request Sep 20, 2018
@xeji
nixos/tests/networking.virtual: prevent non-deterministic failure (#4…
d5cbdec 
…6949)

The test failed non-deterministically on Hydra because interfaces
sometimes weren't yet fully cleaned up when the result was checked.

(cherry picked from commit 0565996)
@xeji
Copy link
Contributor Author

xeji commented Sep 20, 2018

backported: d5cbdec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xeji @GrahamcOfBorg