Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerTools.buildImage: test that created=now makes an unstable date #47017

Merged
merged 1 commit into from Sep 21, 2018
Merged

dockerTools.buildImage: test that created=now makes an unstable date #47017

merged 1 commit into from Sep 21, 2018

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Sep 20, 2018

Motivation for this change

@samueldr said I could backport it if I added a test :)

@GrahamcOfBorg test docker-tools

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member Author

grahamc commented Sep 20, 2018

@GrahamcOfBorg test docker-tools

@grahamc grahamc closed this Sep 20, 2018
@grahamc grahamc reopened this Sep 20, 2018
@grahamc
Copy link
Member Author

grahamc commented Sep 20, 2018

@GrahamcOfBorg test docker-tools

third times the charm?

@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@GrahamcOfBorg
Copy link

Success on aarch64-linux

Attempted: tests.docker-tools

No partial log is available.

@GrahamcOfBorg

This comment has been minimized.

Sign in to view
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.docker-tools

Partial log (click to expand)

docker: exit status 1
syncing
docker: running command: sync
docker: exit status 0
test script finished in 100.26s
cleaning up
killing docker (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/5l815yx9k3z4i2f14ynzyjhfz6rjhzpk-vm-test-run-docker-tools

@grahamc grahamc merged commit 10450ff into NixOS:master Sep 21, 2018
@grahamc grahamc deleted the docker-tools-test branch September 21, 2018 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr Awaiting requested review from samueldr

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grahamc @GrahamcOfBorg