Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/systemd-lib: fix assertValueOneOf #46964

Merged

Conversation

florianjacob
Copy link
Contributor

when value is not a string

Motivation for this change

I was just hit by this because with the current master systemd version, networkConfig.MulticastDNS has changed from a bool to a three-state string, which resulted in an unspecific

error: cannot coerce a boolean to a string, at nixos/modules/system/boot/systemd-lib.nix:66:8
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

when value is not a string
@florianjacob
Copy link
Contributor Author

Mentioning @aszlig, I think you are the original author of the assertion?

@matthewbauer matthewbauer merged commit bd3c840 into NixOS:master Oct 6, 2018
@florianjacob florianjacob deleted the systemd-assert-value-tostring branch October 6, 2018 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants