Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/yabar: fix module & test #46954

Merged
merged 1 commit into from Sep 20, 2018
Merged

nixos/yabar: fix module & test #46954

merged 1 commit into from Sep 20, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 20, 2018 •
edited

Motivation for this change

The pkgs.yabar package is relatively old (2016-04) and contains
several issues fixed on master. yabar-unstable containsa recent master
build with several fixes and a lot of new features (I use
yabar-unstable for some time now and had no issues with it).

In the upstream bugtracker some bugs could be fixed on ArchLinux by
simply installing yabar-git (an AUR package which builds a recent
master).

To stabilize the module, the option programs.yabar.package now
defaults to pkgs.yabar-unstable and yields a warning with several
linked issues that are known on pkgs.yabar.

The test has been refactored as well to ensure that yabar actually
starts (and avoid non-deterministic random success) and takes a
screenshot of a very minimalistic configuration on IceWM.

Fixes #46899

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ma27
nixos/yabar: fix module & test
5d91481 
The `pkgs.yabar` package is relatively old (2016-04) and contains
several issues fixed on master. `yabar-unstable` containsa recent master
build with several fixes and a lot of new features (I use
`yabar-unstable` for some time now and had no issues with it).

In the upstream bugtracker some bugs could be fixed on ArchLinux by
simply installing `yabar-git` (an AUR package which builds a recent
master).

To stabilize the module, the option `programs.yabar.package` now
defaults to `pkgs.yabar-unstable` and yields a warning with several
linked issues that are known on `pkgs.yabar`.

The test has been refactored as well to ensure that `yabar` actually
starts (and avoid non-deterministic random success) and takes a
screenshot of a very minimalistic configuration on IceWM.

Fixes NixOS#46899
@Ma27
Copy link
Member Author

Ma27 commented Sep 20, 2018

/cc @xeji

@xeji
Copy link
Contributor

xeji commented Sep 20, 2018

@GrahamcOfBorg test yabar

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.yabar

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 22.24s
cleaning up
killing machine (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/0pp0iraa7iz23kbmvxlj03wlrzi1bkzp-vm-test-run-yabar

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.yabar

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 77.62s
cleaning up
killing machine (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/2c4c4adxf987aislmddiwamlpgxc60ak-vm-test-run-yabar

@xeji
Copy link
Contributor

xeji commented Sep 20, 2018

Thanks! Screenshot looks good.
cc ZHF #45960

@xeji xeji merged commit 8b58a71 into NixOS:master Sep 20, 2018
xeji pushed a commit that referenced this pull request Sep 20, 2018
@Ma27 @xeji
nixos/yabar: fix module & test (#46954)
b89050d 
The `pkgs.yabar` package is relatively old (2016-04) and contains
several issues fixed on master. `yabar-unstable` containsa recent master
build with several fixes and a lot of new features (I use
`yabar-unstable` for some time now and had no issues with it).

In the upstream bugtracker some bugs could be fixed on ArchLinux by
simply installing `yabar-git` (an AUR package which builds a recent
master).

To stabilize the module, the option `programs.yabar.package` now
defaults to `pkgs.yabar-unstable` and yields a warning with several
linked issues that are known on `pkgs.yabar`.

The test has been refactored as well to ensure that `yabar` actually
starts (and avoid non-deterministic random success) and takes a
screenshot of a very minimalistic configuration on IceWM.

Fixes #46899

(cherry picked from commit 8b58a71)
@xeji
Copy link
Contributor

xeji commented Sep 20, 2018

backported: b89050d

@Ma27 Ma27 deleted the fix-yabar-module branch September 20, 2018 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yabar: test and module are broken
3 participants
@Ma27 @xeji @GrahamcOfBorg