Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocaml ≤ 4.05: mark as broken on Aarch64 #47010

Merged
merged 1 commit into from Sep 20, 2018
Merged

ocaml ≤ 4.05: mark as broken on Aarch64 #47010

merged 1 commit into from Sep 20, 2018

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Sep 20, 2018

Motivation for this change

#46726 marked all versions of OCaml as broken on Aarch64, which is a bit too much. I hope this one is better.

cc/ @Mic92.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

vbgl commented Sep 20, 2018

@GrahamcOfBorg build ocaml

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ocaml

Partial log (click to expand)

/nix/store/99sracn8p06w9lqpnx7aqysq268k5wmg-ocaml-4.06.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ocaml

Partial log (click to expand)

/nix/store/plhkx3w0n3ad6kn40936ic73k6wx28fm-ocaml-4.06.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ocaml

Partial log (click to expand)

these paths will be fetched (57.47 MiB download, 262.50 MiB unpacked):
  /nix/store/qzsja41zxyp12x4w03djq3k3rhq8qzww-ocaml-4.06.1
  /nix/store/rv8fv2kafxwmyas8f7y30pnklf2ljg5r-x11env
copying path '/nix/store/rv8fv2kafxwmyas8f7y30pnklf2ljg5r-x11env' from 'https://cache.nixos.org'...
copying path '/nix/store/qzsja41zxyp12x4w03djq3k3rhq8qzww-ocaml-4.06.1' from 'https://cache.nixos.org'...
/nix/store/qzsja41zxyp12x4w03djq3k3rhq8qzww-ocaml-4.06.1

@Mic92
Copy link
Member

Mic92 commented Sep 20, 2018

Please also backport to 18.09.

@xeji xeji merged commit ce03af9 into NixOS:master Sep 20, 2018
xeji pushed a commit that referenced this pull request Sep 20, 2018
@vbgl @xeji
ocaml ≤ 4.05: mark as broken on Aarch64 (#47010)
355a037 
(cherry picked from commit ce03af9)
@xeji
Copy link
Contributor

xeji commented Sep 20, 2018

backported to 18.09: 355a037

@vbgl vbgl deleted the ocaml-broken-on-aarch64 branch September 21, 2018 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vbgl @GrahamcOfBorg @Mic92 @xeji