Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circleci-cli: 0.1.0 -> 0.1.2307 #46983

Merged
merged 2 commits into from Sep 20, 2018
Merged

circleci-cli: 0.1.0 -> 0.1.2307 #46983

merged 2 commits into from Sep 20, 2018

Conversation

Synthetica9
Copy link
Member

@Synthetica9 Synthetica9 commented Sep 20, 2018 •
edited

We are also building from source now, instead of using a pre-packaged
version. This means we need Go. Also did minor refactors.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Synthetica9
circleci-cli: 0.1.0 -> 0.1.2307
e9aeb98 
We are also building from source now, instead of using a pre-packaged
version. This means we need Go. Also did minor refactors.
@Synthetica9
circleci-cli: removed unneeded dependencies
2253ada
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: circleci-cli

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/l851wsdc4bl9h87zj6n7npgfbrjw17i9-circleci-cli-0.1.2307-bin
shrinking /nix/store/l851wsdc4bl9h87zj6n7npgfbrjw17i9-circleci-cli-0.1.2307-bin/bin/circleci-cli
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/l851wsdc4bl9h87zj6n7npgfbrjw17i9-circleci-cli-0.1.2307-bin/bin
patching script interpreter paths in /nix/store/l851wsdc4bl9h87zj6n7npgfbrjw17i9-circleci-cli-0.1.2307-bin
checking for references to /build in /nix/store/l851wsdc4bl9h87zj6n7npgfbrjw17i9-circleci-cli-0.1.2307-bin...
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
/nix/store/l851wsdc4bl9h87zj6n7npgfbrjw17i9-circleci-cli-0.1.2307-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: circleci-cli

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qkd7g9qzrx924fqbgvy6miyjkgkqkadn-circleci-cli-0.1.2307-bin
shrinking /nix/store/qkd7g9qzrx924fqbgvy6miyjkgkqkadn-circleci-cli-0.1.2307-bin/bin/circleci-cli
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/qkd7g9qzrx924fqbgvy6miyjkgkqkadn-circleci-cli-0.1.2307-bin/bin
patching script interpreter paths in /nix/store/qkd7g9qzrx924fqbgvy6miyjkgkqkadn-circleci-cli-0.1.2307-bin
checking for references to /build in /nix/store/qkd7g9qzrx924fqbgvy6miyjkgkqkadn-circleci-cli-0.1.2307-bin...
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
/nix/store/qkd7g9qzrx924fqbgvy6miyjkgkqkadn-circleci-cli-0.1.2307-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: circleci-cli

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/pi190zl603j9d5c87c4k4b009n2w4irj-circleci-cli-0.1.2307-bin
shrinking /nix/store/pi190zl603j9d5c87c4k4b009n2w4irj-circleci-cli-0.1.2307-bin/bin/circleci-cli
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/pi190zl603j9d5c87c4k4b009n2w4irj-circleci-cli-0.1.2307-bin/bin
patching script interpreter paths in /nix/store/pi190zl603j9d5c87c4k4b009n2w4irj-circleci-cli-0.1.2307-bin
checking for references to /build in /nix/store/pi190zl603j9d5c87c4k4b009n2w4irj-circleci-cli-0.1.2307-bin...
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
/nix/store/pi190zl603j9d5c87c4k4b009n2w4irj-circleci-cli-0.1.2307-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: circleci-cli

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/azd1zkcczywj6x07pqi24yf7gd23nbgs-circleci-cli-0.1.2307-bin
shrinking /nix/store/azd1zkcczywj6x07pqi24yf7gd23nbgs-circleci-cli-0.1.2307-bin/bin/circleci-cli
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/azd1zkcczywj6x07pqi24yf7gd23nbgs-circleci-cli-0.1.2307-bin/bin
patching script interpreter paths in /nix/store/azd1zkcczywj6x07pqi24yf7gd23nbgs-circleci-cli-0.1.2307-bin
checking for references to /build in /nix/store/azd1zkcczywj6x07pqi24yf7gd23nbgs-circleci-cli-0.1.2307-bin...
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
/nix/store/azd1zkcczywj6x07pqi24yf7gd23nbgs-circleci-cli-0.1.2307-bin

@xeji xeji merged commit 1c40a3e into NixOS:master Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Synthetica9 @GrahamcOfBorg @xeji