installer: autorun xserver in graphical media #46997

worldofpeace · 2018-09-20T15:21:50Z

Motivation for this change

When I first used the NixOS iso I found it confusing and strange to have to do systemctl start display-manager. I assumed that I would have went straight to the graphical environment.

If anyone has a reason as to why it shouldn't do this please share.

Notes

In #42610 @adisbladis suggested:

I think we should add another boot entry so you can still choose not to start the graphical environment, at the same time we make the one that autostarts the graphical environment the default.

Wouldn't this need #45345 to include that configuration as a child config in the grub menu?

Though I feel that might be to complex.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

cc @samueldr @xeji @grahamc

samueldr · 2018-09-20T16:34:30Z

I would like to know why it wasn't the default. There is probably a reason behind, and knowing it helps ensuring we don't cause any unintended issues.

Though, I think this requires the one important sub-feature: the installer media should present an option that disables the display-manager.service so one can use the graphical iso without having X started; in case starting X is causing issues. IIRC this can be done through a systemd.mask=display-manager.service option on the kernel command line.

worldofpeace · 2018-09-20T17:16:39Z

I would like to know why it wasn't the default. There is probably a reason behind, and knowing it helps ensuring we don't cause any unintended issues.

It seems it was a while ago

nixpkgs/modules/profiles/graphical.nix

Line 12 in f3cc01b

autorun = true;

Though, I think this requires the one important sub-feature: the installer media should present an option that disables the display-manager.service so one can use the graphical iso without having X started; in case starting X is causing issues

Was this perceived as a necessary addendum to the feature suggested by @adisbladis?
If so, could you justify the importance?

samueldr · 2018-09-20T17:31:50Z

Yes, sorry, bad habit, jumped the gun and added my thoughts before reading that this was already in the body of your PR.

This is one way the boot option can be implemented.

worldofpeace · 2018-09-20T17:33:50Z

No problem, I'm guilty of the same thing too when I'm busy.

worldofpeace · 2018-09-20T17:45:11Z

If there's an agreement to needing this feature implicitly then I'd say that this is blocked until
the tests for #45345 are reviewed and it's merged.

samueldr · 2018-09-20T17:48:40Z

Unless I'm misunderstanding, probably no relation. The installer iso has a different menu generation entirely from the installed system.

Around here a new option can be added (class is used to get an icon in the menu).

mmahut · 2019-08-09T07:16:19Z

Any updates on this pull request, please?

worldofpeace · 2019-08-09T12:18:00Z

I plan to pick this up again after the 19.09 release.

worldofpeace · 2019-09-28T22:10:43Z

Ok, rebased and added a quirk to disable the display-manager.
I think we might've discussed on having a way to condition menu entries on whether it's for the graphical media or minimal. Though I still think this change won't do much harm without that feature.

worldofpeace · 2019-09-28T22:11:37Z

I've tested running the graphical media

Does it autorun X starting plasma5 ✔️
Did enabling the quirk send me to the tty ✔️

nixos/modules/installer/cd-dvd/iso-image.nix

samueldr · 2019-09-29T00:15:40Z

nixos/modules/installer/cd-dvd/iso-image.nix

+      # If we boot into a graphical environment where X is autorunned
+      # and always crashes, it makes the media unusable. Allow the user
+      # to disable this.
+      submenu "Disable display-manager" --class quirk-disable-displaymanager {


We can introduce an icon, if desired, and if one can be composed. They are composed from the breeze icon theme. If you see something in it that can be adapted, or used as an inspiration I can look into adding it to the relevant artwork.

I found breeze/devices/64/video-display.svg the most suitable.
I mostly wanted something like just a blank monitor, or communicates a tty.

I'm highly partial to elementary's icons which appears to be exactly what I'm looking for

Oh, forgot to specify the symbolic icons. Though the one from breeze, once made into outlines, may work, I'll try to remember to look into it later. (The PR can be merged without that change.)

Ahh, there's computer/video-display symbolic icons that should be fine then.
I'll add an issue at nixos-artwork for that once merged @samueldr.

samueldr

Minor stuff, generally approving the change.

nixos/doc/manual/release-notes/rl-2003.xml

worldofpeace · 2019-09-29T01:00:26Z

@samueldr My English and personality is literally a neologism 🤣

Thanks for the suggestions, will try to implement.

worldofpeace · 2019-10-03T02:13:32Z

Rebased and resolved the conflicts in the release note.
I plan to integrate this some time today if there's no issues raised.

GrahamcOfBorg added 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Sep 20, 2018

worldofpeace force-pushed the installer-autorun branch from 9e90d57 to 78411cb Compare September 28, 2019 22:08

worldofpeace added this to the 20.03 milestone Sep 28, 2019

ofborg bot added 8.has: changelog 8.has: documentation labels Sep 28, 2019

samueldr reviewed Sep 29, 2019

View reviewed changes

nixos/modules/installer/cd-dvd/iso-image.nix Outdated Show resolved Hide resolved

samueldr reviewed Sep 29, 2019

View reviewed changes

samueldr suggested changes Sep 29, 2019

View reviewed changes

nixos/doc/manual/release-notes/rl-2003.xml Outdated Show resolved Hide resolved

nixos/doc/manual/release-notes/rl-2003.xml Outdated Show resolved Hide resolved

nixos/doc/manual/release-notes/rl-2003.xml Outdated Show resolved Hide resolved

worldofpeace requested a review from samueldr September 30, 2019 15:23

worldofpeace and others added 3 commits October 2, 2019 22:10

installer: autorun xserver in graphical media

f6f5151

nixos/iso-image: add menu entry to disable display-manager

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

4895483

rl-2003: graphical image autoruns X

159b12b

worldofpeace force-pushed the installer-autorun branch from 3cfc53f to 159b12b Compare October 3, 2019 02:12

worldofpeace merged commit 789fceb into NixOS:master Oct 5, 2019

worldofpeace deleted the installer-autorun branch October 5, 2019 11:34

worldofpeace mentioned this pull request Jan 27, 2020

Disable display-manager icon for graphical iso NixOS/nixos-artwork#47

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

installer: autorun xserver in graphical media #46997

installer: autorun xserver in graphical media #46997

worldofpeace commented Sep 20, 2018

samueldr commented Sep 20, 2018 •

edited

Loading

worldofpeace commented Sep 20, 2018

samueldr commented Sep 20, 2018

worldofpeace commented Sep 20, 2018 •

edited

Loading

worldofpeace commented Sep 20, 2018

samueldr commented Sep 20, 2018 •

edited

Loading

mmahut commented Aug 9, 2019

worldofpeace commented Aug 9, 2019

worldofpeace commented Sep 28, 2019

worldofpeace commented Sep 28, 2019 •

edited

Loading

samueldr Sep 29, 2019

worldofpeace Sep 29, 2019

worldofpeace Sep 29, 2019

samueldr Sep 29, 2019

worldofpeace Sep 29, 2019

samueldr left a comment

worldofpeace commented Sep 29, 2019

worldofpeace commented Oct 3, 2019

installer: autorun xserver in graphical media #46997

installer: autorun xserver in graphical media #46997

Conversation

worldofpeace commented Sep 20, 2018

Motivation for this change

Notes

Things done

samueldr commented Sep 20, 2018 • edited Loading

worldofpeace commented Sep 20, 2018

samueldr commented Sep 20, 2018

worldofpeace commented Sep 20, 2018 • edited Loading

worldofpeace commented Sep 20, 2018

samueldr commented Sep 20, 2018 • edited Loading

mmahut commented Aug 9, 2019

worldofpeace commented Aug 9, 2019

worldofpeace commented Sep 28, 2019

worldofpeace commented Sep 28, 2019 • edited Loading

samueldr Sep 29, 2019

Choose a reason for hiding this comment

worldofpeace Sep 29, 2019

Choose a reason for hiding this comment

worldofpeace Sep 29, 2019

Choose a reason for hiding this comment

samueldr Sep 29, 2019

Choose a reason for hiding this comment

worldofpeace Sep 29, 2019

Choose a reason for hiding this comment

samueldr left a comment

Choose a reason for hiding this comment

worldofpeace commented Sep 29, 2019

worldofpeace commented Oct 3, 2019

samueldr commented Sep 20, 2018 •

edited

Loading

worldofpeace commented Sep 20, 2018 •

edited

Loading

samueldr commented Sep 20, 2018 •

edited

Loading

worldofpeace commented Sep 28, 2019 •

edited

Loading