Walabot SDK and module #46654
Walabot SDK and module #46654
Conversation
This module creates both the database needed for the SDK packaged as walabot-sdk in the /var/lib/walabot directory and the udev rules for the "Walabot Makers" device.
GrahamcOfBorg
added
6.topic: nixos
|
Any comment on this PR? |
| script = '' | ||
| if [ ! -d "/var/lib/walabot" ]; then | ||
| mkdir -p /var/lib | ||
| cp -r ${pkgs.walabot-sdk}/var/lib/walabot /var/lib/ |
There was a problem hiding this comment.
How is this supposed to work when upgrading? Supposedly pkgs.walabot-sdk would be bumped, but it wouldn't be copied again to /var/lib as the directory would already exist.
| name = "walabot-udev-rules"; | ||
| destination = "/etc/udev/rules.d/50-walabot.rules"; | ||
| text = '' | ||
| SUBSYSTEM=="usb", ATTR{idVendor}=="2c9c", ATTR{idProduct}="1000", MODE="0666" |
There was a problem hiding this comment.
0666 is really strong. Maybe make it 0660 and owned by a group to which users can be added? Defaulting the group to root would I think make sense, and let the user define it through another configuration option, so that we don't add little-used IDs to nixos/modules/misc/ids.nix.
TL;DR: make it 0660 root:${cfg.group} with the group option defaulting to root.
| version = "1.0.34"; | ||
|
|
||
| src = fetchurl { | ||
| url = "https://s3.eu-central-1.amazonaws.com/walabot/WalabotInstaller/Latest/walabot_maker_${version}_linux_x64.deb"; |
There was a problem hiding this comment.
Can you add as a comment an URL to the place via which you found this URL? I can't find it easily on the website, and it would help when checking for updates.
|
@Ekleog: Thanks for your feedback and checking this older PR. I have kind of forgotten this one and don't (have to) use the Walabot anymore. Furthermore this PR is, as you mentioned, kind of hacky. I think it's for the best to just close it. I'm very sorry that you worked all through this. |
|
No problem! It's not your fault if your PR fell under the radar, quite
the opposite, sorry for keeping you waiting for so long :)
|
Motivation for this change
This PR adds the proprietary SDK for the Walabot Makers. Because of the nature of the library, which is only available as a pre-compiled shared library, a database must be present under
/var/lib/walabot. ThewalabotNixOS-module creates this directory and populates it.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/) (none present)nix path-info -Sbefore and after)