Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/rmilter: fix default bindSocket.path and bindSocket.address. #46637

Merged
merged 2 commits into from Mar 2, 2019
Merged

nixos/rmilter: fix default bindSocket.path and bindSocket.address. #46637

merged 2 commits into from Mar 2, 2019

Conversation

ju1m
Copy link
Contributor

@ju1m ju1m commented Sep 14, 2018

Motivation for this change

bindSocket.path must not be within a RuntimeDir to avoid it being deleted, and IPv6 port is after the bracket.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Julien Moutinho added 2 commits September 14, 2018 05:47
rmilter: fix inetSocket
78bd4dd 
IPv6 address has to be between [] and the port after.
rmilter: fix bindSocket.path
f058338 
When /run/rmilter/ is wiped out the rmilter.sock is removed,
causing postfix to fail to contact rmilter.
Probably like described here: benoitc/gunicorn#1524 (comment)
@ju1m ju1m changed the title Fix rmilter's default bindSocket.path and bindSocket.address. nixos/rmilter: fix default bindSocket.path and bindSocket.address. Sep 19, 2018
@joachifm joachifm added this to the 18.09 milestone Sep 22, 2018
@joachifm joachifm mentioned this pull request Sep 22, 2018
Merged
9 tasks
@Mic92
Copy link
Member

Mic92 commented Sep 27, 2018

cc @avnik because this one seems to modify more socket related stuff.

@matthewbauer
Copy link
Member

ping- anyone interested in reviewing it?

@samueldr samueldr modified the milestones: 18.09, 19.03 Oct 6, 2018
@fpletz fpletz merged commit 2a61c05 into NixOS:master Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
19.03
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ju1m @Mic92 @matthewbauer @fpletz @joachifm @samueldr @GrahamcOfBorg