Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform-landscape: 0.1.18 -> 0.2.0 #46646

Merged
merged 1 commit into from Sep 15, 2018
Merged

terraform-landscape: 0.1.18 -> 0.2.0 #46646

merged 1 commit into from Sep 15, 2018

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Sep 14, 2018 •
edited

Motivation for this change

Avoids conflicts, because this had the bundler executable (amongst others) in $PATH, while only landscape should be available.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 merged commit 3a31207 into NixOS:master Sep 15, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 15, 2018

Do you think this should be backported?

@manveru manveru deleted the upgrade-terraform-landscape branch November 29, 2019 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manveru @Mic92 @GrahamcOfBorg