Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.termonad: Add dontCheck and remove from dont-distribute-packages. #45690

Merged
merged 1 commit into from Sep 3, 2018
Merged

haskellPackages.termonad: Add dontCheck and remove from dont-distribute-packages. #45690

merged 1 commit into from Sep 3, 2018

Conversation

cdepillabout
Copy link
Member

Motivation for this change

The doctests for termonad fail to build only with nix. When building without nix, the doctests run correctly:

cdepillabout/termonad#15

This PR disables the tests for termonad, as well as removing it from dont-distribute-packages.

This PR is based on the haskell-updates branch, as suggested by @basvandijk in #44529 (comment).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@peti peti force-pushed the haskell-updates branch 2 times, most recently from ffd3a16 to fbada9f Compare August 29, 2018 17:45
mpickering
mpickering reviewed Aug 29, 2018
View reviewed changes
pkgs/development/haskell-modules/hackage-packages.nix Outdated
@@ -27168,15 +27168,15 @@ self: {
}) {};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove the changes to this file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mpickering thanks for the review.

When I originally sent this PR, I think I might have based it on the wrong commit, which is why it appeared that I had made changes to pkgs/development/haskell-modules/hackage-packages.nix.

I have fixed it in commit e0e2b3f.

@ryantm
Copy link
Member

ryantm commented Sep 2, 2018

@GrahamcOfBorg build haskellPackages.termonad

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskellPackages.termonad

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

ryantm
ryantm requested changes Sep 2, 2018
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fix the commit message to have the full attrpath before the colon?

@ryantm ryantm changed the title termonad: Add dontCheck and remove from dont-distribute-packages. haskellPackages.termonad: Add dontCheck and remove from dont-distribute-packages. Sep 2, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: haskellPackages.termonad

Partial log (click to expand)

wrong ELF type
shrinking RPATHs of ELF executables and libraries in /nix/store/b27g6fxv9g90iwc3akhf46ss7s1spwwz-termonad-0.2.1.0-data
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/b27g6fxv9g90iwc3akhf46ss7s1spwwz-termonad-0.2.1.0-data
checking for references to /build in /nix/store/b27g6fxv9g90iwc3akhf46ss7s1spwwz-termonad-0.2.1.0-data...
shrinking RPATHs of ELF executables and libraries in /nix/store/9x8x7y4i7jb7g8vqmxppsflwkf62vf3g-termonad-0.2.1.0-doc
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/9x8x7y4i7jb7g8vqmxppsflwkf62vf3g-termonad-0.2.1.0-doc
checking for references to /build in /nix/store/9x8x7y4i7jb7g8vqmxppsflwkf62vf3g-termonad-0.2.1.0-doc...
/nix/store/8cjsn8nqg21zf7ziizd0mr3swrpr7n0y-termonad-0.2.1.0

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: haskellPackages.termonad

Partial log (click to expand)

Using Parsec parser
Could not resolve symbol "gdk_pixbuf_format_get_type" in namespace "GdkPixbuf"
CallStack (from HasCallStack):
  error, called at lib/Data/GI/CodeGen/LibGIRepository.hs:167:8 in haskell-gi-0.21.4-3Fe7fSsnmru19tID8RcP1E:Data.GI.CodeGen.LibGIRepository
builder for '/nix/store/lvmbz96p15ky4q2i8i5r4mw8k7iqh3ya-gi-gdkpixbuf-2.0.16.drv' failed with exit code 1
cannot build derivation '/nix/store/2yf7548vasyimdh0mqy94c2knrl9x5hi-gi-gdk-3.0.16.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/shkmcy2cwhsq22krmndd7aw1rs54s8m9-gi-gtk-3.0.24.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/vkvp5470yff8jrk8f3lapdr448xlwjzw-gi-vte-2.91.19.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/4z2jnn5gywldsambyi26flzpfswhmjmw-termonad-0.2.1.0.drv': 3 dependencies couldn't be built
error: build of '/nix/store/4z2jnn5gywldsambyi26flzpfswhmjmw-termonad-0.2.1.0.drv' failed

@cdepillabout
haskellPackages.termonad: Add dontCheck and remove from dont-distribu…
75608a3 
…te-packages.

The doctests for termonad fail to build only with nix.  When building
without nix, the doctests run correctly:

cdepillabout/termonad#15

This PR disables the tests for termonad, as well as removing it from
dont-distribute-packages.
@cdepillabout
Copy link
Member Author

cdepillabout commented Sep 3, 2018 •
edited

@ryanm thanks for the review.

I've changed the commit message to have the full attr path before the colon (haskellPackages.termonad).

@ryantm ryantm merged this pull request into NixOS:haskell-updates Sep 3, 2018
@ryantm
Copy link
Member

ryantm commented Sep 3, 2018

thanks, and merged.

@cdepillabout cdepillabout deleted the dont-run-tests-for-termonad branch September 3, 2018 05:40
@cdepillabout cdepillabout mentioned this pull request Sep 8, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpickering mpickering mpickering left review comments

@ryantm ryantm ryantm requested changes

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cdepillabout @ryantm @GrahamcOfBorg @mpickering