Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boost: explicitly disable of python #45679

Closed
wants to merge 1 commit into from
Closed

boost: explicitly disable of python #45679

wants to merge 1 commit into from

Conversation

stephengroat
Copy link
Contributor

Motivation for this change

failing ci https://hydra.nixos.org/build/80148727

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Aug 27, 2018

cc @LnL7 @edolstra who made some recent changes regarding python support in boost.

@Mic92
Copy link
Member

Mic92 commented Aug 27, 2018

@GrahamcOfBorg build boost

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: boost

Partial log (click to expand)

patching sources
applying patch /nix/store/grg7n62aznizximhnbyv07y6270xpvc5-12726cda009a855073b9bedbdce57b6ce7763da2.patch
patching file boost/lockfree/spsc_queue.hpp
configuring
fixing libtool script ./tools/build/src/engine/boehm_gc/ltmain.sh
configure flags: --prefix=/nix/store/hs3n5cm48kps18a7knl04qg4ja2bi91i-boost-1.67_0 --includedir=\$\(dev\)/include --libdir=\$\(out\)/lib --without-python --with-icu=/nix/store/bsmb0rgkcyasb0zm13l9kz741dqwqda8-icu4c-59.1-dev
error: unrecognized option: --without-python
Try `./bootstrap.sh --help' for more information.
builder for '/nix/store/hvc5959gpj9nrkk1728sjcrwj1fzdrlh-boost-1.67_0.drv' failed with exit code 1
error: build of '/nix/store/hvc5959gpj9nrkk1728sjcrwj1fzdrlh-boost-1.67_0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: boost

Partial log (click to expand)

patching file boost/lockfree/spsc_queue.hpp
applying patch /nix/store/1cbws1f1ppqxi4h10p80biwpdklfnz2x-darwin-no-system-python.patch
patching file tools/build/src/tools/python.jam
configuring
fixing libtool script ./tools/build/src/engine/boehm_gc/ltmain.sh
configure flags: --prefix=/nix/store/4gb6199ys3rgp3an1pyviay05q6jjjc3-boost-1.67_0 --includedir=\$\(dev\)/include --libdir=\$\(out\)/lib --without-python --with-icu=/nix/store/gx085743laxybi80pjbggaq3lp8385vy-icu4c-59.1-dev --with-toolset=clang
error: unrecognized option: --without-python
Try `./bootstrap.sh --help' for more information.
builder for '/nix/store/i7n3727qndkrnkl9x19k58kglpsc87mf-boost-1.67_0.drv' failed with exit code 1
error: build of '/nix/store/i7n3727qndkrnkl9x19k58kglpsc87mf-boost-1.67_0.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: boost

Partial log (click to expand)

updateAutotoolsGnuConfigScriptsPhase
Updating Autotools / GNU config script to a newer upstream version: ./tools/build/src/engine/boehm_gc/config.sub
Updating Autotools / GNU config script to a newer upstream version: ./tools/build/src/engine/boehm_gc/config.guess
configuring
fixing libtool script ./tools/build/src/engine/boehm_gc/ltmain.sh
configure flags: --prefix=/nix/store/vsijn8pqp20jyz6xv31z75ybn70h9cwp-boost-1.67_0 --includedir=\$\(dev\)/include --libdir=\$\(out\)/lib --without-python --with-icu=/nix/store/bj6ls909mrdvak0m35ababhs040a37i3-icu4c-59.1-dev
error: unrecognized option: --without-python
Try `./bootstrap.sh --help' for more information.
builder for '/nix/store/q14kpx3krwi15khq8w2invc3nzqsc45l-boost-1.67_0.drv' failed with exit code 1
error: build of '/nix/store/q14kpx3krwi15khq8w2invc3nzqsc45l-boost-1.67_0.drv' failed

@Mic92
Copy link
Member

Mic92 commented Aug 27, 2018

current error:

error: unrecognized option: --without-python

@LnL7
Copy link
Member

LnL7 commented Aug 27, 2018

This might have changed, but to quote myself bce4388.

There doesn't seem to be a --without-python flag

@xeji
Copy link
Contributor

xeji commented Aug 27, 2018

Since @stephengroat referenced a failing build of boost162, let's try that:
@GrahamcOfBorg build boost162

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: boost162

Partial log (click to expand)

patching file tools/build/src/tools/python.jam
Hunk #1 succeeded at 423 (offset -5 lines).
Hunk #2 succeeded at 844 (offset -40 lines).
configuring
fixing libtool script ./tools/build/src/engine/boehm_gc/ltmain.sh
configure flags: --prefix=/nix/store/my6md8hj142xkjf8pkdb69k9xy6bm32m-boost-1.62.0 --includedir=\$\(dev\)/include --libdir=\$\(out\)/lib --without-python --with-icu=/nix/store/gx085743laxybi80pjbggaq3lp8385vy-icu4c-59.1-dev --with-toolset=clang
error: unrecognized option: --without-python
Try `./bootstrap.sh --help' for more information.
builder for '/nix/store/z2kp6zh745v7yvxwhxnhbdh39ps1qk5s-boost-1.62.0.drv' failed with exit code 1
error: build of '/nix/store/z2kp6zh745v7yvxwhxnhbdh39ps1qk5s-boost-1.62.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: boost162

Partial log (click to expand)

updateAutotoolsGnuConfigScriptsPhase
Updating Autotools / GNU config script to a newer upstream version: ./tools/build/src/engine/boehm_gc/config.sub
Updating Autotools / GNU config script to a newer upstream version: ./tools/build/src/engine/boehm_gc/config.guess
configuring
fixing libtool script ./tools/build/src/engine/boehm_gc/ltmain.sh
configure flags: --prefix=/nix/store/n69y2mnzwpjiyqvr0fd3gibxfnqi7als-boost-1.62.0 --includedir=\$\(dev\)/include --libdir=\$\(out\)/lib --without-python --with-icu=/nix/store/bj6ls909mrdvak0m35ababhs040a37i3-icu4c-59.1-dev
error: unrecognized option: --without-python
Try `./bootstrap.sh --help' for more information.
builder for '/nix/store/qi3l4pjn9asicv48w9q2rgwyja1wrv9b-boost-1.62.0.drv' failed with exit code 1
error: build of '/nix/store/qi3l4pjn9asicv48w9q2rgwyja1wrv9b-boost-1.62.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: boost162

Partial log (click to expand)

source root is boost_1_62_0
setting SOURCE_DATE_EPOCH to timestamp 1474470023 of file boost_1_62_0/libs/libraries.htm
patching sources
configuring
fixing libtool script ./tools/build/src/engine/boehm_gc/ltmain.sh
configure flags: --prefix=/nix/store/7fp4x12fqhalny5wqwgzb4kilx5iw4hl-boost-1.62.0 --includedir=\$\(dev\)/include --libdir=\$\(out\)/lib --without-python --with-icu=/nix/store/bsmb0rgkcyasb0zm13l9kz741dqwqda8-icu4c-59.1-dev
error: unrecognized option: --without-python
Try `./bootstrap.sh --help' for more information.
builder for '/nix/store/99p32q7h6mgrrf84m1d72khr00xy0vrc-boost-1.62.0.drv' failed with exit code 1
error: build of '/nix/store/99p32q7h6mgrrf84m1d72khr00xy0vrc-boost-1.62.0.drv' failed

@xeji
Copy link
Contributor

xeji commented Aug 27, 2018

The flag doesn't exist on boost162 either. @stephengroat how did you test this change?

@stephengroat
Copy link
Contributor Author

stephengroat commented Aug 27, 2018 •
edited

@xeji tested on a docker image, but pushed wrong changes:
@GrahamcOfBorg build boost162

@xeji
Copy link
Contributor

xeji commented Aug 27, 2018

Well, the --without-python flag that you're using doesn't exist, so this is still unlikely to work.
(btw, not everyone can trigger builds)
@GrahamcOfBorg build boost162

@stephengroat
Copy link
Contributor Author

stephengroat commented Aug 27, 2018 •
edited

@xeji idk, it's referenced here (https://www.boost.org/doc/libs/1_61_0/libs/python/doc/html/building/configuring_boost_build.html) and in other places

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: boost162

Partial log (click to expand)

shrinking /nix/store/ii23z557630ysz9dci6fr3c9nqdq7g8a-boost-1.62.0/lib/libboost_atomic.so.1.62.0
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ii23z557630ysz9dci6fr3c9nqdq7g8a-boost-1.62.0/lib
patching script interpreter paths in /nix/store/ii23z557630ysz9dci6fr3c9nqdq7g8a-boost-1.62.0
checking for references to /build in /nix/store/ii23z557630ysz9dci6fr3c9nqdq7g8a-boost-1.62.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/q5dmqvvsd6gncvgydyn2ddzwzz5x784x-boost-1.62.0-dev
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/q5dmqvvsd6gncvgydyn2ddzwzz5x784x-boost-1.62.0-dev
checking for references to /build in /nix/store/q5dmqvvsd6gncvgydyn2ddzwzz5x784x-boost-1.62.0-dev...
/nix/store/ii23z557630ysz9dci6fr3c9nqdq7g8a-boost-1.62.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: boost162

Partial log (click to expand)

/nix/store/2kdbpwcl9h90n179qj2s5lrrrz7i0zcx-boost-1.62.0/lib/libboost_math_tr1.dylib: fixing dylib
/nix/store/2kdbpwcl9h90n179qj2s5lrrrz7i0zcx-boost-1.62.0/lib/libboost_atomic.dylib: fixing dylib
/nix/store/2kdbpwcl9h90n179qj2s5lrrrz7i0zcx-boost-1.62.0/lib/libboost_date_time.dylib: fixing dylib
/nix/store/2kdbpwcl9h90n179qj2s5lrrrz7i0zcx-boost-1.62.0/lib/libboost_system.dylib: fixing dylib
/nix/store/2kdbpwcl9h90n179qj2s5lrrrz7i0zcx-boost-1.62.0/lib/libboost_math_c99.dylib: fixing dylib
/nix/store/2kdbpwcl9h90n179qj2s5lrrrz7i0zcx-boost-1.62.0/lib/libboost_chrono.dylib: fixing dylib
/nix/store/2kdbpwcl9h90n179qj2s5lrrrz7i0zcx-boost-1.62.0/lib/libboost_context.dylib: fixing dylib
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/5s8ypfi8whcpzxslvih5pignqi1dhmi1-boost-1.62.0-dev
/nix/store/2kdbpwcl9h90n179qj2s5lrrrz7i0zcx-boost-1.62.0

@stephengroat
Copy link
Contributor Author

@xeji i figured it out, it's a b2Args, not a configureFlags. completely my fault, a bad copy, sorry about the confusion

@xeji
Copy link
Contributor

xeji commented Aug 27, 2018

Ah, I see, now this starts making sense 😄 Let's try another version:
@GrahamcOfBorg build boost

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: boost

Partial log (click to expand)

shrinking /nix/store/ka262ycdal7y7i6lg11zn3gcn1dbj5x2-boost-1.67_0/lib/libboost_regex.so.1.67.0
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ka262ycdal7y7i6lg11zn3gcn1dbj5x2-boost-1.67_0/lib
patching script interpreter paths in /nix/store/ka262ycdal7y7i6lg11zn3gcn1dbj5x2-boost-1.67_0
checking for references to /build in /nix/store/ka262ycdal7y7i6lg11zn3gcn1dbj5x2-boost-1.67_0...
shrinking RPATHs of ELF executables and libraries in /nix/store/njkzki9f8zf624lclbj78xd3xgbdc48n-boost-1.67_0-dev
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/njkzki9f8zf624lclbj78xd3xgbdc48n-boost-1.67_0-dev
checking for references to /build in /nix/store/njkzki9f8zf624lclbj78xd3xgbdc48n-boost-1.67_0-dev...
/nix/store/ka262ycdal7y7i6lg11zn3gcn1dbj5x2-boost-1.67_0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: boost

Partial log (click to expand)

shrinking /nix/store/i4dk9i2a1j181l25cmvszmrzpkij9jif-boost-1.67_0/lib/libboost_atomic.so.1.67.0
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/i4dk9i2a1j181l25cmvszmrzpkij9jif-boost-1.67_0/lib
patching script interpreter paths in /nix/store/i4dk9i2a1j181l25cmvszmrzpkij9jif-boost-1.67_0
checking for references to /build in /nix/store/i4dk9i2a1j181l25cmvszmrzpkij9jif-boost-1.67_0...
shrinking RPATHs of ELF executables and libraries in /nix/store/b07q8wly211774c2v5kwmjysrbxqrhbc-boost-1.67_0-dev
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/b07q8wly211774c2v5kwmjysrbxqrhbc-boost-1.67_0-dev
checking for references to /build in /nix/store/b07q8wly211774c2v5kwmjysrbxqrhbc-boost-1.67_0-dev...
/nix/store/i4dk9i2a1j181l25cmvszmrzpkij9jif-boost-1.67_0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: boost

Partial log (click to expand)

/nix/store/jgcsj7msdwix7gn1q1px5j8hmp80whf5-boost-1.67_0/lib/libboost_math_tr1.dylib: fixing dylib
/nix/store/jgcsj7msdwix7gn1q1px5j8hmp80whf5-boost-1.67_0/lib/libboost_atomic.dylib: fixing dylib
/nix/store/jgcsj7msdwix7gn1q1px5j8hmp80whf5-boost-1.67_0/lib/libboost_date_time.dylib: fixing dylib
/nix/store/jgcsj7msdwix7gn1q1px5j8hmp80whf5-boost-1.67_0/lib/libboost_system.dylib: fixing dylib
/nix/store/jgcsj7msdwix7gn1q1px5j8hmp80whf5-boost-1.67_0/lib/libboost_math_c99.dylib: fixing dylib
/nix/store/jgcsj7msdwix7gn1q1px5j8hmp80whf5-boost-1.67_0/lib/libboost_chrono.dylib: fixing dylib
/nix/store/jgcsj7msdwix7gn1q1px5j8hmp80whf5-boost-1.67_0/lib/libboost_context.dylib: fixing dylib
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/ndxcl6p3c774v63zsz2i2d1c23qi0dj8-boost-1.67_0-dev
/nix/store/jgcsj7msdwix7gn1q1px5j8hmp80whf5-boost-1.67_0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: boost162

Partial log (click to expand)

shrinking /nix/store/2h2z5dr01vzywaq5fgm417dqk9q2xn86-boost-1.62.0/lib/libboost_random.so.1.62.0
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/2h2z5dr01vzywaq5fgm417dqk9q2xn86-boost-1.62.0/lib
patching script interpreter paths in /nix/store/2h2z5dr01vzywaq5fgm417dqk9q2xn86-boost-1.62.0
checking for references to /build in /nix/store/2h2z5dr01vzywaq5fgm417dqk9q2xn86-boost-1.62.0...
shrinking RPATHs of ELF executables and libraries in /nix/store/j5ixhirxrvyqc4h18c4hx8mp05f1byib-boost-1.62.0-dev
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/j5ixhirxrvyqc4h18c4hx8mp05f1byib-boost-1.62.0-dev
checking for references to /build in /nix/store/j5ixhirxrvyqc4h18c4hx8mp05f1byib-boost-1.62.0-dev...
/nix/store/2h2z5dr01vzywaq5fgm417dqk9q2xn86-boost-1.62.0

xeji pushed a commit that referenced this pull request Aug 27, 2018
@stephengroat @xeji
boost: disable python explicitly in b2Args (#45679)
775d1ec 
(cherry picked from commit 3b862a6)
@xeji
Copy link
Contributor

xeji commented Aug 27, 2018

Thank you, LGTM.
Pushed to staging in 775d1ec
(this causes a mass rebuild, so it goes to the staging branch first).

@xeji xeji closed this Aug 27, 2018
@stephengroat stephengroat deleted the patch-1 branch August 27, 2018 22:20
xeji pushed a commit that referenced this pull request Sep 4, 2018
@stephengroat @xeji
boost: disable python explicitly in b2Args (#45679)
c70ff28 
fixes the build of boost_162

(cherry picked from commit 775d1ec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stephengroat @xeji @Mic92 @GrahamcOfBorg @LnL7