Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 2b4b7d4ef3bb
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: b25b6e0c7586
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Sep 25, 2018

  1. stdenv: Improve ELF detection for isELF 

    The isELF function only checks whether ELF is contained within the first
4 bytes of the file, which is a bit fuzzy and will also return
successful if it's a text file starting with ELF, for example:

  ELF headers
  -----------

  Some text here about ELF headers...

So instead, we're now doing a precise match on \x7fELF.

Signed-off-by: aszlig <aszlig@nix.build>
Acked-by: @Ericson2314
Closes: #47244
    @aszlig
    aszlig committed Sep 25, 2018
    Copy the full SHA
    b25b6e0 View commit details
    Browse the repository at this point in the history