Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add adwaita-qt & qgnomeplatform #47305

Merged
merged 2 commits into from Sep 25, 2018
Merged

Add adwaita-qt & qgnomeplatform #47305

merged 2 commits into from Sep 25, 2018

Conversation

worldofpeace
Copy link
Contributor

@worldofpeace worldofpeace commented Sep 25, 2018 •
edited

Motivation for this change

elementary uses this to improve the look and feel of qt applications.
(It's default in Fedora for Gnome too...)

Screenshots

Before:

screenshot_2

After:

screenshot

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @jtojnar

@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg build adwaita-qt qgnomeplatform

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: adwaita-qt, qgnomeplatform

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/0mg19qh5906ri8lj0vjy24jdjmp65z42-qgnomeplatform-0.4
shrinking /nix/store/0mg19qh5906ri8lj0vjy24jdjmp65z42-qgnomeplatform-0.4/lib/qt-5.11/plugins/platformthemes/libqgnomeplatform.so
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0mg19qh5906ri8lj0vjy24jdjmp65z42-qgnomeplatform-0.4/lib
patching script interpreter paths in /nix/store/0mg19qh5906ri8lj0vjy24jdjmp65z42-qgnomeplatform-0.4
checking for references to /build in /nix/store/0mg19qh5906ri8lj0vjy24jdjmp65z42-qgnomeplatform-0.4...
postPatchMkspecs
postPatchMkspecs
/nix/store/hbxsnhlbxda015137kkhf9rzyzz4p606-adwaita-qt-1.0
/nix/store/0mg19qh5906ri8lj0vjy24jdjmp65z42-qgnomeplatform-0.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: adwaita-qt, qgnomeplatform

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/4560mlls19wi1dnh0w09cf4bdfrs88ws-qgnomeplatform-0.4
shrinking /nix/store/4560mlls19wi1dnh0w09cf4bdfrs88ws-qgnomeplatform-0.4/lib/qt-5.11/plugins/platformthemes/libqgnomeplatform.so
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/4560mlls19wi1dnh0w09cf4bdfrs88ws-qgnomeplatform-0.4/lib
patching script interpreter paths in /nix/store/4560mlls19wi1dnh0w09cf4bdfrs88ws-qgnomeplatform-0.4
checking for references to /build in /nix/store/4560mlls19wi1dnh0w09cf4bdfrs88ws-qgnomeplatform-0.4...
postPatchMkspecs
postPatchMkspecs
/nix/store/rlg2k5w0r1nx4dqm5z834msdxg1m4g0q-adwaita-qt-1.0
/nix/store/4560mlls19wi1dnh0w09cf4bdfrs88ws-qgnomeplatform-0.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: adwaita-qt, qgnomeplatform

Partial log (click to expand)

/nix/store/rlg2k5w0r1nx4dqm5z834msdxg1m4g0q-adwaita-qt-1.0
/nix/store/4560mlls19wi1dnh0w09cf4bdfrs88ws-qgnomeplatform-0.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: adwaita-qt, qgnomeplatform

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hbxsnhlbxda015137kkhf9rzyzz4p606-adwaita-qt-1.0
shrinking /nix/store/hbxsnhlbxda015137kkhf9rzyzz4p606-adwaita-qt-1.0/lib/qt-5.11/plugins/styles/adwaita.so
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/hbxsnhlbxda015137kkhf9rzyzz4p606-adwaita-qt-1.0/lib
patching script interpreter paths in /nix/store/hbxsnhlbxda015137kkhf9rzyzz4p606-adwaita-qt-1.0
checking for references to /build in /nix/store/hbxsnhlbxda015137kkhf9rzyzz4p606-adwaita-qt-1.0...
postPatchMkspecs
/nix/store/hbxsnhlbxda015137kkhf9rzyzz4p606-adwaita-qt-1.0
/nix/store/0mg19qh5906ri8lj0vjy24jdjmp65z42-qgnomeplatform-0.4

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: adwaita-qt, qgnomeplatform

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/m9lfa8y7vmlbpsyp5idrcn1a5s018ihj-qgnomeplatform-0.4
shrinking /nix/store/m9lfa8y7vmlbpsyp5idrcn1a5s018ihj-qgnomeplatform-0.4/lib/qt-5.11/plugins/platformthemes/libqgnomeplatform.so
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/m9lfa8y7vmlbpsyp5idrcn1a5s018ihj-qgnomeplatform-0.4/lib
patching script interpreter paths in /nix/store/m9lfa8y7vmlbpsyp5idrcn1a5s018ihj-qgnomeplatform-0.4
checking for references to /build in /nix/store/m9lfa8y7vmlbpsyp5idrcn1a5s018ihj-qgnomeplatform-0.4...
postPatchMkspecs
postPatchMkspecs
/nix/store/hbxsnhlbxda015137kkhf9rzyzz4p606-adwaita-qt-1.0
/nix/store/m9lfa8y7vmlbpsyp5idrcn1a5s018ihj-qgnomeplatform-0.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: adwaita-qt, qgnomeplatform

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/nalhlvjv4xv7pdmxhpyp1hbmzsby2914-qgnomeplatform-0.4
shrinking /nix/store/nalhlvjv4xv7pdmxhpyp1hbmzsby2914-qgnomeplatform-0.4/lib/qt-5.11/plugins/platformthemes/libqgnomeplatform.so
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nalhlvjv4xv7pdmxhpyp1hbmzsby2914-qgnomeplatform-0.4/lib
patching script interpreter paths in /nix/store/nalhlvjv4xv7pdmxhpyp1hbmzsby2914-qgnomeplatform-0.4
checking for references to /build in /nix/store/nalhlvjv4xv7pdmxhpyp1hbmzsby2914-qgnomeplatform-0.4...
postPatchMkspecs
postPatchMkspecs
/nix/store/rlg2k5w0r1nx4dqm5z834msdxg1m4g0q-adwaita-qt-1.0
/nix/store/nalhlvjv4xv7pdmxhpyp1hbmzsby2914-qgnomeplatform-0.4

@jtojnar
Copy link
Contributor

jtojnar commented Sep 25, 2018

Thanks.

@jtojnar jtojnar merged commit aba011f into NixOS:master Sep 25, 2018
@worldofpeace worldofpeace deleted the qgnome branch September 25, 2018 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @GrahamcOfBorg @jtojnar