Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc, ghcjs: Get rid of extraneous alex, happy, and hscolour args for 18.09 #47304

Merged
merged 3 commits into from Sep 25, 2018
Merged

ghc, ghcjs: Get rid of extraneous alex, happy, and hscolour args for 18.09 #47304

merged 3 commits into from Sep 25, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

Backport #47303

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ericson2314
ghc, ghcjs: Get rid of extraneous alex, happy, and hscolour args
e6a476c 
The compilers themselves can pull them from `bootPkgs`, where they
should always come from anyways. This enforces that, simplifies that
code, and allows use to avoid more `rec { ... }` too.
@Ericson2314
Merge remote-tracking branch 'upstream/release-18.09' into haskell-no…
5b6fc8f 
…-rec-18.09
@Ericson2314
Merge remote-tracking branch 'upstream/release-18.09' into haskell-no…
d6e2a2c 
…-rec-18.09
@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: ghc

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: ghc

Partial log (click to expand)

/nix/store/4rk1ny3wg3rf7bfa8wwc2vmpgdciqpff-ghc-8.4.3

@Ericson2314 Ericson2314 merged commit 0cf38d9 into NixOS:release-18.09 Sep 25, 2018
@Ericson2314 Ericson2314 deleted the haskell-no-rec-18.09 branch September 25, 2018 00:28
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ghc

Partial log (click to expand)

/nix/store/n5i1zdpmk2b1s3z96649xh8f9kr3g96s-ghc-8.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti peti is a code owner

@ryantm ryantm Awaiting requested review from ryantm ryantm is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ericson2314 @GrahamcOfBorg