New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ConstantSourceNode audio node type #21803
Comments
Part of this work happened at servo/media#164 |
#23152 was an attempt to fix this that ran into some compile errors, and then the submitter disappeared. |
Hi! If you have any questions regarding this issue, feel free to make a comment here, or ask it in the If you intend to work on this issue, then add |
@highfive: assign me |
Hey @holmes2! Thanks for your interest in working on this issue. It's now assigned to you! |
Please ask questions if any part of this task is unclear :) |
@KritR If you want to work on this issue, you could. |
Thanks for the issue @jdm. I'll be a little bit occupied until this weekend, and if it's still open then I'll pick it up. |
Unassigning due to lack of activity. |
@highfive assign me |
Hey @tdelacour! Thanks for your interest in working on this issue. It's now assigned to you! |
ISSUE-21803: Implement ConstantSourceNode audionode <!-- Please describe your changes on the following line: --> More or less followed the steps outlined in `components/script/dom/mod.rs` (and also used the [previous PR](#23152) on this issue as reference). Updated `wpt` tests as well. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21803 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23919) <!-- Reviewable:end -->
ISSUE-21803: Implement ConstantSourceNode audionode <!-- Please describe your changes on the following line: --> More or less followed the steps outlined in `components/script/dom/mod.rs` (and also used the [previous PR](#23152) on this issue as reference). Updated `wpt` tests as well. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21803 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23919) <!-- Reviewable:end -->
ISSUE-21803: Implement ConstantSourceNode audionode <!-- Please describe your changes on the following line: --> More or less followed the steps outlined in `components/script/dom/mod.rs` (and also used the [previous PR](#23152) on this issue as reference). Updated `wpt` tests as well. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21803 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23919) <!-- Reviewable:end -->
ISSUE-21803: Implement ConstantSourceNode audionode <!-- Please describe your changes on the following line: --> More or less followed the steps outlined in `components/script/dom/mod.rs` (and also used the [previous PR](#23152) on this issue as reference). Updated `wpt` tests as well. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [X] These changes fix #21803 (GitHub issue number if applicable) <!-- Either: --> - [X] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23919) <!-- Reviewable:end -->
Spec: https://webaudio.github.io/web-audio-api/#ConstantSourceNode
Doc: https://developer.mozilla.org/en-US/docs/Web/API/ConstantSourceNode
The text was updated successfully, but these errors were encountered: