Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 18.09: ocamlPackages.cohttp: 1.0.2 -> 1.1.1 #47311

Closed
wants to merge 1 commit into from
Closed

Backport 18.09: ocamlPackages.cohttp: 1.0.2 -> 1.1.1 #47311

wants to merge 1 commit into from

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Sep 25, 2018

(cherry picked from commit a3c820d)
Backport of #46906

According to discussion in said PR, this is worthy of cherrying in.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@vbgl @srhb
ocamlPackages.cohttp: 1.0.2 -> 1.1.1
c7e76b5 
(cherry picked from commit a3c820d)
Backport of NixOS#46906
@srhb srhb requested a review from vbgl September 25, 2018 08:22
@vbgl
Copy link
Contributor

vbgl commented Sep 27, 2018

@GrahamcOfBorg build ocamlPackages.git-unix

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: ocamlPackages.git-unix

Partial log (click to expand)

OK
installing
Processing file tls.install as tls.
post-installation fixup
moving /nix/store/42p4b3g29gkl082c3h6nb9lqlk0crvga-ocaml4.06.1-tls-0.9.0/doc to /nix/store/42p4b3g29gkl082c3h6nb9lqlk0crvga-ocaml4.06.1-tls-0.9.0/share/doc
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/42p4b3g29gkl082c3h6nb9lqlk0crvga-ocaml4.06.1-tls-0.9.0/lib
patching script interpreter paths in /nix/store/42p4b3g29gkl082c3h6nb9lqlk0crvga-ocaml4.06.1-tls-0.9.0
cannot build derivation '/nix/store/ajv6d143w16g1p3bk51nsw4ff9l0474c-ocaml4.06.1-git-unix-1.11.5.drv': 2 dependencies couldn't be built
error: build of '/nix/store/ajv6d143w16g1p3bk51nsw4ff9l0474c-ocaml4.06.1-git-unix-1.11.5.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: ocamlPackages.git-unix

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/cz4l2h345bj8gfq9sa5f5syl0ry4lfcx-ocaml4.06.1-git-1.11.5
shrinking /nix/store/cz4l2h345bj8gfq9sa5f5syl0ry4lfcx-ocaml4.06.1-git-1.11.5/lib/ocaml/4.06.1/site-lib/git/git.cmxs
shrinking /nix/store/cz4l2h345bj8gfq9sa5f5syl0ry4lfcx-ocaml4.06.1-git-1.11.5/lib/ocaml/4.06.1/site-lib/git/top/git_top.cmxs
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/cz4l2h345bj8gfq9sa5f5syl0ry4lfcx-ocaml4.06.1-git-1.11.5/lib
patching script interpreter paths in /nix/store/cz4l2h345bj8gfq9sa5f5syl0ry4lfcx-ocaml4.06.1-git-1.11.5
checking for references to /build in /nix/store/cz4l2h345bj8gfq9sa5f5syl0ry4lfcx-ocaml4.06.1-git-1.11.5...
cannot build derivation '/nix/store/rqy0j2x96j4y4zryy83rv09yswf4xhbn-ocaml4.06.1-git-http-1.11.5.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/gvk2zkx6mhkcjh99q5c2cas4a6k7vgzs-ocaml4.06.1-git-unix-1.11.5.drv': 2 dependencies couldn't be built
error: build of '/nix/store/gvk2zkx6mhkcjh99q5c2cas4a6k7vgzs-ocaml4.06.1-git-unix-1.11.5.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: ocamlPackages.git-unix

Partial log (click to expand)

moving /nix/store/yi80spxm6khfm76w8l7xi7ab3l1hifyw-ocaml4.06.1-tls-0.9.0/doc to /nix/store/yi80spxm6khfm76w8l7xi7ab3l1hifyw-ocaml4.06.1-tls-0.9.0/share/doc
shrinking RPATHs of ELF executables and libraries in /nix/store/yi80spxm6khfm76w8l7xi7ab3l1hifyw-ocaml4.06.1-tls-0.9.0
shrinking /nix/store/yi80spxm6khfm76w8l7xi7ab3l1hifyw-ocaml4.06.1-tls-0.9.0/lib/ocaml/4.06.1/site-lib/tls/tls-lwt.cmxs
shrinking /nix/store/yi80spxm6khfm76w8l7xi7ab3l1hifyw-ocaml4.06.1-tls-0.9.0/lib/ocaml/4.06.1/site-lib/tls/tls.cmxs
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yi80spxm6khfm76w8l7xi7ab3l1hifyw-ocaml4.06.1-tls-0.9.0/lib
patching script interpreter paths in /nix/store/yi80spxm6khfm76w8l7xi7ab3l1hifyw-ocaml4.06.1-tls-0.9.0
checking for references to /build in /nix/store/yi80spxm6khfm76w8l7xi7ab3l1hifyw-ocaml4.06.1-tls-0.9.0...
cannot build derivation '/nix/store/jhnvxbh1yl0gzffmgya6kb2kvbf8k4b6-ocaml4.06.1-git-unix-1.11.5.drv': 2 dependencies couldn't be built
error: build of '/nix/store/jhnvxbh1yl0gzffmgya6kb2kvbf8k4b6-ocaml4.06.1-git-unix-1.11.5.drv' failed

@vbgl
Copy link
Contributor

vbgl commented Sep 27, 2018

@GrahamcOfBorg build ocamlPackages.cohttp

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: ocamlPackages.cohttp

Partial log (click to expand)

configuring
no configure script, doing nothing
building
File "dune-project", line 1, characters 11-14:
Error: Version 1.1 of dune is not supported.
Supported versions:
- 0.0
- 1.0
builder for '/nix/store/0jzy3la3lk3v4mmljkniw07n5pizsp3x-ocaml4.06.1-cohttp-1.1.1.drv' failed with exit code 1
error: build of '/nix/store/0jzy3la3lk3v4mmljkniw07n5pizsp3x-ocaml4.06.1-cohttp-1.1.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: ocamlPackages.cohttp

Partial log (click to expand)

configuring
no configure script, doing nothing
building
File "dune-project", line 1, characters 11-14:
Error: Version 1.1 of dune is not supported.
Supported versions:
- 0.0
- 1.0
builder for '/nix/store/9s0y8cp4lacvfzwnzlvg6jm6ix0ibddn-ocaml4.06.1-cohttp-1.1.1.drv' failed with exit code 1
error: build of '/nix/store/9s0y8cp4lacvfzwnzlvg6jm6ix0ibddn-ocaml4.06.1-cohttp-1.1.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: ocamlPackages.cohttp

Partial log (click to expand)

configuring
no configure script, doing nothing
building
File "dune-project", line 1, characters 11-14:
Error: Version 1.1 of dune is not supported.
Supported versions:
- 0.0
- 1.0
builder for '/nix/store/k3rz17k4v0xf4d5chi0qnqxqb40zlcjq-ocaml4.06.1-cohttp-1.1.1.drv' failed with exit code 1
error: build of '/nix/store/k3rz17k4v0xf4d5chi0qnqxqb40zlcjq-ocaml4.06.1-cohttp-1.1.1.drv' failed

@vbgl
Copy link
Contributor

vbgl commented Sep 27, 2018

Something seems wrong.

@srhb any hint? Did you test locally?

@srhb
Copy link
Contributor Author

srhb commented Sep 28, 2018

No, I completely naively opened a PR with a cherry-pick of your previous commit. It would appear that this won't work without at least the jbuilder 1.0.1 -> dune 1.1.1 change, and that seems like a less obvious candidate for backporting.

@srhb srhb closed this Sep 28, 2018
@srhb srhb deleted the cohttp-bump-1809 branch September 28, 2018 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl Awaiting requested review from vbgl

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srhb @vbgl @GrahamcOfBorg