Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ultimate-oldschool-pc-font-pack: simplify using fetchzip #47313

Merged
merged 1 commit into from Sep 29, 2018
Merged

ultimate-oldschool-pc-font-pack: simplify using fetchzip #47313

merged 1 commit into from Sep 29, 2018

Conversation

endgame
Copy link
Contributor

@endgame endgame commented Sep 25, 2018

Motivation for this change

@volth pointed out that #45969 could be done much more simply using fetchzip, so I fixed it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@endgame endgame mentioned this pull request Sep 25, 2018
Merged
9 tasks
@endgame
Copy link
Contributor Author

endgame commented Sep 25, 2018

@GrahamcOfBorg build ultimate-oldschool-pc-font-pack

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ultimate-oldschool-pc-font-pack

Partial log (click to expand)

  inflating: /nix/store/7pd167jsdj8798msyga22wcifzb059mr-ultimate-oldschool-pc-font-pack-1.0/share/fonts/truetype/PxPlus_IBM_VGA8-2x.ttf
  inflating: /nix/store/7pd167jsdj8798msyga22wcifzb059mr-ultimate-oldschool-pc-font-pack-1.0/share/fonts/truetype/PxPlus_IBM_VGA8.ttf
  inflating: /nix/store/7pd167jsdj8798msyga22wcifzb059mr-ultimate-oldschool-pc-font-pack-1.0/share/fonts/truetype/PxPlus_IBM_VGA9-2x.ttf
  inflating: /nix/store/7pd167jsdj8798msyga22wcifzb059mr-ultimate-oldschool-pc-font-pack-1.0/share/fonts/truetype/PxPlus_IBM_VGA9.ttf
  inflating: /nix/store/7pd167jsdj8798msyga22wcifzb059mr-ultimate-oldschool-pc-font-pack-1.0/share/fonts/truetype/PxPlus_TandyNew_225-2y.ttf
  inflating: /nix/store/7pd167jsdj8798msyga22wcifzb059mr-ultimate-oldschool-pc-font-pack-1.0/share/fonts/truetype/PxPlus_TandyNew_225.ttf
  inflating: /nix/store/7pd167jsdj8798msyga22wcifzb059mr-ultimate-oldschool-pc-font-pack-1.0/share/fonts/truetype/PxPlus_TandyNew_TV-2y.ttf
  inflating: /nix/store/7pd167jsdj8798msyga22wcifzb059mr-ultimate-oldschool-pc-font-pack-1.0/share/fonts/truetype/PxPlus_TandyNew_TV.ttf
  inflating: /nix/store/7pd167jsdj8798msyga22wcifzb059mr-ultimate-oldschool-pc-font-pack-1.0/share/fonts/truetype/PxPlus_VGA_SquarePx.ttf
/nix/store/7pd167jsdj8798msyga22wcifzb059mr-ultimate-oldschool-pc-font-pack-1.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ultimate-oldschool-pc-font-pack

Partial log (click to expand)

  inflating: /nix/store/7pd167jsdj8798msyga22wcifzb059mr-ultimate-oldschool-pc-font-pack-1.0/share/fonts/truetype/PxPlus_IBM_VGA8-2x.ttf
/nix/store/7pd167jsdj8798msyga22wcifzb059mr-ultimate-oldschool-pc-font-pack-1.0
  inflating: /nix/store/7pd167jsdj8798msyga22wcifzb059mr-ultimate-oldschool-pc-font-pack-1.0/share/fonts/truetype/PxPlus_IBM_VGA8.ttf
  inflating: /nix/store/7pd167jsdj8798msyga22wcifzb059mr-ultimate-oldschool-pc-font-pack-1.0/share/fonts/truetype/PxPlus_IBM_VGA9-2x.ttf
  inflating: /nix/store/7pd167jsdj8798msyga22wcifzb059mr-ultimate-oldschool-pc-font-pack-1.0/share/fonts/truetype/PxPlus_IBM_VGA9.ttf
  inflating: /nix/store/7pd167jsdj8798msyga22wcifzb059mr-ultimate-oldschool-pc-font-pack-1.0/share/fonts/truetype/PxPlus_TandyNew_225-2y.ttf
  inflating: /nix/store/7pd167jsdj8798msyga22wcifzb059mr-ultimate-oldschool-pc-font-pack-1.0/share/fonts/truetype/PxPlus_TandyNew_225.ttf
  inflating: /nix/store/7pd167jsdj8798msyga22wcifzb059mr-ultimate-oldschool-pc-font-pack-1.0/share/fonts/truetype/PxPlus_TandyNew_TV-2y.ttf
  inflating: /nix/store/7pd167jsdj8798msyga22wcifzb059mr-ultimate-oldschool-pc-font-pack-1.0/share/fonts/truetype/PxPlus_TandyNew_TV.ttf
  inflating: /nix/store/7pd167jsdj8798msyga22wcifzb059mr-ultimate-oldschool-pc-font-pack-1.0/share/fonts/truetype/PxPlus_VGA_SquarePx.ttf

@xeji xeji merged commit a3ba62d into NixOS:master Sep 29, 2018
@endgame endgame deleted the oldschool-pc-fonts-fetchzip branch October 1, 2018 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@endgame @GrahamcOfBorg @xeji