Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rsyslogd & syslog-nd: fix broken module #47306

Merged
merged 6 commits into from Oct 27, 2018
Merged

rsyslogd & syslog-nd: fix broken module #47306

merged 6 commits into from Oct 27, 2018

Conversation

aanderse
Copy link
Member

Motivation for this change

I've tested rsyslogd on NixOS 18.09 and no output is generated from rsyslogd at all. The module appears to be broken because of systemd changes.

According to https://wiki.archlinux.org/index.php/rsyslog "ForwardToSyslog=yes" needs to be added to journald.conf.

NOTE: This PR is to replace #47134

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@aanderse aanderse mentioned this pull request Sep 25, 2018
Closed
9 tasks
Mic92
Mic92 reviewed Sep 25, 2018
View reviewed changes
nixos/tests/rsyslogd.nix Outdated Show resolved Hide resolved
@aanderse aanderse mentioned this pull request Sep 29, 2018
Closed
@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 27, 2018

@GrahamcOfBorg test systemd rsyslogd

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-linux (full log)

Attempted: tests.systemd, tests.rsyslogd

Partial log (click to expand)

cannot build derivation '/nix/store/l3x2fhbcwkd2dvhd7k6nmvx54jzq9z1m-lightdm-gtk-greeter.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/hajd0gm8b012a1cqj3jkk041fvymzpy4-lightdm.conf.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/sn64350bhf3j3ny04w19r3f93iiigpv9-etc.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/x5bvab3mn1z6f15zmakb2204s6qnfkpn-nixos-system-machine-19.03.git.7d508ca.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/k442a5dcg9rmq01ag1k7k7fk7zl0f6kv-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/563bg2lc769lqrhv5i40lzzwgm08k5lx-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/qnvc6mxddl6z5mwmxb8cix70ifqx4wah-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/sinnn7k5xkmm83rhn9cs7di54my6c0jn-nixos-test-driver-systemd.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/027sg6k9gj35l7vhdlyl1wkiksfvjyql-vm-test-run-systemd.drv': 1 dependencies couldn't be built
error: build of '/nix/store/027sg6k9gj35l7vhdlyl1wkiksfvjyql-vm-test-run-systemd.drv' failed

@aanderse
Copy link
Member Author

@c0bw3b Taking a look at the full log I see rustc timing out. Is that related to my change, or is that a rustc issue?

Compiling syntax_ext v0.0.0 (file:///build/rustc-1.30.0-src/src/libsyntax_ext)
Compiling rustc_metadata_utils v0.0.0 (file:///build/rustc-1.30.0-src/src/librustc_metadata_utils)
Compiling rustc_typeck v0.0.0 (file:///build/rustc-1.30.0-src/src/librustc_typeck)
building of '/nix/store/j1yzzw5jg9dpxlrcp5mj8awfgh755byb-rustc-1.30.0.drv' timed out after 3600 seconds

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 27, 2018

No 3600sec is just the max allowed by ofBorg for one job.
My bad, asking the bot to run systemd test wasn't the best idea

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 27, 2018

@GrahamcOfBorg test rsyslogd

@GrahamcOfBorg
Copy link

Success on x86_64-linux

Attempted: tests.rsyslogd

No partial log is available.

@GrahamcOfBorg
Copy link

Success on aarch64-linux

Attempted: tests.rsyslogd

No partial log is available.

@GrahamcOfBorg
Copy link

Timed out, unknown build status on aarch64-linux (full log)

Attempted: tests.systemd, tests.rsyslogd

Partial log (click to expand)

cannot build derivation '/nix/store/dzz7mzcpjvgd41am9zzal2daxrk6dgyw-lightdm-gtk-greeter.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/xhcyy9zrm8m374fyi5cryw4qg3zdhn02-lightdm.conf.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/dvii4hdpxqg7bi14xhnapibhh8xg1yz7-etc.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ypqyxw19h4vlm40vq01y2ljq8m1izw52-nixos-system-machine-19.03.git.1504f8c.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/w30f00h8fkqj6fkm89rxi8aabqahapbk-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/b75ab819j95hdhfrv3jif9dadf53gprl-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/gcybx0v0wkalkpmcvzi4rjrd4ryf9jsh-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/brhylcya7d0s8wb2ylg0jcgqjnz0j0bn-nixos-test-driver-systemd.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/b03i4krzga03gr2hva56b7r569vzih23-vm-test-run-systemd.drv': 1 dependencies couldn't be built
error: build of '/nix/store/b03i4krzga03gr2hva56b7r569vzih23-vm-test-run-systemd.drv' failed

c0bw3b
c0bw3b approved these changes Oct 27, 2018
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c0bw3b c0bw3b merged commit 1381019 into NixOS:master Oct 27, 2018
@aanderse
Copy link
Member Author

Great thanks

@aanderse aanderse deleted the syslog-fix branch October 27, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@fpletz fpletz fpletz left review comments

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aanderse @c0bw3b @GrahamcOfBorg @Mic92 @fpletz