nix-daemon: allow setting builders to "" by any user (untrusted) #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit a94a2eb)
grahamc
reviewed
Sep 25, 2018
| @@ -557,7 +557,8 @@ static void performOp(TunnelLogger * logger, ref<Store> store, | |||
| ; | |||
| else if (trusted | |||
| || name == settings.buildTimeout.name | |||
| || name == "connect-timeout") | |||
| || name == "connect-timeout" | |||
| || (name == "builders" && value == "")) | |||
There was a problem hiding this comment.
@dtzWill would you mind sending a PR adding docs for this?
There was a problem hiding this comment.
Don't mind at all, but not sure how to edit the docs. Will take a look at that later today, probably should bite the bullet! If you find yourself wondering when I'm going to do it please bug me about it ;).
But sure thing, and thanks for all your documentation work! (including ensuring documentation exists for new things, like here!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'd be even better to accept a subset of builders, but this is still
a big win IMHO for making it easy to disable distributed builds from normal accounts.