Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protobuf3_6: init at 3.6.1 #47307

Merged
merged 2 commits into from Sep 25, 2018
Merged

protobuf3_6: init at 3.6.1 #47307

merged 2 commits into from Sep 25, 2018

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Sep 25, 2018

Motivation for this change

protobuf was moved from google to protocolbuffers on GitHub: https://github.com/protocolbuffers/protobuf/releases/tag/v3.6.0

This update is common to #45709 and #47184, except that I did not add NIX_CFLAGS_COMPILE = "-Wno-error"; because it is not necessary.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: protobuf, protobuf3_6

Partial log (click to expand)

shrinking /nix/store/p7qk7ndij6j18582sx0ad6vrs3z27hx5-protobuf-3.6.1/bin/protoc
shrinking /nix/store/p7qk7ndij6j18582sx0ad6vrs3z27hx5-protobuf-3.6.1/lib/libprotobuf-lite.so.17.0.0
shrinking /nix/store/p7qk7ndij6j18582sx0ad6vrs3z27hx5-protobuf-3.6.1/lib/libprotobuf.so.17.0.0
shrinking /nix/store/p7qk7ndij6j18582sx0ad6vrs3z27hx5-protobuf-3.6.1/lib/libprotoc.so.17.0.0
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/p7qk7ndij6j18582sx0ad6vrs3z27hx5-protobuf-3.6.1/lib  /nix/store/p7qk7ndij6j18582sx0ad6vrs3z27hx5-protobuf-3.6.1/bin
patching script interpreter paths in /nix/store/p7qk7ndij6j18582sx0ad6vrs3z27hx5-protobuf-3.6.1
checking for references to /build in /nix/store/p7qk7ndij6j18582sx0ad6vrs3z27hx5-protobuf-3.6.1...
/nix/store/4fmgfcmsx5yd0h8y0kzj348pzlphdj7g-protobuf-3.4.1
/nix/store/p7qk7ndij6j18582sx0ad6vrs3z27hx5-protobuf-3.6.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: protobuf, protobuf3_6

Partial log (click to expand)

shrinking /nix/store/xwb7v6vkg2i1rd7dqiqc0asbsc13c4bk-protobuf-3.6.1/bin/protoc
shrinking /nix/store/xwb7v6vkg2i1rd7dqiqc0asbsc13c4bk-protobuf-3.6.1/lib/libprotoc.so.17.0.0
shrinking /nix/store/xwb7v6vkg2i1rd7dqiqc0asbsc13c4bk-protobuf-3.6.1/lib/libprotobuf.so.17.0.0
shrinking /nix/store/xwb7v6vkg2i1rd7dqiqc0asbsc13c4bk-protobuf-3.6.1/lib/libprotobuf-lite.so.17.0.0
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xwb7v6vkg2i1rd7dqiqc0asbsc13c4bk-protobuf-3.6.1/lib  /nix/store/xwb7v6vkg2i1rd7dqiqc0asbsc13c4bk-protobuf-3.6.1/bin
patching script interpreter paths in /nix/store/xwb7v6vkg2i1rd7dqiqc0asbsc13c4bk-protobuf-3.6.1
checking for references to /build in /nix/store/xwb7v6vkg2i1rd7dqiqc0asbsc13c4bk-protobuf-3.6.1...
/nix/store/mk8g15n730bhx0br14bf6xcw8m25k18b-protobuf-3.4.1
/nix/store/xwb7v6vkg2i1rd7dqiqc0asbsc13c4bk-protobuf-3.6.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: protobuf, protobuf3_6

Partial log (click to expand)

 /nix/store/4x7dp4fkx81bf1iw4kphpbfpick844rs-coreutils-8.29/bin/mkdir -p '/nix/store/0a17pqjvqd4ys4rc9ifrndzqp8wnff7w-protobuf-3.6.1/include/google/protobuf/compiler/objectivec'
 /nix/store/4x7dp4fkx81bf1iw4kphpbfpick844rs-coreutils-8.29/bin/install -c -m 644  google/protobuf/compiler/objectivec/objectivec_generator.h google/protobuf/compiler/objectivec/objectivec_helpers.h '/nix/store/0a17pqjvqd4ys4rc9ifrndzqp8wnff7w-protobuf-3.6.1/include/google/protobuf/compiler/objectivec'
make[2]: Leaving directory '/private/tmp/nix-build-protobuf-3.6.1.drv-0/source/src'
make[1]: Leaving directory '/private/tmp/nix-build-protobuf-3.6.1.drv-0/source/src'
post-installation fixup
strip is /nix/store/4w56qihlrddav67p7d1vy5qkyayaqw11-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/0a17pqjvqd4ys4rc9ifrndzqp8wnff7w-protobuf-3.6.1/lib  /nix/store/0a17pqjvqd4ys4rc9ifrndzqp8wnff7w-protobuf-3.6.1/bin
patching script interpreter paths in /nix/store/0a17pqjvqd4ys4rc9ifrndzqp8wnff7w-protobuf-3.6.1
/nix/store/hjchiwhfyayq9566cpb59vcfyfvrvdr8-protobuf-3.4.1
/nix/store/0a17pqjvqd4ys4rc9ifrndzqp8wnff7w-protobuf-3.6.1

@orivej-nixos orivej-nixos merged commit 9942cee into NixOS:master Sep 25, 2018
@orivej orivej deleted the protobuf branch September 25, 2018 02:22
@orivej orivej mentioned this pull request Sep 25, 2018
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orivej @GrahamcOfBorg @orivej-nixos