python3Packages.mypy: 0.620 -> 0.630 #46788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now requires mypy_extensions so added it as well.
|
Note that mypy now requires mypy_extensions so I added it. I kept the same maintainers as for mypy (which might be a bold move don't hate me plz :) ) |
Mic92
reviewed
Sep 18, 2018
| sha256 = "04h8brrbbx151dfa2cvvlnxgmb5wa00mhd2z7nd20s8kyibfkq1p"; | ||
| }; | ||
|
|
||
| disabled = !isPy3k; |
There was a problem hiding this comment.
Just noticed: I think this is enabled for python2, no? https://github.com/python/mypy/blob/master/extensions/setup.py#L21
|
seems like it thanks for the fix.
Le mar. 18 sept. 2018 à 16:06, Jörg Thalheim <notifications@github.com> a
écrit :
… ***@***.**** commented on this pull request.
------------------------------
In pkgs/development/python-modules/mypy/extensions.nix
<#46788 (comment)>:
> @@ -0,0 +1,25 @@
+{ stdenv, fetchPypi, buildPythonPackage, typing, isPy3k }:
+
+buildPythonPackage rec {
+ pname = "mypy_extensions";
+ version = "0.4.1";
+
+ # Tests not included in pip package.
+ doCheck = false;
+
+ src = fetchPypi {
+ inherit pname version;
+ sha256 = "04h8brrbbx151dfa2cvvlnxgmb5wa00mhd2z7nd20s8kyibfkq1p";
+ };
+
+ disabled = !isPy3k;
080b3ef
<080b3ef>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#46788 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AA2FOrq6cHY0mofmLLD_Y0BwXli4SEi5ks5ucJtagaJpZM4WsLWA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now requires mypy_extensions so added it as well.
Motivation for this change
I've had mypy problems when running with python language server. I updated mypy, sadly it doesn''t fix my problem but let's share the update eitherway.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)