Improve docs #46777
Merged
Improve docs #46777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
False statements don't cause NixOS tests to fail, we need to throw an exception or terminate.
grahamc
approved these changes
Sep 17, 2018
| </screen> | ||
| The function <command>testScript</command> executes the entire test script | ||
| and drops you back into the test driver command line upon its completion. | ||
| This allows you to inspect the state of the VMs after the test (e.g. to debug | ||
| the test script). | ||
| the test script). The machine state is kept across VM restarts in | ||
| <filename>/tmp/vm-state-</filename><varname>machinename</varname>. |
There was a problem hiding this comment.
This should probably be in a separate para.
grahamc
reviewed
Sep 17, 2018
| @@ -108,7 +108,7 @@ xlink:href="https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/virtualis | |||
| <programlisting> | |||
| $machine->start; | |||
| $machine->waitForUnit("default.target"); | |||
| $machine->succeed("uname") =~ /Linux/; | |||
| die unless $machine->succeed("uname") =~ /Linux/; | |||
There was a problem hiding this comment.
I don't love this change because it isn't actually something we ever do in the tests (there are no die unlesss) but I do agree we shouldn't have the comparison just be ignored.
There was a problem hiding this comment.
Should I change it to $machine->succeed('[[ $(uname) =~ Linux ]]') then?
There was a problem hiding this comment.
Nah, let's take it as-is. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI, regarding commit
nixos tests doc: update VM state path: The current state path is defined here.