Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ostree: fix tests #46762

Merged
merged 1 commit into from Sep 17, 2018
Merged

ostree: fix tests #46762

merged 1 commit into from Sep 17, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 17, 2018

Motivation for this change

ostree tests have never passed on hydra: https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.ostree.x86_64-linux/all .
This may be the combined result of some upstream issues and our specific test setup.

To make the tests pass:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

cc @jtojnar

@xeji
ostree: fix tests
d734328 
- Workarounds for ostreedev/ostree#1592
- Disable failing test-gpg-verify-result.test, see
  ostreedev/ostree#1634
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: ostree

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ostree

Partial log (click to expand)

/nix/store/ygfda0pw53nnd3ldww0vf8p5g2akaffb-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-pull-override-url.sh: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/ygfda0pw53nnd3ldww0vf8p5g2akaffb-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-gpg-signed-commit.sh: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/ygfda0pw53nnd3ldww0vf8p5g2akaffb-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-refs-collections.sh: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/ygfda0pw53nnd3ldww0vf8p5g2akaffb-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-help.sh: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/ygfda0pw53nnd3ldww0vf8p5g2akaffb-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-pull-mirrorlist.sh: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/ygfda0pw53nnd3ldww0vf8p5g2akaffb-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-pull-commit-only.sh: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/ygfda0pw53nnd3ldww0vf8p5g2akaffb-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-fsck-collections.sh: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/ygfda0pw53nnd3ldww0vf8p5g2akaffb-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-admin-pull-deploy-commit.sh: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/ygfda0pw53nnd3ldww0vf8p5g2akaffb-ostree-2018.8-installedTests...
/nix/store/z4fg5xbz59s0mfhdq5ixas3x0hs0czsj-ostree-2018.8

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: ostree

Partial log (click to expand)

/nix/store/j306cn1vb60lamfssynigw25hgi3x9wc-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-remote-headers.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/j306cn1vb60lamfssynigw25hgi3x9wc-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-remote-add.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/j306cn1vb60lamfssynigw25hgi3x9wc-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-archivez.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/j306cn1vb60lamfssynigw25hgi3x9wc-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-pull-subpath.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/j306cn1vb60lamfssynigw25hgi3x9wc-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-basic-root.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/j306cn1vb60lamfssynigw25hgi3x9wc-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-basic-user-only.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/j306cn1vb60lamfssynigw25hgi3x9wc-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-basic-user.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/j306cn1vb60lamfssynigw25hgi3x9wc-ostree-2018.8-installedTests/libexec/installed-tests/libostree/test-basic.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/j306cn1vb60lamfssynigw25hgi3x9wc-ostree-2018.8-installedTests...
/nix/store/qkfvv1h0y585nazkrr3glk5qgl8wyyrd-ostree-2018.8

@jtojnar
Copy link
Contributor

jtojnar commented Sep 17, 2018

@GrahamcOfBorg test ostree

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.ostree

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 418.27s
cleaning up
killing machine (pid 597)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/sq69zy9hhk68zs8zjybj9md66mdz65da-vm-test-run-ostree

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.ostree

Partial log (click to expand)

machine: exit status 1
syncing
machine: running command: sync
machine: exit status 0
test script finished in 1151.90s
cleaning up
killing machine (pid 631)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/sryrzx3qp9yqlmi2y4zaai20j3gnq26a-vm-test-run-ostree

@jtojnar
Copy link
Contributor

jtojnar commented Sep 17, 2018

Thank you for tackling this.

@jtojnar jtojnar merged commit e352b27 into NixOS:master Sep 17, 2018
@xeji
Copy link
Contributor Author

xeji commented Sep 17, 2018

backported to 18.09 in 39c585a cc ZHF #45960

@xeji xeji deleted the p/ostree-test branch September 17, 2018 07:27
@xeji xeji mentioned this pull request Sep 18, 2018
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @jtojnar