Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtk-doc: don't build with dblatex by default #46761

Merged
merged 1 commit into from Sep 17, 2018
Merged

gtk-doc: don't build with dblatex by default #46761

merged 1 commit into from Sep 17, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Sep 16, 2018

Motivation for this change

Fix #46740 . Make it optional: (withDblatex ? false) to remove the dependency of gtk-doc on texlive.
Without dblatex, it cannot generate pdf docs, but most people wouldn't want those by default anyway.

Now changes to texlive don't trigger mass rebuilds any more.
This may also help with #45950 (comment).

Things done
  • built in sandbox on NixOS

cc @jtojnar

@xeji
gtk-doc: don't build with dblatex by default
d6ecbe1 
make it optional: withDblatex ? false
This removes the dependency of gtk-doc on texlive.
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gtk-doc

Partial log (click to expand)

 /nix/store/v72a581ms1xzgv3s44s8k2dyhb6d5fjl-coreutils-8.29/bin/mkdir -p '/nix/store/a0wwwvkfblhl7b7kr05l3pnnglzss89n-gtk-doc-1.28/share/gtk-doc/python/gtkdoc'
 /nix/store/v72a581ms1xzgv3s44s8k2dyhb6d5fjl-coreutils-8.29/bin/install -c -m 644 gtkdoc/__init__.py gtkdoc/check.py gtkdoc/common.py gtkdoc/config.py gtkdoc/fixxref.py gtkdoc/md_to_db.py gtkdoc/mkdb.py gtkdoc/mkhtml.py gtkdoc/mkhtml2.py gtkdoc/mkman.py gtkdoc/mkpdf.py gtkdoc/rebase.py gtkdoc/scan.py gtkdoc/scangobj.py '/nix/store/a0wwwvkfblhl7b7kr05l3pnnglzss89n-gtk-doc-1.28/share/gtk-doc/python/gtkdoc'
make[2]: Leaving directory '/build/gtk-doc-1.28'
make[1]: Leaving directory '/build/gtk-doc-1.28'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/a0wwwvkfblhl7b7kr05l3pnnglzss89n-gtk-doc-1.28
strip is /nix/store/1ji4bvprnyx38ym1d0zcgl2bpw5zrh2d-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/a0wwwvkfblhl7b7kr05l3pnnglzss89n-gtk-doc-1.28/lib  /nix/store/a0wwwvkfblhl7b7kr05l3pnnglzss89n-gtk-doc-1.28/bin
patching script interpreter paths in /nix/store/a0wwwvkfblhl7b7kr05l3pnnglzss89n-gtk-doc-1.28
checking for references to /build in /nix/store/a0wwwvkfblhl7b7kr05l3pnnglzss89n-gtk-doc-1.28...

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: gtk-doc

Partial log (click to expand)

cannot build derivation '/nix/store/gni15n79s5ibrvw6ccpxjjh3vnl42va7-libxml2-2.9.8.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/sci9xi0zp5w7j6c5bb0cdnlkylgvsqg7-python2.7-bootstrapped-pip-18.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/mzkrw7kdmjajsyjm3r939kcs37d4mgrp-libxml2+py-2.9.8.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/lswhywi289nyvywrvjxhhsc0nf844b85-libxslt-1.1.32.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/5ir5r41qy73xy5vyrnvbmd7g55dvkl84-python2.7-setuptools-40.2.0.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/50w140wq3xjff2cb72w87csjhyi9njyf-gnome-doc-utils-0.20.10.drv': 10 dependencies couldn't be built
cannot build derivation '/nix/store/xrs9vcaji7af5x2218vjvyavn83g0k05-itstool-2.0.2.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/sysryshlixd8m9vbzzzc0n6qmq7grqy1-python2.7-six-1.11.0.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/ql8yc17mx8y7yfg7rrp5smzcbwazvsgv-gtk-doc-1.28.drv': 15 dependencies couldn't be built
error: build of '/nix/store/ql8yc17mx8y7yfg7rrp5smzcbwazvsgv-gtk-doc-1.28.drv' failed

@jtojnar
Copy link
Contributor

jtojnar commented Sep 17, 2018

LGTM

cc @hedning

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gtk-doc

Partial log (click to expand)

 /nix/store/y6xix9v9pqpvq01va129fqyhh32aiiwq-coreutils-8.29/bin/mkdir -p '/nix/store/i7jh5xkzi39y2hbb63gxjdrm83hwxdgp-gtk-doc-1.28/share/gtk-doc/python/gtkdoc'
 /nix/store/y6xix9v9pqpvq01va129fqyhh32aiiwq-coreutils-8.29/bin/install -c -m 644 gtkdoc/__init__.py gtkdoc/check.py gtkdoc/common.py gtkdoc/config.py gtkdoc/fixxref.py gtkdoc/md_to_db.py gtkdoc/mkdb.py gtkdoc/mkhtml.py gtkdoc/mkhtml2.py gtkdoc/mkman.py gtkdoc/mkpdf.py gtkdoc/rebase.py gtkdoc/scan.py gtkdoc/scangobj.py '/nix/store/i7jh5xkzi39y2hbb63gxjdrm83hwxdgp-gtk-doc-1.28/share/gtk-doc/python/gtkdoc'
make[2]: Leaving directory '/build/gtk-doc-1.28'
make[1]: Leaving directory '/build/gtk-doc-1.28'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/i7jh5xkzi39y2hbb63gxjdrm83hwxdgp-gtk-doc-1.28
strip is /nix/store/v372zgd5rpwkw9d7r8f1s8063c08chw1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/i7jh5xkzi39y2hbb63gxjdrm83hwxdgp-gtk-doc-1.28/lib  /nix/store/i7jh5xkzi39y2hbb63gxjdrm83hwxdgp-gtk-doc-1.28/bin
patching script interpreter paths in /nix/store/i7jh5xkzi39y2hbb63gxjdrm83hwxdgp-gtk-doc-1.28
checking for references to /build in /nix/store/i7jh5xkzi39y2hbb63gxjdrm83hwxdgp-gtk-doc-1.28...

@hedning
Copy link
Contributor

hedning commented Sep 17, 2018

Yeah, seems sane.

@jtojnar jtojnar merged commit ff853cc into NixOS:staging Sep 17, 2018
@xeji xeji deleted the p/gtk-doc-dblatex branch September 17, 2018 12:59
This was referenced Sep 17, 2018
Closed
Closed
@xeji
Copy link
Contributor Author

xeji commented Sep 18, 2018

picked to staging-18.09 in 3d94991 since it will do another texlive-related mass rebuild anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xeji @GrahamcOfBorg @jtojnar @hedning