Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvramtool: init at 4.8.1 #46774

Merged
merged 1 commit into from Sep 17, 2018
Merged

nvramtool: init at 4.8.1 #46774

merged 1 commit into from Sep 17, 2018

Conversation

cryptix
Copy link
Contributor

@cryptix cryptix commented Sep 17, 2018

Motivation for this change

https://www.coreboot.org/Nvramtool - useful for coreboot users to change settings like trackpad/wwan/bluetooth enabled.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Sep 17, 2018

@GrahamcOfBorg build nvramtool

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: nvramtool

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: nvramtool

Partial log (click to expand)

make: Leaving directory '/build/coreboot/util/nvramtool'
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gw35iwydkih2d50in8k9h8wramr7v6v9-nvramtool-4.8.1
shrinking /nix/store/gw35iwydkih2d50in8k9h8wramr7v6v9-nvramtool-4.8.1/bin/nvramtool
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gw35iwydkih2d50in8k9h8wramr7v6v9-nvramtool-4.8.1/bin
patching script interpreter paths in /nix/store/gw35iwydkih2d50in8k9h8wramr7v6v9-nvramtool-4.8.1
checking for references to /build in /nix/store/gw35iwydkih2d50in8k9h8wramr7v6v9-nvramtool-4.8.1...
/nix/store/gw35iwydkih2d50in8k9h8wramr7v6v9-nvramtool-4.8.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: nvramtool

Partial log (click to expand)

make: Leaving directory '/build/coreboot/util/nvramtool'
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/v7z5y1rfa3m5s7vwprkp449hxzk19b8q-nvramtool-4.8.1
shrinking /nix/store/v7z5y1rfa3m5s7vwprkp449hxzk19b8q-nvramtool-4.8.1/bin/nvramtool
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/v7z5y1rfa3m5s7vwprkp449hxzk19b8q-nvramtool-4.8.1/bin
patching script interpreter paths in /nix/store/v7z5y1rfa3m5s7vwprkp449hxzk19b8q-nvramtool-4.8.1
checking for references to /build in /nix/store/v7z5y1rfa3m5s7vwprkp449hxzk19b8q-nvramtool-4.8.1...
/nix/store/v7z5y1rfa3m5s7vwprkp449hxzk19b8q-nvramtool-4.8.1

@xeji xeji merged commit fa58491 into NixOS:master Sep 17, 2018
@cryptix cryptix deleted the nvramtool branch September 17, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cryptix @xeji @GrahamcOfBorg