haskellPackages: Fix gi-glib, gi-cairo and gi-xlib for 8.2 #46767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peti
requested changes
Sep 17, 2018
| @@ -96,4 +96,9 @@ self: super: { | |||
| haddock-library = dontHaddock (dontCheck self.haddock-library_1_5_0_1); | |||
| })); | |||
|
|
|||
| # ??? | |||
There was a problem hiding this comment.
Ah yeah, I intentionally put it there because I don't know why that override is needed. Will update if I find out
|
Looks like the authors have a problem with haskell-gi-overloading-1.0 on GHC 8.2. From the gi-glib cabal file: Should we just unilaterally set |
|
Can't be bothered with this right now. It's almost not worth fixing these couple packages when I know lots more would fail. A mass fix would be nicer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This and #46766 fix the build for taffybar on 8.2
I'm not entirely sure what the reason for needing the override is
Ping @basvandijk @peti
Things done
sandboxinnix.confon non-NixOS)