ibus-typing-booster: init at 2.1.1 #46779

Ma27 · 2018-09-17T12:59:30Z

Motivation for this change

This package providesa completion input method for faster typing.
See https://mike-fabian.github.io/ibus-typing-booster

Detailed instructions how to activate this IBus engine on your desktop
can be found in the upstream docs: https://mike-fabian.github.io/ibus-typing-booster/documentation.html

A simple VM with the Gnome3 desktop and activated `ibus' looks like
this:

{
  emojipicker = { pkgs, ... }: {
    services.xserver = {
      enable = true;
      desktopManager.gnome3.enable = true;
      desktopManager.xterm.enable = false;
    };
    users.extraUsers.vm = {
      password = "vm";
      isNormalUser = true;
    };
    i18n.inputMethod.ibus.engines = [
      pkgs.ibus-engines.typing-booster
    ];
    i18n.inputMethod.enabled = "ibus";
    virtualisation.memorySize = 2048;
  };
}

Fixes #38721

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Determined the impact on package closure size (by running nix path-info -S before and after)
Fits CONTRIBUTING.md.

Ma27 · 2018-09-17T13:01:23Z

/cc @ninjarai4 would you mind reviewing and testing this?

jtojnar · 2018-09-17T17:13:18Z

pkgs/tools/inputmethods/ibus-engines/ibus-typing-booster/default.nix

+
+  postInstall = ''
+    for i in $out/bin/emoji-picker $out/libexec/ibus-setup-typing-booster $out/libexec/ibus-engine-typing-booster; do
+      wrapProgram "$i" \


Why not use wrapGAppsHook?

It definitely needs to be used, otherwise the booster crashes with “Settings schema 'org.freedesktop.ibs.engine.typing-booster' is not installed”

Ma27 · 2018-09-17T18:47:47Z

@jtojnar good catch! Does the change look fine now? :)

jtojnar · 2018-09-17T19:00:57Z

pkgs/tools/inputmethods/ibus-engines/ibus-typing-booster/default.nix

+  postInstall = ''
+    for i in ibus-{engine,setup}-typing-booster; do
+      wrapProgram $out/libexec/$i \
+        --prefix LD_LIBRARY_PATH : "${m17n_lib}/lib"


You can use gappsWrapperArgs+=(--prefix LD_LIBRARY_PATH : "${m17n_lib}/lib") in preFixup to make wrapGAppsHook apply it.

jtojnar · 2018-09-17T20:33:18Z

pkgs/tools/inputmethods/ibus-engines/ibus-typing-booster/default.nix

+  buildInputs = [ python ibus gtk3 m17n_lib ];
+
+  preBuild = ''
+    export GI_TYPELIB_PATH="${mkRepoPaths [ gtk3 pango.out gdk_pixbuf atk ibus ]}"


Add gobjectIntrospection to nativeBuildInputs to populate the variable automatically.

jtojnar · 2018-09-17T20:37:47Z

Also, the commit tag should be the attribute name (ibus-engines.typing-booster).

Ma27 · 2018-09-17T21:28:44Z

fixed. Thanks a lot for helping and explaining how to use wrapGAppsHook!

jtojnar · 2018-09-17T21:33:40Z

pkgs/tools/inputmethods/ibus-engines/ibus-typing-booster/default.nix

+    sha256 = "01kpxplk9nh56f32fkq3nnsqykbzpi7pcxbfp38dq0prgrhw9a6b";
+  };
+
+  nativeBuildInputs = [ autoreconfHook pkgconfig makeWrapper wrapGAppsHook gobjectIntrospection ];


You can drop makeWrapper now.

jtojnar · 2018-09-17T21:36:12Z

pkgs/tools/inputmethods/ibus-engines/ibus-typing-booster/default.nix

+  meta = with stdenv.lib; {
+    homepage = https://mike-fabian.github.io/ibus-typing-booster/;
+    license = licenses.gpl2;
+    description = "ibus-typing-booster is a completion input method for faster typing.";


No need to have the package name in the description. See https://repology.org/metapackage/ibus-typing-booster/information#Summaries for examples.

jtojnar · 2018-09-17T21:38:15Z

pkgs/tools/inputmethods/ibus-engines/ibus-typing-booster/default.nix

+
+  meta = with stdenv.lib; {
+    homepage = https://mike-fabian.github.io/ibus-typing-booster/;
+    license = licenses.gpl2;


Seems to be licensed under gpl3Plus.

Ma27 · 2018-09-17T21:40:39Z

fixed.

jtojnar · 2018-09-17T21:41:07Z

pkgs/tools/inputmethods/ibus-engines/ibus-typing-booster/default.nix

@@ -0,0 +1,39 @@
+{ stdenv, fetchFromGitHub, autoreconfHook, python3, ibus, pkgconfig, gtk3, m17n_lib
+, pango, gdk_pixbuf, atk, wrapGAppsHook, gobjectIntrospection


You can clean this list a bit.

GrahamcOfBorg · 2018-09-17T21:58:04Z

Success on x86_64-linux (full log)

Attempted: ibus-engines.typing-booster

Partial log (click to expand)

Wrapping program /nix/store/9a9qx1lklax012fl3jqyvj396q4qnd32-ibus-typing-booster-2.1.1/libexec/ibus-setup-typing-booster
shrinking RPATHs of ELF executables and libraries in /nix/store/9a9qx1lklax012fl3jqyvj396q4qnd32-ibus-typing-booster-2.1.1
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9a9qx1lklax012fl3jqyvj396q4qnd32-ibus-typing-booster-2.1.1/libexec  /nix/store/9a9qx1lklax012fl3jqyvj396q4qnd32-ibus-typing-booster-2.1.1/bin
patching script interpreter paths in /nix/store/9a9qx1lklax012fl3jqyvj396q4qnd32-ibus-typing-booster-2.1.1
/nix/store/9a9qx1lklax012fl3jqyvj396q4qnd32-ibus-typing-booster-2.1.1/libexec/.ibus-engine-typing-booster-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/9a9qx1lklax012fl3jqyvj396q4qnd32-ibus-typing-booster-2.1.1/libexec/.ibus-setup-typing-booster-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/9a9qx1lklax012fl3jqyvj396q4qnd32-ibus-typing-booster-2.1.1/bin/.emoji-picker-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/9a9qx1lklax012fl3jqyvj396q4qnd32-ibus-typing-booster-2.1.1...
/nix/store/9a9qx1lklax012fl3jqyvj396q4qnd32-ibus-typing-booster-2.1.1

GrahamcOfBorg · 2018-09-17T21:58:31Z

Success on aarch64-linux (full log)

Attempted: ibus-engines.typing-booster

Partial log (click to expand)

Wrapping program /nix/store/xvzhyrc838r99270p9r9lzv2s9a9vcxm-ibus-typing-booster-2.1.1/libexec/ibus-engine-typing-booster
shrinking RPATHs of ELF executables and libraries in /nix/store/xvzhyrc838r99270p9r9lzv2s9a9vcxm-ibus-typing-booster-2.1.1
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/xvzhyrc838r99270p9r9lzv2s9a9vcxm-ibus-typing-booster-2.1.1/libexec  /nix/store/xvzhyrc838r99270p9r9lzv2s9a9vcxm-ibus-typing-booster-2.1.1/bin
patching script interpreter paths in /nix/store/xvzhyrc838r99270p9r9lzv2s9a9vcxm-ibus-typing-booster-2.1.1
/nix/store/xvzhyrc838r99270p9r9lzv2s9a9vcxm-ibus-typing-booster-2.1.1/libexec/.ibus-engine-typing-booster-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/xvzhyrc838r99270p9r9lzv2s9a9vcxm-ibus-typing-booster-2.1.1/libexec/.ibus-setup-typing-booster-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/xvzhyrc838r99270p9r9lzv2s9a9vcxm-ibus-typing-booster-2.1.1/bin/.emoji-picker-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/xvzhyrc838r99270p9r9lzv2s9a9vcxm-ibus-typing-booster-2.1.1...
/nix/store/xvzhyrc838r99270p9r9lzv2s9a9vcxm-ibus-typing-booster-2.1.1

jtojnar

Just picking some nits in the docs.

jtojnar · 2018-09-17T22:04:24Z

doc/package-notes.xml

+ <section xml:id="sec-ibus-typing-booster">
+  <title>ibus-engines.typing-booster</title>
+
+  <para>This package is an ibus-based completion method to speedup typing.</para>


speedup is a noun, speed up is a verb.

jtojnar · 2018-09-17T22:06:04Z

doc/package-notes.xml

+  <para>This package is an ibus-based completion method to speedup typing.</para>
+
+  <section xml:id="sec-ibus-typing-booster-activate">
+   <title>Activate engine</title>


Try using “Activating the engine” or “Enabling the engine”, imperative form does not really suit titles.

jtojnar · 2018-09-17T22:12:33Z

doc/package-notes.xml

+    <link xlink:href="https://mike-fabian.github.io/ibus-typing-booster/documentation.html">upstream docs</link>.
+   </para>
+   <para>
+    On NixOS you explicitly need to enable <literal>ibus</literal> with given engines


I would add a comma after “On NixOS” but again, it might not be necessary.

Isn't this just an object at the beginning of a sentence? AFAIK such expressions don't need a comma.

You are probably right. After rereading it, the commas seem pointless.

jtojnar · 2018-09-17T22:13:24Z

doc/package-notes.xml

+   <title>Activate engine</title>
+
+   <para>
+    IBus needs to be configured accordingly to activate <literal>typing-booster</literal>. The configuration


I would add a comma after “IBus needs to be configured accordingly” clause but we should probably check with a native speaker.

I'm not 100% sure here, but I thought that infinitive sentences at the end don't necessarily need the comma.

jtojnar · 2018-09-17T22:15:53Z

doc/package-notes.xml

+  </section>
+
+  <section xml:id="sec-ibus-typing-booster-emoji-picker">
+   <title>Builtin emoji picker</title>


“built-in” is more common spelling in the docs.

jtojnar · 2018-09-17T22:18:00Z

doc/package-notes.xml

+
+   <para>
+    The <literal>ibus-engines.typing-booster</literal> package contains a program
+    named <literal>emoji-picker</literal>. In order to ensure it's working properly,


Do not use contractions in formal writing.

jtojnar · 2018-09-17T22:27:54Z

doc/package-notes.xml

+    <link xlink:href="https://mike-fabian.github.io/ibus-typing-booster/documentation.html">upstream docs</link>.
+   </para>
+   <para>
+    On NixOS you explicitly need to enable <literal>ibus</literal> with given engines


Also I would move the “explicitly” after the “need to” or after “with given engines”.

GrahamcOfBorg · 2018-09-17T23:21:41Z

Success on aarch64-linux (full log)

Attempted: ibus-engines.typing-booster

Partial log (click to expand)

/nix/store/xvzhyrc838r99270p9r9lzv2s9a9vcxm-ibus-typing-booster-2.1.1

GrahamcOfBorg · 2018-09-17T23:21:43Z

Success on x86_64-linux (full log)

Attempted: ibus-engines.typing-booster

Partial log (click to expand)

/nix/store/9a9qx1lklax012fl3jqyvj396q4qnd32-ibus-typing-booster-2.1.1

jtojnar · 2018-09-18T14:57:44Z

Alternative would be creating a wrapper package, see for example GIMP: https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/graphics/gimp/wrapper.nix

Ma27 · 2018-09-18T16:44:02Z

@jtojnar you're right. I patched the script which reads hunspell dirs, so now it looks in the environment.

I ensured that it's possible to override the unwrapped package easily and the wrapped one loads the specified hunspell dictionaries.

GrahamcOfBorg · 2018-09-18T16:52:34Z

Success on x86_64-linux (full log)

Attempted: ibus-engines.typing-booster

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1/libexec  /nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1/bin
patching script interpreter paths in /nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1
/nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1/libexec/.ibus-engine-typing-booster-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1/libexec/.ibus-setup-typing-booster-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1/bin/.emoji-picker-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1...
building '/nix/store/ybmhwymhnnarx31il8lmf2qfdxcj85px-ibus-typing-booster-2.1.1-with-hunspell.drv'...
/nix/store/fmx7asibzsnym9ahmk204xqa4xg2n037-ibus-typing-booster-2.1.1-with-hunspell

GrahamcOfBorg · 2018-09-18T16:55:06Z

Success on aarch64-linux (full log)

Attempted: ibus-engines.typing-booster

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/dx498490ylglb6jk5wpdiq6czq1c1cyv-ibus-typing-booster-2.1.1
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dx498490ylglb6jk5wpdiq6czq1c1cyv-ibus-typing-booster-2.1.1/libexec  /nix/store/dx498490ylglb6jk5wpdiq6czq1c1cyv-ibus-typing-booster-2.1.1/bin
patching script interpreter paths in /nix/store/dx498490ylglb6jk5wpdiq6czq1c1cyv-ibus-typing-booster-2.1.1
/nix/store/dx498490ylglb6jk5wpdiq6czq1c1cyv-ibus-typing-booster-2.1.1/libexec/.ibus-engine-typing-booster-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/dx498490ylglb6jk5wpdiq6czq1c1cyv-ibus-typing-booster-2.1.1/libexec/.ibus-setup-typing-booster-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/dx498490ylglb6jk5wpdiq6czq1c1cyv-ibus-typing-booster-2.1.1/bin/.emoji-picker-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/dx498490ylglb6jk5wpdiq6czq1c1cyv-ibus-typing-booster-2.1.1...
building '/nix/store/dfcr1bnzrhb2z4ga77hmkj147wb5j6ik-ibus-typing-booster-2.1.1-with-hunspell.drv'...
/nix/store/yk0ba28q0brn2sn512h2haz1pjmcdwly-ibus-typing-booster-2.1.1-with-hunspell

ninjarai4 · 2018-09-18T22:59:44Z

Just tested this on my machine again. Seems ok for en-us and it-it (I don't speak Italian so I can't say for sure), but I couldn't get fr-any to work. There is no fr-any option in typing-booster and both fr and fr_FR trigger a error "☹ fr dictionary not found. Please install hunspell dictionary!" or "☹ fr_FR dictionary not found. Please install hunspell dictionary!". Emoji names seem to work properly in any language though, I don't think it uses hunspell for those. Also it would type an odd character after selecting a word candidate unless I checked the box labeled "Use a workaround for a bug in QT im module", but I think that's not an issue we can solve here.

Ma27 · 2018-09-19T09:01:56Z

There is no fr-any option in typing-booster and both fr and fr_FR trigger a error "☹ fr dictionary not found. Please install hunspell dictionary!" or "☹ fr_FR dictionary not found. Please install hunspell dictionary!"

There's a difference between the attribute name and for hunspellDicts in nixpkgsand the actual filename in share/hunspell. Unfortunately I couldn't find a hunspell dict with fr_FR using nix-locate.

I'll try to add one and check french completion.

Ma27 · 2018-09-19T11:25:15Z

Short update regarding the french support: we use dictionaries distributed by dicollecte.org. It provides multiple variants of french, namely classique, moderne, reforme1990 and any (no edge-cases from the former listed variants from my understanding, unfortunately the descriptions are written in french).

All of them can fit as fr_FR from my understanding, but I'm not sure which one's the best solution as I don't speak french.

However this seems to be an issue with our hunspell packaging which is out of scope. I'd propose to remove french from the list of default languages (for now) and get this merged. From my experience most technical people use English as default language either, so this should be good-enough as temporary solution. Let's report the issue and see what french people think about this after that.

@jtojnar anything to add from your side?

GrahamcOfBorg · 2018-09-19T11:43:26Z

Success on x86_64-linux (full log)

Attempted: ibus-engines.typing-booster

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1/libexec  /nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1/bin
patching script interpreter paths in /nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1
/nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1/libexec/.ibus-engine-typing-booster-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1/libexec/.ibus-setup-typing-booster-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1/bin/.emoji-picker-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1...
building '/nix/store/3yl8dr76fb4iv0zf6jb8qbqmxshxxmss-ibus-typing-booster-2.1.1-with-hunspell.drv'...
/nix/store/1w3g6kaz4ysjpwb9y5xggk23bj0639nl-ibus-typing-booster-2.1.1-with-hunspell

GrahamcOfBorg · 2018-09-19T11:44:06Z

Success on aarch64-linux (full log)

Attempted: ibus-engines.typing-booster

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/dx498490ylglb6jk5wpdiq6czq1c1cyv-ibus-typing-booster-2.1.1
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/dx498490ylglb6jk5wpdiq6czq1c1cyv-ibus-typing-booster-2.1.1/libexec  /nix/store/dx498490ylglb6jk5wpdiq6czq1c1cyv-ibus-typing-booster-2.1.1/bin
patching script interpreter paths in /nix/store/dx498490ylglb6jk5wpdiq6czq1c1cyv-ibus-typing-booster-2.1.1
/nix/store/dx498490ylglb6jk5wpdiq6czq1c1cyv-ibus-typing-booster-2.1.1/libexec/.ibus-engine-typing-booster-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/dx498490ylglb6jk5wpdiq6czq1c1cyv-ibus-typing-booster-2.1.1/libexec/.ibus-setup-typing-booster-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/dx498490ylglb6jk5wpdiq6czq1c1cyv-ibus-typing-booster-2.1.1/bin/.emoji-picker-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/dx498490ylglb6jk5wpdiq6czq1c1cyv-ibus-typing-booster-2.1.1...
building '/nix/store/aa25765r3dc9s6r8q9sxqmg8whnpkjx7-ibus-typing-booster-2.1.1-with-hunspell.drv'...
/nix/store/3dzwr03as988fpbh060sh06qfb7dy7gp-ibus-typing-booster-2.1.1-with-hunspell

jtojnar · 2018-09-19T13:23:54Z

doc/package-notes.xml

+  </section>
+
+  <section xml:id="sec-ibus-typing-booster-customize-hunspell">
+   <title>Use custom hunspell dictionaries</title>


s/Use/Using/

jtojnar · 2018-09-19T13:24:36Z

doc/package-notes.xml

+   <para>
+    The IBus engine is based on <literal>hunspell</literal> to support completion in many languages.
+    By default the dictionaries <literal>de-de</literal>, <literal>en-us</literal>, <literal>es-es</literal>,
+    <literal>it-it</literal>, <literal>fr-any</literal>, <literal>sv-se</literal> and <literal>sv-fi</literal>


Remove French from here as well.

jtojnar · 2018-09-19T13:24:57Z

doc/package-notes.xml

+    The IBus engine is based on <literal>hunspell</literal> to support completion in many languages.
+    By default the dictionaries <literal>de-de</literal>, <literal>en-us</literal>, <literal>es-es</literal>,
+    <literal>it-it</literal>, <literal>fr-any</literal>, <literal>sv-se</literal> and <literal>sv-fi</literal>
+    are in use. To add another dictionary, the package can be overriden like this:


s/overriden/overridden/

This package providesa completion input method for faster typing. See https://mike-fabian.github.io/ibus-typing-booster Detailed instructions how to activate this IBus engine on your desktop can be found in the upstream docs: https://mike-fabian.github.io/ibus-typing-booster/documentation.html A simple VM with the Gnome3 desktop and activated `ibus' looks like this: ```nix { emojipicker = { pkgs, ... }: { services.xserver = { enable = true; desktopManager.gnome3.enable = true; desktopManager.xterm.enable = false; }; users.extraUsers.vm = { password = "vm"; isNormalUser = true; }; i18n.inputMethod.ibus.engines = [ pkgs.ibus-engines.typing-booster ]; i18n.inputMethod.enabled = "ibus"; virtualisation.memorySize = 2048; }; } ``` Fixes NixOS#38721

Ma27 · 2018-09-19T19:28:30Z

@jtojnar thanks, fixed!

jtojnar

Thanks for the PR, especially for the detailed docs.

GrahamcOfBorg · 2018-09-19T19:43:34Z

Success on aarch64-linux (full log)

Attempted: ibus-engines.typing-booster

Partial log (click to expand)

/nix/store/3dzwr03as988fpbh060sh06qfb7dy7gp-ibus-typing-booster-2.1.1-with-hunspell

GrahamcOfBorg · 2018-09-19T19:44:04Z

Success on x86_64-linux (full log)

Attempted: ibus-engines.typing-booster

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1/libexec  /nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1/bin
patching script interpreter paths in /nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1
/nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1/libexec/.ibus-setup-typing-booster-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1/libexec/.ibus-engine-typing-booster-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1/bin/.emoji-picker-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/5j0c94l0yjbq34a5a8y43s7dnidlrl0h-ibus-typing-booster-2.1.1...
building '/nix/store/3yl8dr76fb4iv0zf6jb8qbqmxshxxmss-ibus-typing-booster-2.1.1-with-hunspell.drv'...
/nix/store/1w3g6kaz4ysjpwb9y5xggk23bj0639nl-ibus-typing-booster-2.1.1-with-hunspell

Ma27 · 2018-09-19T21:42:18Z

@jtojnar any chance to get this merged then?%)

jtojnar · 2018-09-19T21:43:50Z

Sure, was just waiting for borg and must have missed the notification.

This has been postponed[1] because of an unclear state of the french dictionary provided by hunspell[2]. [1] NixOS#46779 (comment) [2] NixOS#46940 (comment)

GrahamcOfBorg added 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Sep 17, 2018

jtojnar reviewed Sep 17, 2018

View reviewed changes

Ma27 force-pushed the package-ibus-typing-booster branch 2 times, most recently from bf643b1 to 485296b Compare September 17, 2018 18:46

jtojnar requested changes Sep 17, 2018

View reviewed changes

Ma27 force-pushed the package-ibus-typing-booster branch from 485296b to ff6a2fe Compare September 17, 2018 21:28

Ma27 force-pushed the package-ibus-typing-booster branch 2 times, most recently from 6390d6d to f1c0675 Compare September 17, 2018 21:32

jtojnar reviewed Sep 17, 2018

View reviewed changes

Ma27 force-pushed the package-ibus-typing-booster branch 2 times, most recently from b158f00 to 8b795c3 Compare September 17, 2018 21:40

jtojnar reviewed Sep 17, 2018

View reviewed changes

Ma27 force-pushed the package-ibus-typing-booster branch from 8b795c3 to adb53e3 Compare September 17, 2018 21:43

jtojnar reviewed Sep 17, 2018

View reviewed changes

Ma27 force-pushed the package-ibus-typing-booster branch from adb53e3 to 9266412 Compare September 17, 2018 23:08

Ma27 force-pushed the package-ibus-typing-booster branch from ae24026 to a3e5986 Compare September 18, 2018 16:39

Ma27 force-pushed the package-ibus-typing-booster branch from a3e5986 to 095e432 Compare September 19, 2018 11:26

jtojnar reviewed Sep 19, 2018

View reviewed changes

Ma27 force-pushed the package-ibus-typing-booster branch from 095e432 to dee2dab Compare September 19, 2018 19:27

jtojnar approved these changes Sep 19, 2018

View reviewed changes

jtojnar merged commit 82cc6a7 into NixOS:master Sep 19, 2018

Ma27 deleted the package-ibus-typing-booster branch September 19, 2018 21:53

Ma27 mentioned this pull request Sep 20, 2018

Provide hunspell dictionary with fr_FR.dict #46940

Closed

		@@ -0,0 +1,39 @@
		{ stdenv, fetchFromGitHub, autoreconfHook, python3, ibus, pkgconfig, gtk3, m17n_lib
		, pango, gdk_pixbuf, atk, wrapGAppsHook, gobjectIntrospection

ibus-typing-booster: init at 2.1.1 #46779

ibus-typing-booster: init at 2.1.1 #46779

Conversation

Ma27 commented Sep 17, 2018 • edited

Motivation for this change

Things done

Ma27 commented Sep 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ma27 commented Sep 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jtojnar commented Sep 17, 2018 • edited

Ma27 commented Sep 17, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ma27 commented Sep 17, 2018

Choose a reason for hiding this comment

GrahamcOfBorg commented Sep 17, 2018

GrahamcOfBorg commented Sep 17, 2018

jtojnar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jtojnar Sep 18, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GrahamcOfBorg commented Sep 17, 2018

GrahamcOfBorg commented Sep 17, 2018

jtojnar commented Sep 18, 2018

Ma27 commented Sep 18, 2018

GrahamcOfBorg commented Sep 18, 2018

GrahamcOfBorg commented Sep 18, 2018

ninjarai4 commented Sep 18, 2018

Ma27 commented Sep 19, 2018

Ma27 commented Sep 19, 2018

GrahamcOfBorg commented Sep 19, 2018

GrahamcOfBorg commented Sep 19, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ma27 commented Sep 19, 2018

jtojnar left a comment

Choose a reason for hiding this comment

GrahamcOfBorg commented Sep 19, 2018

GrahamcOfBorg commented Sep 19, 2018

Ma27 commented Sep 19, 2018

jtojnar commented Sep 19, 2018

Ma27 commented Sep 17, 2018 •

edited

jtojnar commented Sep 17, 2018 •

edited

jtojnar Sep 18, 2018 •

edited