git-appraise: init unstable at 2018-02-26 #46781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haslersn
reviewed
Sep 17, 2018
|
|
||
| buildGoPackage rec { | ||
| name = "git-appraise-unstable-${version}"; | ||
| version = "2018-02-26"; |
There was a problem hiding this comment.
It seems like the commit was on February 27th.
There was a problem hiding this comment.
@haslersn weird… go2nix did put this 🤔 but indeed GitHub shows Feb. 27th
There was a problem hiding this comment.
ah… because of my timezone I guess
git show 2414523
commit 2414523905939525559e4b2498c5597f86193b61 (HEAD -> master, origin/master, origin/HEAD)
Merge: 0cd354a 7c60f9d
Author: Omar Jarjur <ojarjur@google.com>
Date: Mon Feb 26 21:36:54 2018 -0500
srhb
requested changes
Sep 18, 2018
| @@ -0,0 +1,23 @@ | |||
| { stdenv, buildGoPackage, fetchgit, fetchhg, fetchbzr, fetchsvn }: | |||
|
|
||
| goPackagePath = "github.com/google/git-appraise"; | ||
|
|
||
| src = fetchgit { |
There was a problem hiding this comment.
Is there any reason to not use fetchFromGitHub here? It saves a lot of bandwidth.
There was a problem hiding this comment.
Not really, it's just how go2nix did it. I'll update 😉
|
|
||
| meta = { | ||
| description = "Distributed code review system for Git repos"; | ||
| homepage = "https://github.com/google/git-appraise"; |
There was a problem hiding this comment.
Prefer unquoted urls when you're not doing subtitutions within them
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
new-git-appraise
branch
from
1c42cc2
to
69f028e
Compare
|
@srhb updated 👼 |
|
@GrahamcOfBorg build gitAndTools.git-appraise |
srhb
approved these changes
Sep 18, 2018
|
Success on x86_64-linux (full log) Attempted: gitAndTools.git-appraise Partial log (click to expand)
|
|
Success on x86_64-darwin (full log) Attempted: gitAndTools.git-appraise Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: gitAndTools.git-appraise Partial log (click to expand)
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vincent Demeester vincent@sbr.pm
Motivation for this change
Package up a recent version of https://github.com/google/git-appraise… That's why it's starting from
master(a.k.a. unstable-2018-02-26)Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)