Mark nvidia driver as broken on 4.18 #45509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addition to #45410
vcunat
added a commit
that referenced
this pull request
Aug 23, 2018
|
There's a PR that updates it, which fixed the problem for me? On phone so hard to look up but don't think anyone's voiced a reason to not merge it... |
|
Right, I didn't notice #44822 but the author noticed this PR and solved it. |
|
It seems that your commit breaks evaluation for all kernels, as the kernel parameter may be null (i.e. |
|
@tkerber my commit wasn't structured in a proper way anyway :) |
|
Not quite sure what you mean by that, but regardless, @vcunat merged it, and things broke :/ |
|
@tkerber I read CONTRIBUTING and it says that commit message should be |
|
Oh, I didn't realize that problem, and I'm in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addition to #45410
Motivation for this change
Currently nvidia driver is broken on Linux kernel 4.18:
https://gist.github.com/Yardanico/bd250e4626de1d1cfd990e603eef7b4c
Also - http://rglinuxtech.com/?p=2315
So, until nvidia driver is updated to a newer version we should mark it as broken.
P.S: This is my first small PR, so I might have done something wrong :D
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)