Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pcre2: fetch src from HTTPS instead of FTP #45505

Merged
merged 1 commit into from Aug 23, 2018
Merged

pcre2: fetch src from HTTPS instead of FTP #45505

merged 1 commit into from Aug 23, 2018

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Aug 23, 2018 •
edited

Same change as in #44828, for the same reasons.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@bhipple
pcre2: fetch src from HTTPS instead of FTP
4e65df6 
Same change as in NixOS#44828, for the same reasons.
@bhipple
Copy link
Contributor Author

bhipple commented Aug 23, 2018

As mentioned, HTTPS is never worse and often significantly better than FTP. Sha unchanged:

% nix-prefetch-url https://ftp.pcre.org/pub/pcre/pcre2-10.31.tar.bz2
1b389pzw91k1hzydsh4smdsxyppwz4pv74m3nrvy8rda0j3m6zg0

@GrahamcOfBorg build pcre2

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pcre2

Partial log (click to expand)

these paths will be fetched (0.07 MiB download, 0.19 MiB unpacked):
  /nix/store/5pjbamrais8x81nxbaiz0hgx9292w3in-pcre2-10.31-bin
copying path '/nix/store/5pjbamrais8x81nxbaiz0hgx9292w3in-pcre2-10.31-bin' from 'https://nix-cache.s3.amazonaws.com'...
/nix/store/5pjbamrais8x81nxbaiz0hgx9292w3in-pcre2-10.31-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pcre2

Partial log (click to expand)

/nix/store/rdn6zpx7hsgbjg4prfzvsllyrqhjy89a-pcre2-10.31-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pcre2

Partial log (click to expand)

/nix/store/rdn6zpx7hsgbjg4prfzvsllyrqhjy89a-pcre2-10.31-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pcre2

Partial log (click to expand)

/nix/store/5pjbamrais8x81nxbaiz0hgx9292w3in-pcre2-10.31-bin

@Mic92 Mic92 merged commit 669d727 into NixOS:master Aug 23, 2018
@Mic92
Copy link
Member

Mic92 commented Aug 23, 2018

Probably even faster since it requires less network round-trips.

@bhipple bhipple deleted the fix/pcre2-src branch September 22, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bhipple @GrahamcOfBorg @Mic92