Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumping mono to 5.4.1.6 for Emby package #45516

Merged
merged 1 commit into from Aug 23, 2018
Merged

Bumping mono to 5.4.1.6 for Emby package #45516

merged 1 commit into from Aug 23, 2018

Conversation

sterfield
Copy link
Contributor

@sterfield sterfield commented Aug 23, 2018 •
edited

Motivation for this change

Following a discussion on emby forums that I started because I had a bunch of stack trace in current unstable emby, one of the admin has mentioned that the current valid mono version is 5.4.

This PR is just doing that: switching to mono 5.4.

Also, I'm very new to Nixos, still digging in the documentation, but I was able to build this correctly and tested on my personal server, so I assume it's working.

I'll check all the "things to do" mentioned below later to check as much as possible.

Thanks !

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@sterfield sterfield changed the title Bumping mono to 5.4.1.6 Bumping mono to 5.4.1.6 for Emby package Aug 23, 2018
@xeji
Copy link
Contributor

xeji commented Aug 23, 2018

@GrahamcOfBorg build emby

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: emby

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: emby

Partial log (click to expand)

no configure script, doing nothing
building
glibPreInstallPhase
installing
glibPreFixupPhase
post-installation fixup
/nix/store/5im29qx9rni3w8l3j8i2yr22sin55kxv-cctools-binutils-darwin/bin/strip is /nix/store/5im29qx9rni3w8l3j8i2yr22sin55kxv-cctools-binutils-darwin/bin/strip
stripping (with command /nix/store/5im29qx9rni3w8l3j8i2yr22sin55kxv-cctools-binutils-darwin/bin/strip and flags -S) in /nix/store/0v9my0djlzwghap3jdq8c9kszvxdy51b-emby-3.4.1.0/bin
patching script interpreter paths in /nix/store/0v9my0djlzwghap3jdq8c9kszvxdy51b-emby-3.4.1.0
/nix/store/0v9my0djlzwghap3jdq8c9kszvxdy51b-emby-3.4.1.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: emby

Partial log (click to expand)

glibPreInstallPhase
installing
glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/n901pdq6wd33y9crml9s0g72pw3bvzsg-emby-3.4.1.0
/nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip is /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip
stripping (with command /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip and flags -S) in /nix/store/n901pdq6wd33y9crml9s0g72pw3bvzsg-emby-3.4.1.0/bin
patching script interpreter paths in /nix/store/n901pdq6wd33y9crml9s0g72pw3bvzsg-emby-3.4.1.0
checking for references to /build in /nix/store/n901pdq6wd33y9crml9s0g72pw3bvzsg-emby-3.4.1.0...
/nix/store/n901pdq6wd33y9crml9s0g72pw3bvzsg-emby-3.4.1.0

@xeji
Copy link
Contributor

xeji commented Aug 23, 2018

Thank you, LGTM.

@xeji xeji merged commit 86b51e4 into NixOS:master Aug 23, 2018
@sterfield sterfield deleted the emby/mono_upgrade branch August 24, 2018 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sterfield @xeji @GrahamcOfBorg @Janik-Haag