Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sratom: 0.6.0 -> 0.6.2 #45524

Closed
wants to merge 1 commit into from
Closed

sratom: 0.6.0 -> 0.6.2 #45524

wants to merge 1 commit into from

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Aug 23, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented Aug 23, 2018

duplicate of #44695 but with an extra dependency?

@magnetophon
Copy link
Member Author

It checks for it in the config.
Feel free to close.

@xeji
Copy link
Contributor

xeji commented Aug 23, 2018

#44695 was merged to staging (the number of rebuilds is high but not extremely high, so it could go either way). So if you like to add the dependency, it should go to staging as well, so please rebase this.

@magnetophon
Copy link
Member Author

The extra dependency was not put there with much thought.
Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@magnetophon @xeji @GrahamcOfBorg