spl: use correct version to fix binary substitution #45514
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
During the recent refactoring of SPL, the version attribute was mistakenly removed, causing SPL to inherit a
version
attribute from somewhere in the nixpkgs lib. This version is included in the derivation name, and since it differs between Hydra (18.09pre-git
) and normal NixOS machines (something like18.09pre149424.ce522e4ad27
), the SPL is not substituted from the binary cache. Also it should be fixed because this version has nothing to do with SPL.Things done
This PR adds a correct version attribute to the derivation.
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)