Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tor: fix build by upgrading openssl #45513

Merged
merged 1 commit into from Aug 23, 2018
Merged

tor: fix build by upgrading openssl #45513

merged 1 commit into from Aug 23, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 23, 2018 •
edited

One test segfaulted with openssl_1_0_x. openssl_1_1 seems to work fine.
As libevent still uses openssl_1_0_x we disable ssl support there to
avoid having to different ssl versions linked into tor. Longterm it
would be a better solution to upgrade openssl also in libevent. But this
would require more testing/time as we have many dependent packages of
libevent and we would probably need turn to on openssl 1.1 by default
globally. After all libevent is rather small compared to tor.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Mic92
tor: fix build by upgrading openssl
e3d262e 
One test segfaulted with openssl_1_0_x. openssl_1_1 seems to work fine.
As libevent still uses openssl_1_0_x we disable ssl support there to
avoid having to different ssl versions linked into tor. Longterm it
would be a better solution to upgrade openssl also in libevent. But this
would require more testing/time as we have many dependent packages of
libevent and we would probably need turn to on openssl 1.1 by default
globally. After all libevent is rather small compared to tor.
@Mic92
Copy link
Member Author

Mic92 commented Aug 23, 2018

@GrahamcOfBorg build tor
@GrahamcOfBorg test tor

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: tor

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@Mic92 Mic92 requested a review from joachifm August 23, 2018 21:14
@Mic92
Copy link
Member Author

Mic92 commented Aug 23, 2018

https://hydra.nixos.org/build/79977481

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.tor

Partial log (click to expand)

client: exit status 1
syncing
client: running command: sync
client: exit status 0
test script finished in 8.53s
cleaning up
killing client (pid 609)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/ms7icvwrf9ck72p8y2yv3ah95rzxkv5d-vm-test-run-tor

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tor

Partial log (click to expand)

/nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip is /nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip
stripping (with command /nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip and flags -S) in /nix/store/j7960aziv6wwdss7rsyh99s3f94dk876-tor-0.3.3.9/bin
patching script interpreter paths in /nix/store/j7960aziv6wwdss7rsyh99s3f94dk876-tor-0.3.3.9
/nix/store/j7960aziv6wwdss7rsyh99s3f94dk876-tor-0.3.3.9/bin/torify: interpreter directive changed from " /bin/sh" to "/nix/store/9hsgp158m12qi4dsvz6x6dxy5rkiind9-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/j7960aziv6wwdss7rsyh99s3f94dk876-tor-0.3.3.9...
shrinking RPATHs of ELF executables and libraries in /nix/store/frk0lczrskr4ncsq8nw616xkxkb0yxnv-tor-0.3.3.9-geoip
/nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip is /nix/store/8wl4dykwswy42wxj671b6k7vk2ydxg86-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/frk0lczrskr4ncsq8nw616xkxkb0yxnv-tor-0.3.3.9-geoip
checking for references to /build in /nix/store/frk0lczrskr4ncsq8nw616xkxkb0yxnv-tor-0.3.3.9-geoip...
/nix/store/j7960aziv6wwdss7rsyh99s3f94dk876-tor-0.3.3.9

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tor

Partial log (click to expand)

/nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip is /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip
stripping (with command /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip and flags -S) in /nix/store/84vfwc75jniyh6vpgk8smsh13rmlbp71-tor-0.3.3.9/bin
patching script interpreter paths in /nix/store/84vfwc75jniyh6vpgk8smsh13rmlbp71-tor-0.3.3.9
/nix/store/84vfwc75jniyh6vpgk8smsh13rmlbp71-tor-0.3.3.9/bin/torify: interpreter directive changed from " /bin/sh" to "/nix/store/6v88ick1cxnn5g91m8qrrqww0lrlr27x-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/84vfwc75jniyh6vpgk8smsh13rmlbp71-tor-0.3.3.9...
shrinking RPATHs of ELF executables and libraries in /nix/store/53zahqrw7hvfn2w74q716b6mq8mkwqva-tor-0.3.3.9-geoip
/nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip is /nix/store/vp40my263xk32f07788srrgl59rycsna-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/53zahqrw7hvfn2w74q716b6mq8mkwqva-tor-0.3.3.9-geoip
checking for references to /build in /nix/store/53zahqrw7hvfn2w74q716b6mq8mkwqva-tor-0.3.3.9-geoip...
/nix/store/84vfwc75jniyh6vpgk8smsh13rmlbp71-tor-0.3.3.9

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tests.tor

Partial log (click to expand)

syncing
client: running command: sync
client# [   17.735957] tor[600]: Aug 23 21:18:45.000 [notice] New control connection opened from 127.0.0.1.
client: exit status 0
test script finished in 18.73s
cleaning up
killing client (pid 643)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/dq8z449vds2j9d3v1jlcl06c7y9gjwr6-vm-test-run-tor

@Mic92 Mic92 merged commit 60b0511 into NixOS:master Aug 23, 2018
@Mic92 Mic92 deleted the tor branch August 23, 2018 21:19
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tor

Partial log (click to expand)

/nix/store/84vfwc75jniyh6vpgk8smsh13rmlbp71-tor-0.3.3.9

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tor

Partial log (click to expand)

/nix/store/j7960aziv6wwdss7rsyh99s3f94dk876-tor-0.3.3.9

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: tor

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm Awaiting requested review from joachifm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @GrahamcOfBorg