Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsung: Add package tsung version 1.7.0 #46577

Merged
merged 2 commits into from Oct 3, 2018
Merged

tsung: Add package tsung version 1.7.0 #46577

merged 2 commits into from Oct 3, 2018

Conversation

uskudnik
Copy link
Contributor

@uskudnik uskudnik commented Sep 12, 2018 •
edited

Motivation for this change

Add tsung package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Sep 13, 2018

Hi and thanks! You will need to add yourself to /maintainers/maintainer-list.nix in order for this to evaluate.

@srhb
Copy link
Contributor

srhb commented Sep 16, 2018

OK, it builds locally for me, but it looks like there's an included bin/tsplot which requires some more work. It looks like it might be sufficint to wrap it with a python interpreter that has matplotlib available. Are you up for doing this? Otherwise I think the binary should be removed.

@srhb
Copy link
Contributor

srhb commented Sep 16, 2018

@GrahamcOfBorg build tsung

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tsung

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ahrx0kh244xxrgysg59j1bkx3ni71l1n-tsung-1.7.0
gzipping man pages under /nix/store/ahrx0kh244xxrgysg59j1bkx3ni71l1n-tsung-1.7.0/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ahrx0kh244xxrgysg59j1bkx3ni71l1n-tsung-1.7.0/lib  /nix/store/ahrx0kh244xxrgysg59j1bkx3ni71l1n-tsung-1.7.0/bin
patching script interpreter paths in /nix/store/ahrx0kh244xxrgysg59j1bkx3ni71l1n-tsung-1.7.0
/nix/store/ahrx0kh244xxrgysg59j1bkx3ni71l1n-tsung-1.7.0/bin/tsung: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/ahrx0kh244xxrgysg59j1bkx3ni71l1n-tsung-1.7.0/bin/tsung-recorder: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/ahrx0kh244xxrgysg59j1bkx3ni71l1n-tsung-1.7.0...
/nix/store/ahrx0kh244xxrgysg59j1bkx3ni71l1n-tsung-1.7.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tsung

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/7l6zchxrp05y4inm3hm61n4dsxag7npr-tsung-1.7.0
gzipping man pages under /nix/store/7l6zchxrp05y4inm3hm61n4dsxag7npr-tsung-1.7.0/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7l6zchxrp05y4inm3hm61n4dsxag7npr-tsung-1.7.0/lib  /nix/store/7l6zchxrp05y4inm3hm61n4dsxag7npr-tsung-1.7.0/bin
patching script interpreter paths in /nix/store/7l6zchxrp05y4inm3hm61n4dsxag7npr-tsung-1.7.0
/nix/store/7l6zchxrp05y4inm3hm61n4dsxag7npr-tsung-1.7.0/bin/tsung-recorder: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/7l6zchxrp05y4inm3hm61n4dsxag7npr-tsung-1.7.0/bin/tsung: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
checking for references to /build in /nix/store/7l6zchxrp05y4inm3hm61n4dsxag7npr-tsung-1.7.0...
/nix/store/7l6zchxrp05y4inm3hm61n4dsxag7npr-tsung-1.7.0

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: tsung

Partial log (click to expand)

install -pm 0644 ./src/templates/style/bootstrap.min.js ./src/templates/style/dygraph-combined.js ./src/templates/style/jquery.min.js ./src/templates/style/dashboard.css ./src/templates/style/docs.min.css ./src/templates/style/bootstrap.min.css /nix/store/k4qish4vcyadlms8ssnhfw2fvn9knl8n-tsung-1.7.0/share/tsung/templates/style
install -pm 0644 tsung-1.0.dtd /nix/store/k4qish4vcyadlms8ssnhfw2fvn9knl8n-tsung-1.7.0/share/tsung//
post-installation fixup
gzipping man pages under /nix/store/k4qish4vcyadlms8ssnhfw2fvn9knl8n-tsung-1.7.0/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/k4qish4vcyadlms8ssnhfw2fvn9knl8n-tsung-1.7.0/lib  /nix/store/k4qish4vcyadlms8ssnhfw2fvn9knl8n-tsung-1.7.0/bin
patching script interpreter paths in /nix/store/k4qish4vcyadlms8ssnhfw2fvn9knl8n-tsung-1.7.0
/nix/store/k4qish4vcyadlms8ssnhfw2fvn9knl8n-tsung-1.7.0/bin/tsung: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/k4qish4vcyadlms8ssnhfw2fvn9knl8n-tsung-1.7.0/bin/tsung-recorder: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/cblfnvb5rmhd2z231mqasn0brzh1hhv4-bash-4.4-p23/bin/bash"
/nix/store/k4qish4vcyadlms8ssnhfw2fvn9knl8n-tsung-1.7.0

@uskudnik
Copy link
Contributor Author

@srhb I'll give it a try though I'm not promising tonight :)

@uskudnik
Copy link
Contributor Author

uskudnik commented Sep 16, 2018 •
edited

@srhb I've made it use python2 and included matplotlib which is required for it to work. I've also exposed tsung_stats.pl since it's also something that is frequently used.

@uskudnik
Copy link
Contributor Author

uskudnik commented Oct 1, 2018

@srhb Hey, do you have any other suggestions / objections for this PR?

@srhb
Copy link
Contributor

srhb commented Oct 2, 2018

@uskudnik Hi, thanks for pinging me, I missed your last message. Only one tiny thing and we're ready to merge: Package additions should have commits named like this: "tsung: init at 1.7.0"

See also https://nixos.org/nixpkgs/manual/#idm140737315775440

@uskudnik
Copy link
Contributor Author

uskudnik commented Oct 3, 2018

@srhb Fixed.

@srhb srhb merged commit 9073176 into NixOS:master Oct 3, 2018
@uskudnik uskudnik deleted the tsung-add-package branch October 3, 2018 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@uskudnik @srhb @GrahamcOfBorg