Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broken darwin packages (a) #46584

Merged
merged 11 commits into from Sep 12, 2018
Merged

broken darwin packages (a) #46584

merged 11 commits into from Sep 12, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Sep 12, 2018 •
edited

Motivation for this change

Marks various failing darwin builds as broken or linux only.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@LnL7
alock: mark linux only
139eb11 
The darwin build fails and it's probably not particularly useful there.

    utils.c:33:19: error: use of undeclared identifier 'CLOCK_MONOTONIC'
        clock_gettime(CLOCK_MONOTONIC, &t);

/cc ZHF NixOS#45961
@LnL7
asio: mark broken on darwin
80a4e48 
Started to fail since 1.12.1.

    Undefined symbols for architecture x86_64:
      "boost::chrono::steady_clock::now()", referenced from:
          pinger::start_send() in ping.o
          asio::detail::timer_queue<asio::detail::chrono_time_traits<boost::chrono::steady_clock, asio::wait_traits<boost::chrono::steady_clock> > >::wait_duration_msec(long) const in ping.o
          asio::detail::timer_queue<asio::detail::chrono_time_traits<boost::chrono::steady_clock, asio::wait_traits<boost::chrono::steady_clock> > >::wait_duration_usec(long) const in ping.o
          asio::detail::timer_queue<asio::detail::chrono_time_traits<boost::chrono::steady_clock, asio::wait_traits<boost::chrono::steady_clock> > >::get_ready_timers(asio::detail::op_queue<asio::detail::scheduler_operation>&) in ping.o
          pinger::handle_receive(unsigned long) in p

/cc ZHF NixOS#45961
@LnL7
atlas: mark broken on darwin
f1542f6 
Started to fail since 3.10.3.

    /private/tmp/nix-build-atlas-3.10.3.drv-0/ATLAS/build/bin/ATLrun.sh: line 4: 31119 Segmentation fault: 11  $atldir/$*
    make[3]: *** [Makefile:1695: ssanity_test] Error 139

/cc ZHF NixOS#45961
@LnL7
bitcoin-abc: mark broken on darwin
cf9d1a6 
Last successful build https://hydra.nixos.org/build/74552872.

/cc ZHF NixOS#45961
@LnL7
bitcoin-classic: mark broken on darwin
d990bae 
Last successful build https://hydra.nixos.org/build/74552951.

/cc ZHF NixOS#45961
@LnL7
bitcoin-unlimited: mark broken on darwin
eaff0b7 
/cc ZHF NixOS#45961
@LnL7
bitcoin-xt: mark broken on darwin
8f6ede9 
/cc ZHF NixOS#45961
@LnL7
ethsign: mark broken on darwin
e7ecf59 
Could be caused by our older 10.10.5 CoreFoundation.

    go/src/github.com/ethereum/go-ethereum/vendor/github.com/rjeczalik/notify/watcher_fsevents_cgo.go:51:216:
    cannot use nil as type _Ctype_CFAllocatorRef in argument to func literal
    go/src/github.com/ethereum/go-ethereum/vendor/github.com/rjeczalik/notify/watcher_fsevents_cgo.go:162:47:
    cannot use nil as type _Ctype_CFAllocatorRef in argument to
    _Cfunc_CFStringCreateWithCStringNoCopy
    go/src/github.com/ethereum/go-ethereum/vendor/github.com/rjeczalik/notify/watcher_fsevents_cgo.go:163:225:
    cannot use nil as type _Ctype_CFAllocatorRef in argument to func literal

/cc ZHF NixOS#45961
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Sep 12, 2018
@LnL7
litecoin: add missing framework and mark broken on darwin
0dff3d5 
    In file included from qt/bitcoin.cpp:9:
    ./qt/bitcoingui.h:14:10: fatal error: 'QLabel' file not found
    #include <QLabel>
             ^~~~~~~~
    1 error generated.

/cc ZHF NixOS#45961
@LnL7
aws-okta: mark broken on darwin
b814881 
Could be caused by our older 10.10.5 CoreFoundation.

    # github.com/segmentio/aws-okta/vendor/github.com/keybase/go-keychain
    go/src/github.com/segmentio/aws-okta/vendor/github.com/keybase/go-keychain/corefoundation_go110.go:35:33: cannot use nil as type _Ctype_CFAllocatorRef in argument to _Cfunc_CFDataCreate
    go/src/github.com/segmentio/aws-okta/vendor/github.com/keybase/go-keychain/corefoundation_go110.go:61: cannot use nil as type _Ctype_CFAllocatorRef in argument to func literal
    go/src/github.com/segmentio/aws-okta/vendor/github.com/keybase/go-keychain/corefoundation_go110.go:98:41: cannot use nil as type _Ctype_CFAllocatorRef in argument to _Cfunc_CFStringCreateWithBytes
    go/src/github.com/segmentio/aws-okta/vendor/github.com/keybase/go-keychain/corefoundation_go110.go:133: cannot use nil as type _Ctype_CFAllocatorRef in argument to func literal

/cc ZHF NixOS#45961
@LnL7
asymptote: mark broken on darwin
9fc6f11 
It only builds with gc-7.6.0 on darwin for some reason.

/cc ZHF NixOS#45961
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: alock, asio, asymptote, atlas, aws-okta, bitcoin-xt, ethsign

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: alock, asio, asymptote, atlas, aws-okta, bitcoin-xt, ethsign

Partial log (click to expand)

installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/saajw4hm8gm7p58l9ydfa1bzi2ixndjf-ethsign-0.8.2-bin
shrinking /nix/store/saajw4hm8gm7p58l9ydfa1bzi2ixndjf-ethsign-0.8.2-bin/bin/ethsign
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/saajw4hm8gm7p58l9ydfa1bzi2ixndjf-ethsign-0.8.2-bin/bin
patching script interpreter paths in /nix/store/saajw4hm8gm7p58l9ydfa1bzi2ixndjf-ethsign-0.8.2-bin
checking for references to /build in /nix/store/saajw4hm8gm7p58l9ydfa1bzi2ixndjf-ethsign-0.8.2-bin...
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
error: build of '/nix/store/cikyqczmwfpn9jj8bnihwgssf2mnp4hv-atlas-3.10.3.drv', '/nix/store/phc970y0flc5anpbzsjbic9bszwypxgi-asymptote-2.47.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: alock, asio, asymptote, atlas, aws-okta, bitcoin-xt, ethsign

Partial log (click to expand)

patching script interpreter paths in /nix/store/xsaf97p5ndv9fbq37dgqni46404ip28q-ethsign-0.8.2-bin
checking for references to /build in /nix/store/xsaf97p5ndv9fbq37dgqni46404ip28q-ethsign-0.8.2-bin...
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
/nix/store/hwdf5kn79zc6dw4kyv1ga3acvmiipcn1-alock-20170720
/nix/store/84mcjrj2x5gy3r315ry0acqd87cpzhfk-asio-1.12.1
/nix/store/jivkda61d8iqnn6h7y1k14kp6fafhhh4-asymptote-2.47
/nix/store/z9wrxh2kp9c18di9s2jq4fsr1pq88zw4-atlas-3.10.3
/nix/store/f3gkmcz485ypizjrjzqd8pjgddy7qc98-aws-okta-0.19.0-bin
/nix/store/vpzni4pd3p0hyl6fac3kdvvrq63pj8q1-bitcoin-xt-0.11H
/nix/store/xsaf97p5ndv9fbq37dgqni46404ip28q-ethsign-0.8.2-bin

@LnL7 LnL7 merged commit 89e5215 into NixOS:master Sep 12, 2018
@LnL7 LnL7 deleted the darwin-broken-a branch September 12, 2018 22:05
@LnL7 LnL7 mentioned this pull request Sep 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LnL7 @GrahamcOfBorg